ovyalov updated this revision to Diff 63255.
ovyalov added a comment.
Reran with proper clang-format.
http://reviews.llvm.org/D22081
Files:
source/Plugins/Platform/Android/AdbClient.cpp
source/Plugins/Platform/Android/AdbClient.h
source/Plugins/Platform/Android/PlatformAndroid.cpp
Index:
Author: ovyalov
Date: Fri Jul 8 12:45:37 2016
New Revision: 274895
URL: http://llvm.org/viewvc/llvm-project?rev=274895&view=rev
Log:
Use shell cat command as a workaround if ADB stat cannot lookup a file.
http://reviews.llvm.org/D22081
Modified:
lldb/trunk/source/Plugins/Platform/Android/A
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.h
/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp
Users:
ovyalov (Author)
http://reviews.llvm.or
Author: ovyalov
Date: Tue Jul 12 13:14:27 2016
New Revision: 275198
URL: http://llvm.org/viewvc/llvm-project?rev=275198&view=rev
Log:
Add logging to Linux Host::GetProcessAndStatInfo.
Modified:
lldb/trunk/source/Host/linux/Host.cpp
Modified: lldb/trunk/source/Host/linux/Host.cpp
URL:
http:/
Author: ovyalov
Date: Thu Jul 21 12:03:25 2016
New Revision: 276303
URL: http://llvm.org/viewvc/llvm-project?rev=276303&view=rev
Log:
Add check for non-null log instance in PlatformAndroid.
Modified:
lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp
Modified: lldb/trunk/source/
Author: ovyalov
Date: Fri Aug 5 19:42:23 2016
New Revision: 277895
URL: http://llvm.org/viewvc/llvm-project?rev=277895&view=rev
Log:
Fix Windows build - add return statement in
SBThread::StepUsingScriptedThreadPlan.
Modified:
lldb/trunk/source/API/SBThread.cpp
Modified: lldb/trunk/source/A
Author: ovyalov
Date: Fri Dec 11 20:13:17 2015
New Revision: 255419
URL: http://llvm.org/viewvc/llvm-project?rev=255419&view=rev
Log:
Remove unused mips typedefs.
Modified:
lldb/trunk/source/Plugins/Process/Linux/Procfs.h
Modified: lldb/trunk/source/Plugins/Process/Linux/Procfs.h
URL:
http
ovyalov accepted this revision.
This revision is now accepted and ready to land.
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp:973
@@ +972,3 @@
+{
+// PTRACE_PEEKUSER don't work in the aarch64 liux kernel used on android
devices (always return
+
ovyalov accepted this revision.
Comment at:
packages/Python/lldbsuite/test/python_api/disassemble-raw-data/TestDisassembleRawData.py:29
@@ +28,3 @@
+elif re.match("mips",arch):
+ target = self.dbg.CreateTargetWithFileAndTargetTriple ("", "mips")
+
ovyalov added a comment.
vdso issue is related to ELF format and I'm wondering whether we can keep the
fix contained in ObjectFileELF - for example, if a section that we're trying to
read is beyond the boundaries of memory buffer we can read its content from
inferior's memory using ObjectFile::
ovyalov added a comment.
If vdso bug pertains to ELF format then it looks reasonable to keep the fix
within ObjectFileELF.
I experimented a while ago with making ObjectFileELF to read from arbitrary
offsets - please see http://reviews.llvm.org/D16151 as reflection of this idea
(patch is pretty
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
http://reviews.llvm.org/D16244
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: ovyalov
Date: Tue Jan 19 11:54:47 2016
New Revision: 258150
URL: http://llvm.org/viewvc/llvm-project?rev=258150&view=rev
Log:
Implementing the method Target::TargetEventData::Dump (Stream *s) so that its
clients can easily dump it out for informational messages.
http://reviews.llvm.org/D
ovyalov closed this revision.
ovyalov added a comment.
Submitted as http://reviews.llvm.org/rL258150
http://reviews.llvm.org/D16244
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
http://reviews.llvm.org/D16720
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov created this revision.
ovyalov added reviewers: sivachandra, tberghammer.
ovyalov added a subscriber: lldb-commits.
Pass socket scheme as part of debug server listen URL in order to fix custom
protocols like unix-abstract.
http://reviews.llvm.org/D16861
Files:
source/Plugins/Process/g
Author: ovyalov
Date: Wed Feb 3 16:02:43 2016
New Revision: 259714
URL: http://llvm.org/viewvc/llvm-project?rev=259714&view=rev
Log:
Pass socket scheme as part of debug server listen URL.
http://reviews.llvm.org/D16861
Modified:
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommun
ovyalov closed this revision.
ovyalov added a comment.
Submitted as http://reviews.llvm.org/rL259714
http://reviews.llvm.org/D16861
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py:22
@@ -20,1 +21,3 @@
+# Backtracing failed due to lack of prolog/epilog informations in assert
function of libc.so.6
+@expectedFailureAll(tripl
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D17131
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D17295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D17510
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
ovyalov accepted this revision.
This revision is now accepted and ready to land.
Comment at: source/Plugins/Process/Linux/NativeThreadLinux.cpp:250
@@ +249,3 @@
+log->Printf("NativeThreadLinux::%s Unable to get cpu affinity for
thread %" PRIx64 ": %s", __FUNCTION__,
+
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
http://reviews.llvm.org/D17604
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov accepted this revision.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserJava.cpp:35
@@ +34,3 @@
+lldb::TypeSP
+DWARFASTParserJava::ParseTypeFromDWARF(const lldb_private::SymbolContext &sc,
const DWARFDIE &die,
+ lldb_private
Author: ovyalov
Date: Thu Feb 25 22:01:58 2016
New Revision: 261974
URL: http://llvm.org/viewvc/llvm-project?rev=261974&view=rev
Log:
Make TestPlatformProcessConnect to support abstract/domain sockets.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/platform-process-co
ovyalov accepted this revision.
ovyalov added a comment.
lgtm
Repository:
rL LLVM
http://reviews.llvm.org/D18858
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov created this revision.
ovyalov added a reviewer: clayborg.
ovyalov added a subscriber: lldb-commits.
Reset continue_after_async only if neither SIGINIT nor SIGSTOP received -
otherwise it leads to stopped inferior when setting breakpoint (when
m_interrupt_sent == true and signal is SIGST
ovyalov updated this revision to Diff 53054.
ovyalov added a comment.
Added new TestBreakpointSetRestart test to cover the addressed issue.
http://reviews.llvm.org/D18886
Files:
packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_set_restart/Makefile
packages/Python/lldbs
ovyalov added a comment.
In http://reviews.llvm.org/D18886#395216, @labath wrote:
> Does this fix an existing test or is a new issue? If it's new (it sounds like
> it is, as I don't see any test failures), could you also add a test for this.
> It shouldn't be too difficult to write one... Would
Author: ovyalov
Date: Fri Apr 8 15:44:28 2016
New Revision: 265843
URL: http://llvm.org/viewvc/llvm-project?rev=265843&view=rev
Log:
Reset continue_after_async only if neither SIGINIT nor SIGSTOP received.
http://reviews.llvm.org/D18886
Added:
lldb/trunk/packages/Python/lldbsuite/test/fun
ovyalov closed this revision.
ovyalov added a comment.
Submitted as http://reviews.llvm.org/rL265843
http://reviews.llvm.org/D18886
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: ovyalov
Date: Fri Apr 8 22:08:02 2016
New Revision: 265869
URL: http://llvm.org/viewvc/llvm-project?rev=265869&view=rev
Log:
Fix TestBreakpointSetRestart failure on Android.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_set_restart/TestBr
ovyalov added a comment.
In http://reviews.llvm.org/D18886#397637, @amccarth wrote:
> FYI: According to git bisect, this patch seems to have introduced a new test
> failure on Windows.
Thanks for the report - will fix today.
http://reviews.llvm.org/D18886
ovyalov accepted this revision.
This revision is now accepted and ready to land.
Comment at:
packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_set_restart/main.cpp:11
@@ -10,2 +10,3 @@
+#include
#include
#include
You may remove iostream si
Author: ovyalov
Date: Tue Apr 12 23:21:05 2016
New Revision: 266164
URL: http://llvm.org/viewvc/llvm-project?rev=266164&view=rev
Log:
Attempt to fix TestCPPBreakpointLocations on Linux/Android.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/cpp/TestCPPBreakpo
ovyalov created this revision.
ovyalov added a reviewer: granata.enrico.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Fix Android build after r266267
http://reviews.llvm.org/D19092
Files:
source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleO
Author: ovyalov
Date: Wed Apr 13 21:02:12 2016
New Revision: 266274
URL: http://llvm.org/viewvc/llvm-project?rev=266274&view=rev
Log:
Fix Android build after r266267
Modified:
lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
Modified:
lldb/trunk/sourc
ovyalov added a comment.
Submitted as http://reviews.llvm.org/rL266274
http://reviews.llvm.org/D19092
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov added a comment.
In http://reviews.llvm.org/D19092#401450, @jingham wrote:
> Why is this necessary? stdout is a local variable defined in this scope.
> Why would the android g++ have problems with this?
>
> Anyway, if you have to avoid using stdout as a name, maybe name it std_out as
Author: ovyalov
Date: Thu Apr 14 19:56:11 2016
New Revision: 266401
URL: http://llvm.org/viewvc/llvm-project?rev=266401&view=rev
Log:
Rename out->std_out in AppleObjCRuntimeV2.cpp.
Modified:
lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
Modified:
l
Author: ovyalov
Date: Sat Apr 16 11:29:17 2016
New Revision: 266530
URL: http://llvm.org/viewvc/llvm-project?rev=266530&view=rev
Log:
Fix cmake build after r266524.
Modified:
lldb/trunk/source/Core/RegisterValue.cpp
Modified: lldb/trunk/source/Core/RegisterValue.cpp
URL:
http://llvm.org/vi
ovyalov added inline comments.
Comment at: lldb/trunk/cmake/platforms/Android.cmake:110
@@ -109,1 +109,3 @@
endif()
+elseif( ANDROID_ABI STREQUAL "mips" )
+ # http://b.android.com/182094
Do we need the same workaround for mips64?
Repository:
rL LLVM
http://
ovyalov added a comment.
Please see my comments.
Comment at: source/Plugins/Platform/Android/PlatformAndroid.cpp:284
@@ +283,3 @@
+std::string version_string;
+RunShellCommand("getprop ro.build.version.sdk",
+GetWorkingDirectory(),
Co
ovyalov added a comment.
Please see my comments.
Comment at: source/Plugins/Platform/Android/PlatformAndroid.cpp:306
@@ +305,3 @@
+if (!module_sp->GetPlatformFileSpec())
+return Error("No platform file specified");
+
indentation.
Co
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at: source/Plugins/Platform/Android/PlatformAndroid.cpp:292
@@ +291,3 @@
+ 1);
+if (error.Fail() || status != 0 || v
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: source/Utility/ModuleCache.cpp:207
@@ +206,3 @@
+
+FileSpec symfile_spec((cached_module_sp->GetFileSpec ().GetPath () +
".sym").c_str (), false);
+
ovyalov created this revision.
ovyalov added reviewers: spyffe, chying, clayborg.
ovyalov added a subscriber: lldb-commits.
Mark TestCModules as XFAIL on OSX in order to make build bot green -
http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/4722
http://reviews.llvm.org/D11962
F
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D11967
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
ovyalov updated this revision to Diff 31956.
ovyalov added a comment.
Added bug id to XFAIL decorators
http://reviews.llvm.org/D11962
Files:
test/lang/c/modules/TestCModules.py
Index: test/lang/c/modules/TestCModules.py
===
---
ovyalov created this revision.
ovyalov added reviewers: clayborg, tberghammer, chaoren.
ovyalov added a subscriber: lldb-commits.
UriParser:Parse expects that host name doesn't contain special URL symbols -
":", ";", "$",...
However, in case of adb protocol (adb://$device_serial_no:$port) it pos
ovyalov added a comment.
In http://reviews.llvm.org/D12025#224355, @tberghammer wrote:
> The implementation looks good, but I don't like the approach you try to
> handle the problem.
>
> I think you do far too much work to use UriParser in a case where it isn't
> necessary and isn't make things
Author: ovyalov
Date: Fri Aug 14 16:16:00 2015
New Revision: 245100
URL: http://llvm.org/viewvc/llvm-project?rev=245100&view=rev
Log:
Fix Linux build after r245090.
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp
URL:
http://llvm
Author: ovyalov
Date: Fri Aug 14 18:57:15 2015
New Revision: 245129
URL: http://llvm.org/viewvc/llvm-project?rev=245129&view=rev
Log:
Fix Android build.
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.h
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/Symbol
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
http://reviews.llvm.org/D12083
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov accepted this revision.
Comment at: include/lldb/Core/RegisterValue.h:51
@@ -51,2 +50,3 @@
{
+m_scalar = (unsigned long)0;
}
Nit: you can initialize m_scalar within initializer list.
Comment at: include/lldb/
Author: ovyalov
Date: Tue Aug 18 16:20:25 2015
New Revision: 245357
URL: http://llvm.org/viewvc/llvm-project?rev=245357&view=rev
Log:
Mark TestCModules as XFAIL on OSX.
http://reviews.llvm.org/D11962
Modified:
lldb/trunk/test/lang/c/modules/TestCModules.py
Modified: lldb/trunk/test/lang/c/
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/test/lang/c/modules/TestCModules.py
Users:
ovyalov (Author)
http://reviews.llvm.org/rL245357
http://reviews.llvm.org/D11962
___
lldb-commits mailing list
lldb-commits@
ovyalov added a comment.
Please see my comments.
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:1457
@@ -1453,3 +1456,3 @@
-thread_sp = AddThread(pid);
+thread_sp =
std::static_pointer_cast(AddThread(pid));
assert (thread_sp.get() &&
ovyalov added a comment.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D12100
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:3051
@@ +3050,3 @@
+return step_result;
+}
+default:
Let's go ahead wit
ovyalov retitled this revision from "Make LLDB URLs to support hex encoding for
special symbols" to "Make UriParser to support [$HOSTNAME] notation.".
ovyalov updated the summary for this revision.
ovyalov updated this revision to Diff 32655.
ovyalov added a comment.
Herald added subscribers: srhi
ovyalov added inline comments.
Comment at: source/Utility/UriParser.cpp:13
@@ -12,4 +12,3 @@
// C Includes
-#include
-#include
+#include
tberghammer wrote:
> I think you wanted to include , not
I need string.h for strlen - it's required even with included
ovyalov updated this revision to Diff 32701.
ovyalov marked an inline comment as done.
ovyalov added a comment.
Replaced #include with
http://reviews.llvm.org/D12025
Files:
source/Host/posix/ConnectionFileDescriptorPosix.cpp
source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.c
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:2834
@@ -2843,3 +2833,3 @@
-NativeThreadProtocolSP thread_sp (new NativeThreadLinux (this, thread_id));
+NativeThreadLinuxSP thread_sp (new Nat
Author: ovyalov
Date: Thu Aug 20 18:09:34 2015
New Revision: 245639
URL: http://llvm.org/viewvc/llvm-project?rev=245639&view=rev
Log:
Make UriParser to support [$HOSTNAME] notation.
http://reviews.llvm.org/D12025
Modified:
lldb/trunk/source/Host/posix/ConnectionFileDescriptorPosix.cpp
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/source/Host/posix/ConnectionFileDescriptorPosix.cpp
/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp
/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.h
/lldb/t
ovyalov closed this revision.
ovyalov added a comment.
Closed with r223091
http://reviews.llvm.org/D6392
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: ovyalov
Date: Tue Sep 1 14:02:14 2015
New Revision: 246574
URL: http://llvm.org/viewvc/llvm-project?rev=246574&view=rev
Log:
Make remote-android platform to use dynamic local tcp ports when forwarding
device ports.
http://reviews.llvm.org/D12510
Modified:
lldb/trunk/source/Plugin
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
http://reviews.llvm.org/D12552
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: source/Core/Module.cpp:1712
@@ -1712,1 +1711,3 @@
+if (!FileSpec::Equal (file_spec, m_file,
(bool)file_spec.GetDirectory()) &&
+!FileSp
ovyalov created this revision.
ovyalov added a reviewer: clayborg.
ovyalov added a subscriber: lldb-commits.
Python locks in memory a few global objects like lldb.debugger,lldb.target,...
- as a consequence, ~Debugger isn't called upon shutdown.
Calling Debugger::Clear ensures that ScriptInterpr
ovyalov added a comment.
In http://reviews.llvm.org/D12683#241155, @zturner wrote:
> What were the symptoms of this? How'd you find it?
I was debugging port forwarding with PlatformAndroid - in particular, whether
forwarded ports are cleaned up with ~PlatformAndroidRemoteGDBServer. Turned
ou
ovyalov added inline comments.
Comment at: source/Core/Debugger.cpp:426
@@ +425,3 @@
+for (const auto& debugger: debuggers)
+debugger->Clear();
+
tfiala wrote:
> Wouldn't Clear() be considered a mutating function? So a const debugger ref
> seems like
Author: ovyalov
Date: Tue Sep 8 11:26:32 2015
New Revision: 247023
URL: http://llvm.org/viewvc/llvm-project?rev=247023&view=rev
Log:
Fix debugger shutdown when Python interpreter is loaded.
http://reviews.llvm.org/D12683
Modified:
lldb/trunk/source/Core/Debugger.cpp
Modified: lldb/trunk/s
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/source/Core/Debugger.cpp
Users:
ovyalov (Author)
http://reviews.llvm.org/rL247023
http://reviews.llvm.org/D12683
___
lldb-commits mailing list
lldb-commits@lists.llvm.
Author: ovyalov
Date: Tue Sep 8 17:41:13 2015
New Revision: 247090
URL: http://llvm.org/viewvc/llvm-project?rev=247090&view=rev
Log:
Reverting r247000 since it's causing
TestRegisters.test_fp_special_purpose_register_read to fail on OSX.
Modified:
lldb/trunk/test/functionalities/register/T
ovyalov added a subscriber: ovyalov.
ovyalov added a comment.
I reverted the CL because it was causing
TestRegisters.test_fp_special_purpose_register_read to fail on OSX:
- stop reason = EXC_BREAKPOINT
- "register read ftag" yields 0x80 instead of expected 0x8000
http://reviews.llvm.org/D126
ovyalov added a comment.
In http://reviews.llvm.org/D12677#242290, @abhishek.aggarwal wrote:
> In http://reviews.llvm.org/D12677#242006, @ovyalov wrote:
>
> > I reverted the CL because it was causing
> > TestRegisters.test_fp_special_purpose_register_read to fail on OSX:
> >
> > - stop reason =
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D12795
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
Author: ovyalov
Date: Fri Sep 11 15:46:46 2015
New Revision: 247469
URL: http://llvm.org/viewvc/llvm-project?rev=247469&view=rev
Log:
Add missed import lldbtest.
Modified:
lldb/trunk/test/functionalities/data-formatter/stringprinter/TestStringPrinter.py
lldb/trunk/test/lang/c/struct_typ
ovyalov created this revision.
ovyalov added reviewers: clayborg, tberghammer.
ovyalov added a subscriber: lldb-commits.
Add plugin.jit-loader.gdb.enable-jit-breakpoint property to make JIT loader
breakpoint optional with default value set true.
If we're not interested in debugging JIT code there
ovyalov added inline comments.
Comment at: source/Core/PluginManager.cpp:2628
@@ -2627,3 +2627,3 @@
static lldb::OptionValuePropertiesSP
GetDebuggerPropertyForPluginsOldStyle (Debugger &debugger,
const ConstString &plugin_type_name,
--
Author: ovyalov
Date: Wed Sep 16 12:38:36 2015
New Revision: 247821
URL: http://llvm.org/viewvc/llvm-project?rev=247821&view=rev
Log:
Add plugin.jit-loader.gdb.enable-jit-breakpoint property to make JIT loader
breakpoint optional.
http://reviews.llvm.org/D12890
Modified:
lldb/trunk/include
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/include/lldb/Core/PluginManager.h
/lldb/trunk/source/Core/PluginManager.cpp
/lldb/trunk/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
/lldb/trunk/source/Plugins/JITLoader/GDB/JITLoaderGDB.h
Users:
ovyalov (Autho
ovyalov created this revision.
ovyalov added reviewers: clayborg, zturner.
ovyalov added a subscriber: lldb-commits.
When putting a new module into module cache sysroot folder may contain existing
hard link for an existing module with the same name but different build-id.
Use hard link counter t
ovyalov updated this revision to Diff 35106.
ovyalov added a comment.
Replaced GENERIC_READ with FILE_READ_ATTRIBUTES when using ::CreateFile.
http://reviews.llvm.org/D12971
Files:
include/lldb/Host/FileSystem.h
source/Host/posix/FileSystem.cpp
source/Host/windows/FileSystem.cpp
source/
ovyalov added inline comments.
Comment at: source/Host/windows/FileSystem.cpp:130
@@ +129,3 @@
+HANDLE file_handle = ::CreateFile(file_spec.GetCString(),
+ FILE_READ_ATTRIBUTES,
+ FILE_SHARE_READ,
--
Author: ovyalov
Date: Fri Sep 18 13:12:39 2015
New Revision: 248017
URL: http://llvm.org/viewvc/llvm-project?rev=248017&view=rev
Log:
Remove unused modules from module cache.
http://reviews.llvm.org/D12971
Modified:
lldb/trunk/include/lldb/Host/FileSystem.h
lldb/trunk/source/Host/posix
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/include/lldb/Host/FileSystem.h
/lldb/trunk/source/Host/posix/FileSystem.cpp
/lldb/trunk/source/Host/windows/FileSystem.cpp
/lldb/trunk/source/Utility/ModuleCache.cpp
Users:
ovyalov (Author)
http://reviews.llvm.
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
Minor comments
Comment at: source/Plugins/Platform/Android/AdbClient.cpp:231
@@ +230,3 @@
+
+size_t n = m_conn.Read(buffer, sizeof(buffer), 1000 * (timeout_ms -
ela
ovyalov added a subscriber: ovyalov.
ovyalov added a comment.
It looks like this CL is introducing additional latency when destroying process
- I noticed 10 seconds delay when destroying Android process and got logs for
code with this CL and without:
1443231085.125153000 Process::StopForDestroy
Author: ovyalov
Date: Mon Sep 28 12:42:16 2015
New Revision: 248722
URL: http://llvm.org/viewvc/llvm-project?rev=248722&view=rev
Log:
Bind listener to 127.0.0.1 to make sure that loopback address is used.
Modified:
lldb/trunk/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cp
101 - 193 of 193 matches
Mail list logo
