ovyalov accepted this revision. ovyalov added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: source/Utility/ModuleCache.cpp:207 @@ +206,3 @@ + + FileSpec symfile_spec((cached_module_sp->GetFileSpec ().GetPath () + ".sym").c_str (), false); + error = Put (root_dir_spec, hostname, module_spec, tmp_download_sym_file_spec, symfile_spec); ---------------- s/.sym/kSymFileExtension Or maybe introduce a function that returns symbol file spec by given module file spec in order to re-use it here and in ModuleCache::Get http://reviews.llvm.org/D11936 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
