[Lldb-commits] [PATCH] D157589: [lldb] Fix building with latest libc++

mstorsjo created this revision. mstorsjo added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. Since https://reviews.llvm.org/D157058 in libc++, the base template for char_traits has been removed - it is

[Lldb-commits] [PATCH] D157589: [lldb] Fix building with latest libc++

This revision was automatically updated to reflect the committed changes. Closed by commit rG68744ffbdd7d: [lldb] Fix building with latest libc++ (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157589/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D158391: [lldb][debugserver] Fix build after libcxx removed generic char_traits implementation

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158391/new/ https://reviews.llvm.org/D158391 ___

[Lldb-commits] [PATCH] D156817: [lldb][windows] _wsopen_s does not accept bits other than `_S_IREAD | _S_IWRITE`

mstorsjo added a comment. I noticed this review is accepted but not committed. If you don't have commit access, what's your preferred git identity, i.e. `Real Name `? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156817/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D156817: [lldb][windows] _wsopen_s does not accept bits other than `_S_IREAD | _S_IWRITE`

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a4b3fdb8232: [lldb][windows] _wsopen_s does not accept bits other than `_S_IREAD | _S_IWRITE` (authored by yshui, committed by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D156817?vs=54

[Lldb-commits] [PATCH] D116467: Deprecate `LLVM_LIBRARY_DIRS`

mstorsjo added subscribers: beanz, mstorsjo. mstorsjo added a reviewer: beanz. mstorsjo added a comment. This looks reasonable to me, but I'm not sure if I know all the aspects that might be at play here, so I don't think I'm comfortable with accepting it on my own. Adding @beanz who should know

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mstorsjo added a comment. This broke building ANGLE as part of Qt 5.15 for a mingw target, with the following error: ../../../3rdparty/angle/src/libANGLE/renderer/d3d/d3d11/ResourceManager11.cpp:532:38: error: explicit instantiation of 'allocate' does not refer to a function template, varia

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mstorsjo added a comment. In D110216#3130193 , @mizvekov wrote: > In D110216#3130184 , @mstorsjo > wrote: > >> Do you happen to know what's going on here? The files mentioned are >> https://code.qt.io/cgit/qt/qt

[Lldb-commits] [PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

mstorsjo added inline comments. Comment at: llvm/CMakeLists.txt:75 set(LLVM_ENABLE_PROJECTS "" CACHE STRING - "Semicolon-separated list of projects to build (${LLVM_KNOWN_PROJECTS}), or \"all\".") + "Semicolon-separated list of projects to build (${LLVM_KNOWN_PROJECTS})

[Lldb-commits] [PATCH] D116625: [lldb] [debugserver] Simplify handling of arch specific files

mstorsjo created this revision. mstorsjo added reviewers: labath, JDevlieghere, jasonmolenda, clayborg. Herald added subscribers: kristof.beyls, mgorny. mstorsjo requested review of this revision. Herald added a project: LLDB. There are no duplicates among the include files, and all the source fil

[Lldb-commits] [PATCH] D116625: [lldb] [debugserver] Simplify handling of arch specific files

This revision was automatically updated to reflect the committed changes. Closed by commit rG1919720fdd34: [lldb] [debugserver] Simplify handling of arch specific files (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116625/new/

[Lldb-commits] [PATCH] D118405: [LLD][MinGW] Add --heap argument support

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. Thanks, I tested it and it seems to work fine. (FWIW the comma-separated form of the option is pretty hard to pass via `-Wl` through the compiler driver, but with `-Xlinker --heap -Xlinker

[Lldb-commits] [PATCH] D118405: [LLD][MinGW] Add --heap argument support

This revision was automatically updated to reflect the committed changes. Closed by commit rG460830a9c664: [LLD][MinGW] Add --heap argument support (authored by mati865, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118405/new

[Lldb-commits] [PATCH] D128410: [lldb] Add a testcase for nested exceptions on Windows

mstorsjo added a comment. In D128410#3608190 , @labath wrote: > In D128410#3604927 , @alvinhochun > wrote: > >> It may be possible to stuff a pointer to an `EXCEPTION_RECORD` into another >> `EXCEPTION_RECORD` a

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

mstorsjo added a comment. In D128268#3608197 , @labath wrote: > In D128268#3604555 , @mstorsjo > wrote: > >> I found that this duality was introduced in >> 5e6f45201f0b62c1e7a24fc396f3ea6e10dc880d / D7120 >>

[Lldb-commits] [PATCH] D128617: [lldb] Stop passing both i386 and i686 in parallel as architectures on Windows

mstorsjo created this revision. mstorsjo added reviewers: labath, zturner, DavidSpickett. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. When an object file returns multiple architectures, it is treated as a fat binary - which really isn't th

[Lldb-commits] [PATCH] D128668: [LLDB] Fix PDB/pointers.test for 32bit Arm/Windows

mstorsjo added a comment. I presume this is ok - if the main intent of this test is to test handling of pointers and the size thereof in PDBs. Comment at: lldb/test/Shell/SymbolFile/PDB/pointers.test:2 REQUIRES: system-windows, msvc RUN: %build --compiler=clang-cl --mode=com

[Lldb-commits] [PATCH] D128668: [LLDB] Fix PDB/pointers.test for 32bit Arm/Windows

mstorsjo accepted this revision. mstorsjo added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/Shell/SymbolFile/PDB/pointers.test:2 REQUIRES: system-windows, msvc RUN: %build --compiler=clang-cl --mode=compile --arch=32 --nodefaultlib -

[Lldb-commits] [PATCH] D128678: [LLDB] Add PDB/Calling-conentions.test for Arm/Windows

mstorsjo added a comment. There's consistent typos about the test name in the commit subject and description. Comment at: lldb/test/Shell/SymbolFile/PDB/calling-conventions-arm.test:1 +REQUIRES: system-windows, lld, (target-arm || target-aarch64) +RUN: %build --compiler=clang

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

mstorsjo added a comment. In D128268#3614661 , @labath wrote: > In D128268#3611053 , @mstorsjo > wrote: > >> The odd thing about the second one is the added hardcoded >> `AddArch(ArchSpec("i686-pc-windows"));` a

[Lldb-commits] [PATCH] D128678: [LLDB] Add PDB/calling-conventions.test for Arm/Windows

mstorsjo added a comment. Thanks, this looks more complete and consistent to me now! In D128678#3615531 , @labath wrote: > It seems like this is not actually running the code. Can we make it such that > these tests are conditional on the appropriate llv

[Lldb-commits] [PATCH] D128617: [lldb] Stop passing both i386 and i686 in parallel as architectures on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG4270c9cd44f2: [lldb] Stop passing both i386 and i686 in parallel as architectures on Windows (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D129455: [lldb] Reduce the stack alignment requirements for the Windows x86_64 ABI

mstorsjo created this revision. mstorsjo added reviewers: labath, jasonmolenda. Herald added a subscriber: jsji. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. This fixes https://github.com/llvm/llvm-project/issues/56095. @labath, FWIW while

[Lldb-commits] [PATCH] D129455: [lldb] Reduce the stack alignment requirements for the Windows x86_64 ABI

mstorsjo added a comment. In D129455#3641967 , @labath wrote: > You say that the issue is the lack of symtab in the "msvc" mode. What makes > this test work then? When invoked via the `%build` python script (lldb/test/Shell/helper/build.py), clang is i

[Lldb-commits] [PATCH] D129455: [lldb] Reduce the stack alignment requirements for the Windows x86_64 ABI

mstorsjo added a comment. In D129455#3642015 , @mstorsjo wrote: > In D129455#3641967 , @labath wrote: > >> What does `-Wl,-debug:symtab` actually produce? Would it make sense to make >> it a part of the `%clang_h

[Lldb-commits] [PATCH] D129455: [lldb] Reduce the stack alignment requirements for the Windows x86_64 ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rG66cdd6548ac5: [lldb] Reduce the stack alignment requirements for the Windows x86_64 ABI (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D130309: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

mstorsjo added a comment. I ran into this build break too - please try to fix or revert! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130309/new/ https://reviews.llvm.org/D130309 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D130309: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

mstorsjo added a comment. In D130309#3672934 , @clayborg wrote: > Submitted a fix for the buildbots: > > commit f959d815f4637890ebbacca379f1c38ab47e4e14 > (HEAD > -> main) > Author: G

[Lldb-commits] [PATCH] D130309: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

mstorsjo added a comment. In D130309#3673045 , @clayborg wrote: > Another fix for linux: > > commit 0bbce7a4c2d2bff622bdadd4323f93f5d90e6d24 > (HEAD > -> main, origin/main, origin/HEA

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

mstorsjo added a comment. This broke building of Clang, when it's set up by symlinking `llvm-project/clang` into `llvm-project/llvm/tools`. In that case, cmake configure errors out like this: -- Configuring done CMake Error in tools/clang/tools/clang-fuzzer/handle-cxx/CMakeLists.txt: T

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

mstorsjo added a comment. In D129377#3673237 , @mib wrote: > In D129377#3673204 , @mstorsjo > wrote: > >> This broke building of Clang, when it's set up by symlinking >> `llvm-project/clang` into `llvm-project/l

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

mstorsjo added a comment. In D129377#3673237 , @mib wrote: > In D129377#3673204 , @mstorsjo > wrote: > >> This broke building of Clang, when it's set up by symlinking >> `llvm-project/clang` into `llvm-project/l

[Lldb-commits] [PATCH] D130942: [LLDB][DWARF] Set MSInheritanceAttr for record decl when it's using Microsoft compatible ABI.

mstorsjo added a comment. This looks sensible to me, although it might be good if someone else more familiar with this code has a look too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130942/new/ https://reviews.llvm.org/D130942 ___

[Lldb-commits] [PATCH] D130942: [LLDB][DWARF] Set MSInheritanceAttr for record decl when it's using Microsoft compatible ABI.

mstorsjo added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1754 + m_ast.getASTContext(), + clang::MSInheritanceAttr::Spelling::Keyword_unspecified_inheritance)); +} rnk wrote: > I'm concerned th

[Lldb-commits] [PATCH] D130942: [LLDB][DWARF] Set MSInheritanceAttr for record decl when it's using Microsoft compatible ABI.

mstorsjo added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1754 + m_ast.getASTContext(), + clang::MSInheritanceAttr::Spelling::Keyword_unspecified_inheritance)); +} rnk wrote: > mstorsjo wrote:

[Lldb-commits] [PATCH] D131159: [lldb] Use WSAEventSelect for MainLoop polling on windows

mstorsjo added a subscriber: alvinhochun. mstorsjo added a comment. I don't really have experience with this API - is this pattern (creating and closing event objects for each poll run) the common way of using this API? Is there any potential performance risk compared with keeping event objects

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

mstorsjo added a comment. In D130689#3700094 , @thakis wrote: > In D130689#3696186 , @thieta wrote: > >> @nikic @thakis I fixed this issue in https://reviews.llvm.org/D131063 and it >> can be built with CXX_STAND

[Lldb-commits] [PATCH] D131159: [lldb] Use WSAEventSelect for MainLoop polling on windows

mstorsjo added a comment. In D131159#3709965 , @labath wrote: >> Can @alvinhochun take the patch for a spin? I think you've got more >> realistic usecases of lldb to try it out in. (Do you want me to make a build >> with the patch for you to try out?) @

[Lldb-commits] [PATCH] D131159: [lldb] Use WSAEventSelect for MainLoop polling on windows

mstorsjo added a comment. In D131159#3711024 , @mstorsjo wrote: > In D131159#3709965 , @labath wrote: > >>> Can @alvinhochun take the patch for a spin? I think you've got more >>> realistic usecases of lldb to tr

[Lldb-commits] [PATCH] D130942: [LLDB][DWARF] Set MSInheritanceAttr for record decl when it's using Microsoft compatible ABI.

mstorsjo added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1754 + m_ast.getASTContext(), + clang::MSInheritanceAttr::Spelling::Keyword_unspecified_inheritance)); +} mstorsjo wrote: > rnk wrote:

[Lldb-commits] [PATCH] D131159: [lldb] Use WSAEventSelect for MainLoop polling on windows

mstorsjo added a comment. FYI, this patch added some new compilation warnings: [4055/7050] Building CXX object tools/lldb/source/Host/CMakeFiles/lldbHost.dir/windows/MainLoopWindows.cpp.obj llvm-project/lldb/source/Host/windows/MainLoopWindows.cpp:28:9: warning: unused variable 'result' [-W

[Lldb-commits] [PATCH] D131159: [lldb] Use WSAEventSelect for MainLoop polling on windows

mstorsjo added a comment. In D131159#3742370 , @labath wrote: > In D131159#3742364 , @mgorny wrote: > >> In D131159#3742235 , @mstorsjo >> wrote: >> >>> (They're only use

[Lldb-commits] [PATCH] D122389: [lldb] Fix interpreting absolute Windows paths with forward slashes

mstorsjo created this revision. mstorsjo added a reviewer: labath. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. In practice, Windows paths can use either backslashes or forward slashes. This fixes an issue reported downstream at https://gi

[Lldb-commits] [PATCH] D122486: [lldb] Fix building for mingw after changes to sigtstp_handler

mstorsjo created this revision. mstorsjo added a reviewer: labath. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. Some signal handlers are set up within an !_MSC_VER condition, i.e. omitted in MSVC builds but included in mingw builds. Previou

[Lldb-commits] [PATCH] D122486: [lldb] Fix building for mingw after changes to sigtstp_handler

mstorsjo added a comment. > Alternatively the ifdef condition could be changed from !_MSC_VER to !_WIN32 > - I'm unsure whether the other ones that are hooked up in mingw builds but > not in MSVC builds actually ever make a difference in mingw builds. On second thought, maybe it'd be best to ju

[Lldb-commits] [PATCH] D122486: [lldb] Fix building for mingw after changes to sigtstp_handler

mstorsjo updated this revision to Diff 418244. mstorsjo added a comment. Changed the existing ifdef around the signals that were omitted in the MSVC build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122486/new/ https://reviews.llvm.org/D122486

[Lldb-commits] [PATCH] D122486: [lldb] Fix building for mingw after changes to sigtstp_handler

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc13101cf945: [lldb] Fix building for mingw after changes to sigtstp_handler (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122486/new

[Lldb-commits] [PATCH] D122389: [lldb] Fix interpreting absolute Windows paths with forward slashes

This revision was automatically updated to reflect the committed changes. Closed by commit rGb548f5847235: [lldb] Fix interpreting absolute Windows paths with forward slashes (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12238

[Lldb-commits] [PATCH] D122710: [lldb-vscode] Avoid a -Wunused-but-set-variable warning. NFC.

mstorsjo created this revision. mstorsjo added reviewers: labath, clayborg. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D122710 Files: lldb/tools/lldb-vscode/lldb-vscode.cp

[Lldb-commits] [PATCH] D122710: [lldb-vscode] Avoid a -Wunused-but-set-variable warning. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa37cb5ece513: [lldb-vscode] Avoid a -Wunused-but-set-variable warning. NFC. (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122710/new/

[Lldb-commits] [PATCH] D123025: [lldb-vscode] Implement stderr/stdout on win32 and redirect lldb log to VSCode

mstorsjo added a reviewer: labath. mstorsjo added inline comments. Comment at: lldb/tools/lldb-vscode/OutputRedirector.cpp:12 +#else +#include +#include Minor style issue - I guess it'd be less of double negation, if we'd change the ifdef to `#if defined(_WIN3

[Lldb-commits] [PATCH] D123202: [lldb] Fix detecting warning options for GCC

mstorsjo created this revision. mstorsjo added a reviewer: labath. Herald added a subscriber: mgorny. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. If testing for a warning option like -Wno- with GCC, GCC won't print any diagnostic at all, l

[Lldb-commits] [PATCH] D123203: [lldb] Silence GCC warnings about missing returns after fully covered switches. NFC.

mstorsjo created this revision. mstorsjo added a reviewer: labath. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. This silences warnings like this: lldb/source/Core/DebuggerEvents.cpp: In member function ‘llvm::StringRef lldb_private::Diagn

[Lldb-commits] [PATCH] D123204: [lldb] Fix initialization of LazyBool/bool variables m_overwrite/m_overwrite_lazy. NFCI.

mstorsjo created this revision. mstorsjo added reviewers: jingham, labath. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. This silences a GCC warning after 1f7b58f2a50461493f083b2ed807b25e036286f6

[Lldb-commits] [PATCH] D123205: [lldb] Silence GCC/glibc warnings about ignoring the return value of write(). NFC.

mstorsjo created this revision. mstorsjo added a reviewer: labath. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. This matches how another similar warning is silenced in Host/posix/ProcessLauncherPosixFork.cpp. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D123206: [lldb] Silence warnings about unused static variables in RegisterInfos_arm64.h

mstorsjo created this revision. mstorsjo added a reviewer: labath. Herald added a subscriber: kristof.beyls. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. Move them to the only source file that included RegisterInfos_arm64.h that actually us

[Lldb-commits] [PATCH] D123202: [lldb] Fix detecting warning options for GCC

This revision was automatically updated to reflect the committed changes. Closed by commit rGe546bbfda0ab: [lldb] Fix detecting warning options for GCC (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123202/new/ https://reviews

[Lldb-commits] [PATCH] D123203: [lldb] Silence GCC warnings about missing returns after fully covered switches. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rGae2aa2d21b24: [lldb] Silence GCC warnings about missing returns after fully covered switches. (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D123205: [lldb] Silence GCC/glibc warnings about ignoring the return value of write(). NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e38824221db: [lldb] Silence GCC/glibc warnings about ignoring the return value of write(). (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D123254: [lldb] Disable GCC's -Wstringop-truncation warning. NFC.

mstorsjo created this revision. mstorsjo added reviewers: labath, JDevlieghere. Herald added subscribers: pengfei, mgorny. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. This warning gives false positives about lldb's correct use of strncpy t

[Lldb-commits] [PATCH] D123254: [lldb] Disable GCC's -Wstringop-truncation warning. NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5560b9e88423: [lldb] [CMake] Disable GCC's -Wstringop-truncation warning. NFC. (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D123204: [lldb] Fix initialization of LazyBool/bool variables m_overwrite/m_overwrite_lazy. NFCI.

mstorsjo added a comment. Ping @jingham Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123204/new/ https://reviews.llvm.org/D123204 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [PATCH] D123206: [lldb] Silence warnings about unused static variables in RegisterInfos_arm64.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG373d08adb445: [lldb] Silence warnings about unused static variables in RegisterInfos_arm64.h (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D122523: [lldb] Fix building standalone LLDB on Windows.

mstorsjo added a comment. @MehdiChinoune can you provide your preferred form of the git author line, `Real Name `? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122523/new/ https://reviews.llvm.org/D122523

[Lldb-commits] [PATCH] D122523: [lldb] Fix building standalone LLDB on Windows.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3031fa88f01e: [lldb] Fix building standalone LLDB on Windows. (authored by MehdiChinoune, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D123204: [lldb] Fix initialization of LazyBool/bool variables m_overwrite/m_overwrite_lazy. NFCI.

mstorsjo added a comment. Ping @jingham Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123204/new/ https://reviews.llvm.org/D123204 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [PATCH] D123204: [lldb] Fix initialization of LazyBool/bool variables m_overwrite/m_overwrite_lazy. NFCI.

mstorsjo added a comment. Ping @jingham Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123204/new/ https://reviews.llvm.org/D123204 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [PATCH] D123204: [lldb] Fix initialization of LazyBool/bool variables m_overwrite/m_overwrite_lazy. NFCI.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a84a8618439: [lldb] Fix initialization of LazyBool/bool variables… (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123204/new/ https:

[Lldb-commits] [PATCH] D126557: [lldb] Fix cross compiling on macOS

mstorsjo created this revision. mstorsjo added a reviewer: JDevlieghere. Herald added a subscriber: mgorny. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. When cross compiling, a separate nested cmake is spawned, for building host code genera

[Lldb-commits] [PATCH] D126557: [lldb] Fix cross compiling on macOS

This revision was automatically updated to reflect the committed changes. Closed by commit rG919107870739: [lldb] Fix cross compiling on macOS (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126557/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

mstorsjo added inline comments. Comment at: lldb/source/Plugins/SymbolVendor/PECOFF/SymbolVendorPECOFF.cpp:119 + }; + for (SectionType section_type : g_sections) { +if (SectionSP section_sp = I'm curious - this adds new logic (copied from SymbolVendorELF af

[Lldb-commits] [PATCH] D126657: [lldb] Fix loading DLL from some ramdisk on Windows

mstorsjo added a reviewer: labath. mstorsjo added a comment. The implementation looks reasonable to me (I didn't investigate alternative ways of doing it but trust the reasoning that this is the most reasonable way of finding the pathname of an open handle with this filesystem driver). ==

[Lldb-commits] [PATCH] D126657: [lldb] Fix loading DLL from some ramdisk on Windows

mstorsjo added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/DebuggerThread.cpp:427 + + auto view_deleter = [](void *pMem) { ::UnmapViewOfFile(pMem); }; + std::unique_ptr pMem( alvinhochun wrote: > mstorsjo wrote: > > Do you need a che

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

mstorsjo added inline comments. Comment at: lldb/source/Plugins/SymbolVendor/PECOFF/SymbolVendorPECOFF.cpp:119 + }; + for (SectionType section_type : g_sections) { +if (SectionSP section_sp = alvinhochun wrote: > mstorsjo wrote: > > I'm curious - this adds

[Lldb-commits] [PATCH] D127048: [lldb] Set COFF and PDB module env from default target triple

mstorsjo added a comment. In D127048#3559866 , @DavidSpickett wrote: >> This changes the PE/COFF and PDB plugins to set the module triple according >> to the default target triple used to build LLDB. > > I'm missing some context here but using triple us

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

mstorsjo added a comment. FWIW, most of the logic for how to deal with the gnu debuglink contents here is copied from the corresponding preexisting methods for ELF. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126367/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D127048: [lldb] Set COFF module ABI from default triple and make it an option

mstorsjo added a comment. In D127048#3565557 , @omjavaid wrote: > I am not fully familiar with PE/COFF but lets try to get this merged. For > starters I have a couple of questions here: > > 1. This rev apparently assumes x86_64 only but what about Arm/AA

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

mstorsjo added a comment. When testing this patch, I ran into crashes in the `SymbolFile/NativePDB/load-pdb.cpp` testcase. To fix it, I had to add a change like this: diff --git a/lldb/source/Plugins/SymbolVendor/PECOFF/SymbolVendorPECOFF.cpp b/lldb/source/Plugins/SymbolVendor/PECOFF/SymbolV

[Lldb-commits] [PATCH] D127234: [lldb] Add setting to override PE/COFF ABI by module name

mstorsjo added a reviewer: omjavaid. mstorsjo added a comment. (I guess this one might need some updates after D127048 is finalized?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127234/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8daf4a707ad: [lldb] Add gnu-debuglink support for Windows PE/COFF (authored by alvinhochun, committed by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D126367?vs=435214&id=435498#toc Re

[Lldb-commits] [PATCH] D127048: [lldb] Set COFF module ABI from default triple and make it an option

This revision was automatically updated to reflect the committed changes. Closed by commit rG25c8a061c573: [lldb] Set COFF module ABI from default triple and make it an option (authored by alvinhochun, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D126657: [lldb] Fix loading DLL from some ramdisk on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG87a2dba14ec8: [lldb] Fix loading DLL from some ramdisk on Windows (authored by alvinhochun, committed by mstorsjo). Herald added a subscriber: Michael137. Changed prior to commit: https://reviews.llvm.o

[Lldb-commits] [PATCH] D126657: [lldb] Fix loading DLL from some ramdisk on Windows

mstorsjo added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/DebuggerThread.cpp:445 + std::array drive = {L"_:"}; + for (auto it = drive_strings.cbegin(); *it != L'\0'; it += wcslen(it) + 1) { +// Copy the drive letter to the template string --

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

mstorsjo added a comment. In D127436#3574289 , @alvinhochun wrote: > Does this test look good: With a bunch of minor fixups, this testcase does work - I uploaded a working copy of it at https://martin.st/temp/command-target-create-resolve-exe.test. R

[Lldb-commits] [PATCH] D128226: [lldb] Remove an outdated comment. NFC.

mstorsjo created this revision. mstorsjo added reviewers: labath, DavidSpickett, omjavaid, alvinhochun. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. This comment became outdated in 053eb35651906e693906fad6c695fce11415ade7 (but was moved alo

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

mstorsjo created this revision. mstorsjo added reviewers: labath, DavidSpickett, omjavaid, alvinhochun. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. 25c8a061c5739677d2fc0af29a8cc9520207b923

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

mstorsjo added a comment. In D128268#3598967 , @DavidSpickett wrote: >> However, after this commit, if the object file is advertised with the >> different environment (either when built in a mingw environment, or if that >> setting is set), the fat bin

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

mstorsjo updated this revision to Diff 438733. mstorsjo added a comment. Added a comment to the testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128268/new/ https://reviews.llvm.org/D128268 Files: lldb/source/Utility/ArchSpec.cpp lldb/t

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

mstorsjo added a comment. In D128268#3601104 , @DavidSpickett wrote: > LGTM. I like the ifs the way I suggested but up to you, either way it's not > the easiest logic to parse. Oh, sorry, I forgot about that comment. Yes, that does indeed look even nic

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

mstorsjo updated this revision to Diff 438951. mstorsjo added a comment. Refactored the code to add the `both_windows` variable as suggested (which turned out much nicer, thanks!). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128268/new/ https://

[Lldb-commits] [PATCH] D128226: [lldb] Remove an outdated comment. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9846a1f2d472: [lldb] Remove an outdated comment. NFC. (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128226/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a64dd5b0614: [lldb] Fix reading i686-windows executables with GNU environment (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128268/n

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bae95605753: [lldb] Resolve exe location for `target create` (authored by alvinhochun, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D128201: [lldb][windows] Fix crash on getting nested exception

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d123783957e: [lldb][windows] Fix crash on getting nested exception (authored by alvinhochun, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D127234: [lldb] Add setting to override PE/COFF ABI by module name

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c867898c7be: [lldb] Add setting to override PE/COFF ABI by module name (authored by alvinhochun, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

mstorsjo added a comment. In D127436#3602224 , @stella.stamenova wrote: > This broke the Windows LLDB bot: > > https://lab.llvm.org/buildbot/#/builders/83/builds/20295/steps/7/logs/stdio Yep, noted. It worked for me in my MSVC build configuration - I'll

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

mstorsjo added a comment. In D127436#3602224 , @stella.stamenova wrote: > This broke the Windows LLDB bot: > > https://lab.llvm.org/buildbot/#/builders/83/builds/20295/steps/7/logs/stdio The second fix attempt, in https://github.com/llvm/llvm-project/c

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

mstorsjo added subscribers: stella.stamenova, mstorsjo. mstorsjo added a comment. I think this might have broken a bunch of testcases on the lldb-x64-windows-ninja buildbot too, e.g. https://lab.llvm.org/buildbot/#/builders/83/builds/20304 (CC @stella.stamenova) Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

mstorsjo added a comment. In D128268#3603931 , @labath wrote: >> As a separate path forward, one could also consider to stop returning >> two architecture specs from ObjectFilePECOFF::GetModuleSpecifications >> for i386 files. > > I think that would be mu

[Lldb-commits] [PATCH] D128410: [lldb] Add a testcase for nested exceptions on Windows

mstorsjo created this revision. mstorsjo added reviewers: labath, alvinhochun, DavidSpickett. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. This adds a testcase for 4d123783957e547009e55346bf3a8ae43a88fa14

  1   2   3   4   5   >