mstorsjo created this revision. mstorsjo added a reviewer: labath. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB.
Some signal handlers are set up within an !_MSC_VER condition, i.e. omitted in MSVC builds but included in mingw builds. Previously sigtstp_handler was defined in all builds, but since 4bcadd66864bf4af929ac8753a51d7ad408cdef0 <https://reviews.llvm.org/rG4bcadd66864bf4af929ac8753a51d7ad408cdef0> / D120320 <https://reviews.llvm.org/D120320> it's only defined non platforms other than Windows. This applies a matching ifdef around the usage of sigtstp_handler. Alternatively the ifdef condition could be changed from !_MSC_VER to !_WIN32 - I'm unsure whether the other ones that are hooked up in mingw builds but not in MSVC builds actually ever make a difference in mingw builds. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D122486 Files: lldb/tools/driver/Driver.cpp Index: lldb/tools/driver/Driver.cpp =================================================================== --- lldb/tools/driver/Driver.cpp +++ lldb/tools/driver/Driver.cpp @@ -832,7 +832,9 @@ #if !defined(_MSC_VER) signal(SIGPIPE, SIG_IGN); signal(SIGWINCH, sigwinch_handler); +#if !defined(_WIN32) signal(SIGTSTP, sigtstp_handler); +#endif #endif int exit_code = 0;
Index: lldb/tools/driver/Driver.cpp =================================================================== --- lldb/tools/driver/Driver.cpp +++ lldb/tools/driver/Driver.cpp @@ -832,7 +832,9 @@ #if !defined(_MSC_VER) signal(SIGPIPE, SIG_IGN); signal(SIGWINCH, sigwinch_handler); +#if !defined(_WIN32) signal(SIGTSTP, sigtstp_handler); +#endif #endif int exit_code = 0;
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
