mstorsjo added inline comments.

================
Comment at: lldb/source/Plugins/SymbolVendor/PECOFF/SymbolVendorPECOFF.cpp:119
+  };
+  for (SectionType section_type : g_sections) {
+    if (SectionSP section_sp =
----------------
I'm curious - this adds new logic (copied from SymbolVendorELF afaik?) for 
iterating over sections and finding the ones that contain the dwarf debug info. 
Prior to this change, finding debug info within the executable itself has 
worked just fine.

What codepath and where has handled that? Has it fallen back on SymbolVendorELF 
so far?

(If that used to work, why is a specific plugin for PECOFF needed at this point 
for debuglink?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126367/new/

https://reviews.llvm.org/D126367

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to