mstorsjo added a comment. In D131159#3711024 <https://reviews.llvm.org/D131159#3711024>, @mstorsjo wrote:
> In D131159#3709965 <https://reviews.llvm.org/D131159#3709965>, @labath wrote: > >>> Can @alvinhochun take the patch for a spin? I think you've got more >>> realistic usecases of lldb to try it out in. (Do you want me to make a >>> build with the patch for you to try out?) @labath What's the best way to >>> exercise this code in actual use of lldb? >> >> I would appreciate that. I have tried to build it and run the test suite, >> but I didn't have a clean baseline, so I can't really say whether it works >> for everything. The main user of this code is the gdb-remote communication >> code, so debugging something via lldb-server (or running the lldb-server >> test suite) should be a good indicator of whether it works. > > I presume this is covered by running `ninja check-lldb`, or should I flip the > switch to prefer lldb-server on Windows before doing that? (I guess I can do > both.) I've got an environment where `check-lldb` mostly passes, I can check > that it doesn't regress it. I tested out this patch with running `ninja check-lldb`. Out of the box, this patch doesn't regress anything - the tests still pass. (In my environment, there's a bunch of occasional stray failures already before, but by rerunning the tests a couple times, I can get a clean run.) If I edit `ShouldUseLLDBServer()` in lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp to always return true (before applying this patch), most tests still pass, but I have 11 tests that hang so that I end up having to kill lldb-server. With this patch on top, I still get the same set of 11 hanging tests, so I think that means that this patch doesn't regress anything with respect to that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131159/new/ https://reviews.llvm.org/D131159 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
