mstorsjo added a comment.

> Alternatively the ifdef condition could be changed from !_MSC_VER to !_WIN32 
> - I'm unsure whether the other ones that are hooked up in mingw builds but 
> not in MSVC builds actually ever make a difference in mingw builds.

On second thought, maybe it'd be best to just go down this route, to reduce 
unnecessary differences between the MSVC and mingw builds. If the (more 
officially supported) MSVC build can do without these signals, the mingw build 
should too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122486/new/

https://reviews.llvm.org/D122486

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to