[Lldb-commits] [PATCH] D47579: dotest: make inline tests compatible with -f

JDevlieghere added a comment. If I correctly understand this change, this might make it possible to apply the `add_test_categories` decorator to an inline test. We had issues with this when introducing the swiftpr category because the methods were part of the inline test class. From the descrip

[Lldb-commits] [PATCH] D47579: dotest: make inline tests compatible with -f

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM > Can you try inserting something like this instead of the > `ApplyDecoratorsToFunction` line and see if your problems go away? > > @wraps(InlineTest._test) > def test_fu

[Lldb-commits] [PATCH] D47539: [Platform] Accept arbitrary kext variants

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL334205: [Platform] Accept arbitrary kext variants (authored by JDevlieghere, committed by ). Herald added a subscriber: ll

[Lldb-commits] [PATCH] D48084: [FileSpec] Delegate common operations to llvm::sys::path

JDevlieghere created this revision. JDevlieghere added reviewers: labath, zturner, clayborg, davide. Herald added subscribers: arichardson, emaste. Herald added a reviewer: espindola. With the recent changes in FileSpec to use LLVM's path style, it is possible to delegate a bunch of common path op

[Lldb-commits] [PATCH] D48084: [FileSpec] Delegate common operations to llvm::sys::path

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: source/Utility/FileSpec.cpp:244-246 + // Only update style if explicitly requested. + if (style) +m_style = (*style == Style::native) ? GetNativeStyle() : *style;

[Lldb-commits] [PATCH] D48084: [FileSpec] Delegate common operations to llvm::sys::path

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: source/Utility/FileSpec.cpp:244-246 + // Only update style if explicitly requested. + if (style) +m_style = (*style == Style::native) ? GetNativeStyle() : *style;

[Lldb-commits] [PATCH] D48114: Add dataformatter for NSDecimalNumber

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jingham, jasonmolenda. This patch adds a data formatter for NSDecimalNumber. The latter is a Foundation object used for representing and performing arithmetic on base-10 numbers that bridges to Decimal. Repository: rL

[Lldb-commits] [PATCH] D48084: [FileSpec] Delegate common operations to llvm::sys::path

This revision was automatically updated to reflect the committed changes. JDevlieghere marked 11 inline comments as done. Closed by commit rL334615: [FileSpec] Delegate common operations to llvm::sys::path (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.

[Lldb-commits] [PATCH] D48084: [FileSpec] Delegate common operations to llvm::sys::path

JDevlieghere added inline comments. Comment at: source/Utility/FileSpec.cpp:244-246 + // Only update style if explicitly requested. + if (style) +m_style = (*style == Style::native) ? GetNativeStyle() : *style; labath wrote: > JDevlieghere wrote: > > labath

[Lldb-commits] [PATCH] D48114: Add dataformatter for NSDecimalNumber

This revision was automatically updated to reflect the committed changes. Closed by commit rL334638: [ObjC] Add dataformatter for NSDecimalNumber (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D48114?vs=151096&id=151217#toc Repository: rL LLVM h

[Lldb-commits] [PATCH] D48302: Search for kext variants is searching from parent directory when it should not be

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks Jason, good catch! Repository: rL LLVM https://reviews.llvm.org/D48302 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D48450: Support CFDictionary

JDevlieghere created this revision. JDevlieghere added a reviewer: davide. Add data formatter for CFDictionary. Repository: rL LLVM https://reviews.llvm.org/D48450 Files: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjC.py packages

[Lldb-commits] [PATCH] D48450: [DataFormatter] Add CFDictionary data formatter

JDevlieghere updated this revision to Diff 152354. JDevlieghere added a comment. - Also test CFDictionaryRef https://reviews.llvm.org/D48450 Files: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjC.py packages/Python/lldbsuite/test/fun

[Lldb-commits] [PATCH] D48450: [DataFormatter] Add CFDictionary data formatter

This revision was automatically updated to reflect the committed changes. Closed by commit rL335271: [DataFormatter] Add CFDictionary data formatter (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D48450?vs=152354&id=152359#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D48596: [SymbolFile] Implement GetCompleteObjCClass for .debug_names

JDevlieghere created this revision. JDevlieghere added reviewers: labath, aprantl, clayborg. When running the test suite with .debug_names a bunch of tests were failing. Part of that is solved by implementing the missing GetCompleteObjCClass in DebugNamesDWARFIndex. Repository: rL LLVM http

[Lldb-commits] [PATCH] D48596: [SymbolFile] Implement GetCompleteObjCClass for .debug_names

JDevlieghere added a comment. In https://reviews.llvm.org/D48596#1143666, @clayborg wrote: > The function is looking for the complete objective C type. The code needs to > be modified to return the complete type only if one is found, else just one > of the other incomplete versions is needed, n

[Lldb-commits] [PATCH] D48596: [SymbolFile] Implement GetCompleteObjCClass for .debug_names

JDevlieghere added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp:157 +if (entry.tag() != DW_TAG_structure_type && +entry.tag() != DW_TAG_class_type) + continue; aprantl wrote: > Wait.. we accept both struct

[Lldb-commits] [PATCH] D48596: [SymbolFile] Implement GetCompleteObjCClass for .debug_names

JDevlieghere updated this revision to Diff 152912. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. - Feedback Greg https://reviews.llvm.org/D48596 Files: source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp source/Plugins/SymbolFile/DWARF/DebugNamesDWARFInde

[Lldb-commits] [PATCH] D48596: [SymbolFile] Implement GetCompleteObjCClass for .debug_names

JDevlieghere updated this revision to Diff 153027. JDevlieghere added a comment. - Add test case for debug_names variant. https://reviews.llvm.org/D48596 Files: packages/Python/lldbsuite/test/lang/objc/forward-decl/TestForwardDecl.py source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp

[Lldb-commits] [PATCH] D48596: [SymbolFile] Implement GetCompleteObjCClass for .debug_names

This revision was automatically updated to reflect the committed changes. Closed by commit rL335776: [SymbolFile] Implement GetCompleteObjCClass for .debug_names (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D48596?vs=153027&id=153161#toc Reposito

[Lldb-commits] [PATCH] D48782: LLDB Test Suite: Provide an Option to run all tests with Dwarf Package Format (DWP).

JDevlieghere added a comment. In https://reviews.llvm.org/D48782#1148376, @labath wrote: > Then, for the integration test part, I propose to come up with a more generic > way to specify the kind of debug info to generate. I don't have this fully > thought out yet, but I have been thinking of so

[Lldb-commits] [PATCH] D49110: [testsuite] Implement a category to skip libstdcxx tests

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D49110 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

This revision was automatically updated to reflect the committed changes. Closed by commit rL336988: Convert a location information from PDB to a DWARF expression (authored by JDevlieghere, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

JDevlieghere added a comment. Looks good to me, modulo the inline test (or the current comments addressed). Thanks Shafik! https://reviews.llvm.org/D49271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [PATCH] D49377: Move pretty stack trace printer into driver.

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, labath, zturner. Herald added a reviewer: jfb. We used to have a pretty stack trace printer in SystemInitializerCommon. This was disabled on Apple because we didn't want the library to be setting signal handlers, as this

[Lldb-commits] [PATCH] D49377: Move pretty stack trace printer into driver.

JDevlieghere updated this revision to Diff 155684. JDevlieghere added a comment. Herald added a subscriber: ki.stfu. I've added it to the tools that made sense to me. Let me know if I missed something obvious. https://reviews.llvm.org/D49377 Files: source/Initialization/SystemInitializerComm

[Lldb-commits] [PATCH] D49377: Move pretty stack trace printer into driver.

This revision was automatically updated to reflect the committed changes. Closed by commit rL337261: Move pretty stack trace printer into driver. (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D49377?vs=155684&id=155834#toc Repository: rL LLVM h

[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM, Thanks! https://reviews.llvm.org/D49271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49612: Use LLVM's new ItaniumPartialDemangler in LLDB

JDevlieghere added inline comments. Comment at: source/Core/Mangled.cpp:30 #include "llvm/ADT/StringRef.h"// for StringRef +#include "llvm/Demangle/Demangle.h" While you're here I'd remove these redundant comments so this block looks more consistent. =

[Lldb-commits] [PATCH] D49612: Use LLVM's new ItaniumPartialDemangler in LLDB

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Given these numbers I think we can land this patch as is and figure out the IDP stuff on the mailing list and/or a future patch. LGTM. Thanks Stefan! https://reviews.llvm.org/D496

[Lldb-commits] [PATCH] D49909: Unit test for Symtab::InitNameIndexes

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I agree with Pavel, but I also don't mind having this test in the meantime. LGTM if you add a FIXME with the direction we want to go. https://reviews.llvm.org/D49909 __

[Lldb-commits] [PATCH] D50159: Add byte counting mechanism to LLDB's Stream class.

JDevlieghere added inline comments. Comment at: include/lldb/Utility/Stream.h:542 int m_indent_level; ///< Indention level. + std::size_t m_bytes_written = 0; /// The bytes this stream has written so far. I believe you need the `<` for Doxygen to associate

[Lldb-commits] [PATCH] D50365: Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

JDevlieghere added a comment. This looks really cool :-) I started doing a superficial pass but I have a hard time following what everything is doing. I think it could really help if you added more structure/abstraction. Can you also run clang-format over the new files? Comm

[Lldb-commits] [PATCH] D50587: Straight forward FastDemangle replacement in SubsPrimitiveParmItanium

JDevlieghere added inline comments. Comment at: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:281 llvm::StringRef replace) { - Log *log = GetLogIfAllCategoriesSet(LIBLLDB_LOG_LANGUAGE); - - const size_t max_len = - man

[Lldb-commits] [PATCH] D50587: Straight forward FastDemangle replacement in SubsPrimitiveParmItanium

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Looks good to me. https://reviews.llvm.org/D50587 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi

[Lldb-commits] [PATCH] D51587: [Symtab][NFC] Added llvm_unreachable to supress compiler warning

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Looks reasonable. Did you run into this or is it just an improvement as you came across the code? Repository: rLLDB LLDB https://reviews.llvm.org/D51587

[Lldb-commits] [PATCH] D51587: [Symtab][NFC] Added llvm_unreachable to supress compiler warning

JDevlieghere added a comment. Alright, thanks for the fix! Repository: rLLDB LLDB https://reviews.llvm.org/D51587 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D51591: [PseudoTerminal][NFC] Use llvm errno helpers

JDevlieghere added a comment. Any chance we could wrap this in a helper function? https://reviews.llvm.org/D51591 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D51591: [PseudoTerminal][NFC] Use llvm errno helpers

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM, thx! https://reviews.llvm.org/D51591 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [PATCH] D51604: Terminate debugger if an assert was hit

JDevlieghere added inline comments. Comment at: source/Utility/LLDBAssert.cpp:23 if (expression) ; else { I guess while we're at it we can turn this into an early return and use LLVM_LIKELY? ``` if (LLVM_LIKELY(expression)) return; ``` Reposito

[Lldb-commits] [PATCH] D51602: Print the correct error when our DynamicCheckerFunctions fail to install

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rLLDB LLDB https://reviews.llvm.org/D51602 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D51604: Terminate debugger if an assert was hit

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D51604 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org

[Lldb-commits] [PATCH] D51730: [DWARFExpression] Read literars as unsigned values.

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jingham, clayborg. JDevlieghere added a project: LLDB. After landing https://reviews.llvm.org/rL341457, we started seeing a failure on the swift-lldb bots. The change was correct and pretty straightforward, a `DW_OP_const

[Lldb-commits] [PATCH] D51730: [DWARFExpression] Read literars as unsigned values.

JDevlieghere updated this revision to Diff 164650. JDevlieghere added a comment. Added a test case. I really didn't know where to put it so I decided on something generic. Hope that's fine. https://reviews.llvm.org/D51730 Files: packages/Python/lldbsuite/test/lang/c/local_variables/Makefile

[Lldb-commits] [PATCH] D51859: [NFC] Turn "load dependent files" boolean is enum

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, jasonmolenda, LLDB. Herald added subscribers: abidh, emaste. This is an NFC commit to refactor the "load dependent files" parameter from a boolean to an enum value. We want to be able to specify a default, in which case w

[Lldb-commits] [PATCH] D51934: [target] Change target create's behavior wrt loading dependent files.

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, jingham, LLDB. JDevlieghere added a dependency: D51859: [NFC] Turn "load dependent files" boolean into an enum . JDevlieghere edited the summary of this revision. When creating a target, lldb loads all dependent files

[Lldb-commits] [PATCH] D50809: Remove byte counting from SourceManager

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Maybe mention that this is NFC in the commit msg? Otherwise this LGTM. Repository: rLLDB LLDB https://reviews.llvm.org/D50809 ___

[Lldb-commits] [PATCH] D51175: Add support for descriptions with command completions.

JDevlieghere added a comment. I don't know the completion API well enough to accept, but this looks like a nice improvement! Comment at: source/Utility/CompletionRequest.cpp:79 + // Add the completion if we haven't seen the same value before. + if (m_added_values.insert(r.Ge

[Lldb-commits] [PATCH] D50681: Remove manual byte counting from internal Stream methods.

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. Neat, LGTM! https://reviews.llvm.org/D50681 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.l

[Lldb-commits] [PATCH] D51934: [target] Change target create's behavior wrt loading dependent files.

JDevlieghere updated this revision to Diff 165047. JDevlieghere added a comment. I totally agree; I've left the argument name unchanged and made the argument optional. I had to change the semantics slightly (because of the negation in the argument name) but otherwise things will continue working

[Lldb-commits] [PATCH] D51934: [target] Change target create's behavior wrt loading dependent files.

JDevlieghere updated this revision to Diff 165094. JDevlieghere added a comment. - Document default behavior. https://reviews.llvm.org/D51934 Files: packages/Python/lldbsuite/test/functionalities/target_create_deps/Makefile packages/Python/lldbsuite/test/functionalities/target_create_deps/

[Lldb-commits] [PATCH] D51730: [DWARFExpression] Read literars as unsigned values.

JDevlieghere added a comment. ping (I'd like to land this so I can un-revert the `DW_OP_constu` normalization for Swift) https://reviews.llvm.org/D51730 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [PATCH] D51730: [DWARFExpression] Read literars as unsigned values.

This revision was automatically updated to reflect the committed changes. Closed by commit rL342142: [DWARFExpression] Read literars as unsigned values. (authored by JDevlieghere, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51730?v

[Lldb-commits] [PATCH] D52103: Add descriptions to completed expressions

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rLLDB LLDB https://reviews.llvm.org/D52103 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D51934: [target] Change target create's behavior wrt loading dependent files.

JDevlieghere updated this revision to Diff 165727. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. - Address Shafik's feedback https://reviews.llvm.org/D51934 Files: packages/Python/lldbsuite/test/functionalities/target_create_deps/Makefile packages/Python/lldb

[Lldb-commits] [PATCH] D51934: [target] Change target create's behavior wrt loading dependent files.

JDevlieghere added inline comments. Comment at: source/Commands/CommandObjectTarget.cpp:153 +static OptionDefinition g_dependents_options[1] = { +{LLDB_OPT_SET_1, false, "no-dependents", 'd', + OptionParser::eOptionalArgument, nullptr, g_dependents_enumaration, 0, ---

[Lldb-commits] [PATCH] D50751: Allow use of self.filecheck in LLDB tests (c.f self.expect)

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks Vedant, this looks very useful! https://reviews.llvm.org/D50751 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [PATCH] D51934: [target] Change target create's behavior wrt loading dependent files.

JDevlieghere added a comment. ping https://reviews.llvm.org/D51934 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D51934: [target] Change target create's behavior wrt loading dependent files.

This revision was automatically updated to reflect the committed changes. Closed by commit rL342634: [target] Change target create's behavior wrt loading dependent files. (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D51934?vs=165727&id=166244#toc

[Lldb-commits] [PATCH] D51859: [NFC] Turn "load dependent files" boolean into an enum

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL342633: [NFC] Turn "load dependent files" boolean into an enum (authored by JDevlieghere, committed by ). Herald added a s

[Lldb-commits] [PATCH] D51934: [target] Change target create's behavior wrt loading dependent files.

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB342634: [target] Change target create's behavior wrt loading dependent files. (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D51934?vs=166244&id=166245#t

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

JDevlieghere added inline comments. Comment at: packages/Python/lldbsuite/test/lldbinline.py:96-98 +return "-N dwarf %s" % (testdir) else: +return "-N dsym %s" % (testdir) labath wrote: > aprantl wrote: > > labath wrote: > > > xia

[Lldb-commits] [PATCH] D43024: [test] Enable test category for inline tests.

JDevlieghere created this revision. JDevlieghere added reviewers: vsk, davide, labath. Herald added a subscriber: llvm-commits. Inlined tests have a test function that is actually an instance method, which requires a slightly different approach when it comes to setting the category attribute. The

[Lldb-commits] [PATCH] D43024: [test] Enable test category for inline tests.

JDevlieghere closed this revision. JDevlieghere added a comment. Forgot to add the differential to the commit message. Landed in https://reviews.llvm.org/rL324488 Repository: rL LLVM https://reviews.llvm.org/D43024 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D43024: [test] Enable test category for inline tests.

JDevlieghere updated this revision to Diff 133220. JDevlieghere added a comment. The change in r324488 dropped the existing category attribute in for instance methods. This patch corrects that. https://reviews.llvm.org/D43024 Files: lldb/packages/Python/lldbsuite/test/decorators.py Index: l

[Lldb-commits] [PATCH] D43024: [test] Enable test category for inline tests.

JDevlieghere closed this revision. JDevlieghere added a comment. Jup. Sorry for making it so confusing. Because Pavel's reply was here it seemed sensible to update the diff. Landed in https://reviews.llvm.org/rL324492 https://reviews.llvm.org/D43024 _

[Lldb-commits] [PATCH] D43471: Handle typeof() expressions

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jingham, davide, labath. Before this patch, LLDB was not able to evaluate expressions that resulted in a value with a typeof-type. (lldb) p int i; __typeof__(i) j = 1; j (typeof (i)) $0 = This fixes that. The type is

[Lldb-commits] [PATCH] D43471: Handle typeof() expressions

JDevlieghere updated this revision to Diff 134935. JDevlieghere added a comment. Formatting https://reviews.llvm.org/D43471 Files: packages/Python/lldbsuite/test/expression_command/test/TestExprs.py source/Symbol/ClangASTContext.cpp Index: source/Symbol/ClangASTContext.cpp

[Lldb-commits] [PATCH] D43471: Handle typeof() expressions

JDevlieghere updated this revision to Diff 134942. JDevlieghere added a comment. Change to lit test https://reviews.llvm.org/D43471 Files: lit/Expr/TestTypeOfExpr.test source/Symbol/ClangASTContext.cpp Index: source/Symbol/ClangASTContext.cpp ===

[Lldb-commits] [PATCH] D43471: Handle typeof() expressions

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: source/Symbol/ClangASTContext.cpp:5264 - case clang::Type::TypeOfExpr: - case clang::Type::TypeOf: case clang::Type::Decltype: case clang::Type::TemplateSpecialization: --

[Lldb-commits] [PATCH] D43471: Handle typeof() expressions

JDevlieghere updated this revision to Diff 134954. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Do this for decltype too https://reviews.llvm.org/D43471 Files: lit/Expr/TestTypeOfDeclTypeExpr.test source/Symbol/ClangASTContext.cpp Index: source/Symbol/ClangA

[Lldb-commits] [PATCH] D43471: Handle typeof() expressions

JDevlieghere updated this revision to Diff 134955. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Make sure the lit test actually checks the lldb output instead of the # CHECK lines. Without the check-next, CHECK matches the # CHECK lines, as they are printed by ll

[Lldb-commits] [PATCH] D43471: Handle typeof() expressions

JDevlieghere added a comment. In https://reviews.llvm.org/D43471#1012484, @jingham wrote: > The code part of this looks fine. I had a few quibbles with the test, see > inline. Jim, it looks like you're commenting on an older version of the diff. I've since switched to checking this with lit.

[Lldb-commits] [PATCH] D43471: Handle typeof() expressions

JDevlieghere updated this revision to Diff 134965. JDevlieghere added a comment. Thanks for the review Jim! I've updated the test accordingly. https://reviews.llvm.org/D43471 Files: lit/Expr/TestTypeOfDeclTypeExpr.test source/Symbol/ClangASTContext.cpp Index: source/Symbol/ClangASTContext.

[Lldb-commits] [PATCH] D43471: Handle typeof() expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rL325568: Handle typeof() expressions (authored by JDevlieghere, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43471?vs=134965&id=135025#toc

[Lldb-commits] [PATCH] D43596: Replace HashStringUsingDJB with llvm::djbHash

JDevlieghere added a reviewer: JDevlieghere. JDevlieghere added a comment. We probably want to have a test to ensure this stays in sync with the hashes we generate for object files and dSYMs? https://reviews.llvm.org/D43596 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D43596: Replace HashStringUsingDJB with llvm::djbHash

JDevlieghere added a comment. In https://reviews.llvm.org/D43596#1015848, @clayborg wrote: > No need to add additional dSYM tests, because all dSYM tests will fail if the > hashing isn't correct. Maybe I misunderstand, but https://reviews.llvm.org/D42740 suggested that this never worked (or m

[Lldb-commits] [PATCH] D43662: [Utility] Simplify and generalize the CleanUp helper, NFC

JDevlieghere added a comment. I agree with Pavel, I prefer having a slightly more complex constructor if we can make the call sites simpler for the simple common cases, especially since we don't lose any generality by doing so. It's also not an uncommon pattern in C++, e.g. `std::async` does so

[Lldb-commits] [PATCH] D43912: [Symbol] Add InvalidType, a force-checked recoverable error

JDevlieghere added inline comments. Comment at: include/lldb/Symbol/CompilerType.h:446 +/// A force-checked error used to describe type construction failures. +class InvalidType : public llvm::ErrorInfo { +public: I think this should be called `InvalidTypeError`?

[Lldb-commits] [PATCH] D44139: WIP: Update selected thread after loading mach core

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, jasonmolenda, labath. Herald added a subscriber: llvm-commits. The OS plugins might have updated the thread list after a core file has been loaded. The physical thread in the core file may no longer be the one that should b

[Lldb-commits] [PATCH] D44139: WIP: Update selected thread after loading mach core

JDevlieghere planned changes to this revision. JDevlieghere added a comment. Alright, sounds good. Thank you both for the help! Repository: rL LLVM https://reviews.llvm.org/D44139 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://l

[Lldb-commits] [PATCH] D44139: Update selected thread after loading mach core

JDevlieghere updated this revision to Diff 137762. JDevlieghere retitled this revision from "WIP: Update selected thread after loading mach core" to "Update selected thread after loading mach core". JDevlieghere edited the summary of this revision. JDevlieghere added a comment. - Added testcase.

[Lldb-commits] [PATCH] D44139: Update selected thread after loading mach core

JDevlieghere updated this revision to Diff 137993. JDevlieghere added a comment. Thanks for the review @labath! https://reviews.llvm.org/D44139 Files: packages/Python/lldbsuite/test/functionalities/postmortem/mach-core/TestMachCore.py packages/Python/lldbsuite/test/functionalities/postmor

[Lldb-commits] [PATCH] D44139: Update selected thread after loading mach core

This revision was automatically updated to reflect the committed changes. Closed by commit rL327501: Update selected thread after loading mach core (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D44139?vs=137993&id=138331#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D44139: Update selected thread after loading mach core

JDevlieghere added a comment. In https://reviews.llvm.org/D44139#1036521, @jasonmolenda wrote: > (or rather, not "conflict with the OperatingSystemPlugIn stop reason" -- but > would make it confusing to users. I think it might be best to remove > ThreadMachCore::CalculateStopInfo.) Sounds re

[Lldb-commits] [PATCH] D44473: [dotest] Make llvm-dotest a custom target

JDevlieghere created this revision. JDevlieghere added reviewers: davide, labath, zturner. Herald added subscribers: llvm-commits, mgorny. This makes llvm-dotest a custom target so you can run `ninja llvm-dotest` to rebuild whatever is necessary before rerunning the tests. Repository: rL LLVM

[Lldb-commits] [PATCH] D44473: [dotest] Make llvm-dotest a custom target

JDevlieghere updated this revision to Diff 138370. JDevlieghere added a comment. Yeah, that's more sensible indeed. I must have had `llvm-lit` in mind and never gave it a second thought. Repository: rL LLVM https://reviews.llvm.org/D44473 Files: test/CMakeLists.txt test/lldb-dotest.in

[Lldb-commits] [PATCH] D44473: [dotest] Rename llvm-dotest -> lldb-dotest and make it a custom target

This revision was automatically updated to reflect the committed changes. Closed by commit rL327519: [dotest] Rename llvm-dotest -> lldb-dotest and make it a custom target (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D44473?vs=138370&id=138372#toc

[Lldb-commits] [PATCH] D44728: [dotest] Use subprocess.call to forward arguments in wrapper

JDevlieghere updated this revision to Diff 139270. JDevlieghere added a comment. Re-add accidentally removed comment. https://reviews.llvm.org/D44728 Files: test/CMakeLists.txt test/lldb-dotest.in Index: test/lldb-dotest.in =

[Lldb-commits] [PATCH] D44728: [dotest] Use subprocess.call to forward arguments in wrapper

JDevlieghere created this revision. JDevlieghere added reviewers: labath, vsk. Herald added subscribers: llvm-commits, mgorny. As suggested by Pavel on lldb-commits. Originally I picked os.system because it was so much more simple than the subprocess module, but that no longer holds true after y

[Lldb-commits] [PATCH] D44728: [dotest] Use subprocess.call to forward arguments in wrapper

JDevlieghere marked an inline comment as done. JDevlieghere added a comment. In https://reviews.llvm.org/D44728#1044255, @labath wrote: > Thank you. This looks good, assuming that the LLDB_DOTEST_ARGS_STR thingy is > working as intended. Good catch, the variable was still available from the c

[Lldb-commits] [PATCH] D44728: [dotest] Use subprocess.call to forward arguments in wrapper

This revision was automatically updated to reflect the committed changes. Closed by commit rL328089: [dotest] Use subprocess.call to forward arguments in wrapper (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D44728?vs=139270&id=139274#toc Reposito

[Lldb-commits] [PATCH] D45215: RFC/WIP: Have lit run the lldb test suite

JDevlieghere created this revision. JDevlieghere added reviewers: davide, labath, aprantl, vsk, jasonmolenda, jingham, friss. Herald added a subscriber: llvm-commits. With `lldb-dotest` checked in, this is the next step in allowing us to run the LLDB test suite with lit. I've converted a single

[Lldb-commits] [PATCH] D45215: RFC/WIP: Have lit run the lldb test suite

JDevlieghere added a comment. In https://reviews.llvm.org/D45215#1055820, @davide wrote: > Can you add another test or two? It's a little complicated to see what's > going on here, but from your description, it makes sense. > I'm not particularly worried right now to distinguish between `UNSUPP

[Lldb-commits] [PATCH] D45215: RFC/WIP: Have lit run the lldb test suite

JDevlieghere added a comment. In https://reviews.llvm.org/D45215#1055832, @aprantl wrote: > So this is basically replacing the parallel test-driver functionality of > dotest with lit and dotest is only used to invoke one test at a time. This > way we (as the LLVM project) can avoid maintaining

[Lldb-commits] [PATCH] D45215: RFC/WIP: Have lit run the lldb test suite

JDevlieghere updated this revision to Diff 140826. JDevlieghere added a comment. - Add few more examples as per Davide's request. - Add run line to the python file. Because the `.py` suffix is currently specified in the root of the `TestSuite` directory, we end up with a bunch of unresolved test

[Lldb-commits] [PATCH] D45215: RFC/WIP: Have lit run the lldb test suite

JDevlieghere added a comment. In https://reviews.llvm.org/D45215#1056043, @labath wrote: > I don't think this is going in a good direction TBH. > > You are building another layer on top of everything, whereas I think we > should be cutting layers out. Besides the issues already pointed out (not

[Lldb-commits] [PATCH] D45215: RFC/WIP: Have lit run the lldb test suite

JDevlieghere added a comment. Alright, I'm convinced this is the way to go. - For (1) I'll see if I can get some inspiration from the visit logic in dotest.py. I guess the functionality is similar. I agree on doing this in a separate tool, especially if we want to remove functionality from dote

[Lldb-commits] [PATCH] D45215: RFC/WIP: Have lit run the lldb test suite

JDevlieghere added a comment. In https://reviews.llvm.org/D45215#1056917, @zturner wrote: > I haven’t had time to look at this in detail yet, but when I originally had > this idea I thought we would use lit’s discovery mechanism to find all .py > files, and then invoke them using dotest.py in s

[Lldb-commits] [PATCH] D45332: [LIT] Add new LLDB test format

JDevlieghere created this revision. JDevlieghere added reviewers: zturner, labath, davide, aprantl. Herald added a subscriber: delcypher. JDevlieghere added a comment. As discussed in https://reviews.llvm.org/D45215 This adds a new test format to lit which will be used for LLDB. (If it's possib

<    1   2   3   4   5   6   7   8   9   10   >