JDevlieghere added a comment. I don't know the completion API well enough to accept, but this looks like a nice improvement!
================ Comment at: source/Utility/CompletionRequest.cpp:79 + // Add the completion if we haven't seen the same value before. + if (m_added_values.insert(r.GetUniqueKey()).second) + m_results.push_back(r); ---------------- Do you think there's any value in in checking the description? For example, if the description was empty for the existing value but a description is provided for the duplicate? Repository: rLLDB LLDB https://reviews.llvm.org/D51175 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
