Re: [Lldb-commits] [PATCH] D50365: Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

> On Sep 21, 2018, at 10:31 AM, Leonard Mosescu wrote: > > The solution I would love to see is to have the initialize packet return > something via the DAP that says "I have a command line interpreter, please > send a packet with a file handle (slave path to slave side of pseudo terminal > m

Re: [Lldb-commits] [PATCH] D50365: Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

> On Sep 21, 2018, at 1:20 PM, Leonard Mosescu wrote: > > Great. Do you think that having an abstracted stream I/O tunneled through DAP > would lose anything compared to the direct file handle? I can see a few > problems using a native platform file handle: > > 1. It's specific to the platf

Re: [Lldb-commits] [PATCH] D50365: Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

Sounds good! > On Sep 24, 2018, at 10:45 AM, Leonard Mosescu wrote: > > Thanks Greg, this is what I had in mind. > > I have some ideas which involve this kind of debugger console. We'll likely > start with a basic version built on top of evaluate `cmd and once we get > around to building a f

Re: [Lldb-commits] [PATCH] D46810: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

> On May 14, 2018, at 6:36 AM, Pavel Labath via Phabricator > wrote: > > labath added a comment. > > In https://reviews.llvm.org/D46810#1097740, @jankratochvil wrote: > >> In https://reviews.llvm.org/D46810#1097503, @labath wrote: >> >>> (If that is true, then I think this is workable, but

[Lldb-commits] [lldb] r343242 - Add an interactive mode to BSD archive parser.

Author: gclayton Date: Thu Sep 27 10:45:14 2018 New Revision: 343242 URL: http://llvm.org/viewvc/llvm-project?rev=343242&view=rev Log: Add an interactive mode to BSD archive parser. Modified: lldb/trunk/examples/python/bsd.py Modified: lldb/trunk/examples/python/bsd.py URL: http://llvm.org

[Lldb-commits] [lldb] r343243 - Fixes for GDB remote packet disassembler:

Author: gclayton Date: Thu Sep 27 10:55:36 2018 New Revision: 343243 URL: http://llvm.org/viewvc/llvm-project?rev=343243&view=rev Log: Fixes for GDB remote packet disassembler: - Add latency timings to GDB packet log summary if timestamps are on log - Add the ability to plot the latencies for eac

Re: [Lldb-commits] [lldb] r344628 - For a built & test bot, add an environment variable PLATFORM_SDK_DIRECTORY,

Would it be possible to use a setting instead of an environment variable? We could make some settings initialize or append addition values from an environment variables by building that logic into the code? > On Oct 16, 2018, at 10:31 AM, Jason Molenda via lldb-commits > wrote: > > Author: j

Re: [Lldb-commits] [lldb] r346430 - Fix bug in PE/COFF plugin and ValueObjectVariable.

Looks like this test was testing the functionality that you changed. It it expecting that a type won't be complete until you ask for more info about it (like asking about a child). Since PDB is not completing the type up front, we need to change LLDB or make your previous case work even when han

Re: [Lldb-commits] [lldb] r346430 - Fix bug in PE/COFF plugin and ValueObjectVariable.

Another way to think about this is if you have a SBValue that represents a class instances in an IDE, if no one turns it open to see the children, why do we need to complete the type? We should have to. The type should be able to complete itself if and when we need to know some information. This

Re: [Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

> On Nov 29, 2018, at 10:55 AM, Pavel Labath via Phabricator > wrote: > > labath added a comment. > > I've recently started looking at adding a new symbol file format (breakpad > symbols). While researching the best way to achieve that, I started comparing > the operation of PDB and DWARF s

Re: [Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

> On Nov 29, 2018, at 2:02 PM, Zachary Turner via Phabricator > wrote: > > zturner added a comment. > > In D53368#1313238 , @labath wrote: > >> In D53368#1313145 , @zturner wrote: >> >>> In D53368#1313124

Re: [Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

> On Nov 29, 2018, at 3:31 PM, Zachary Turner wrote: > > Objects have a symbol table, but a Module is just a loaded object file. And a > loaded object file can have multiple symbol tables (from the object file, or > symbol file, etc). > > Would it make sense to have Module provide a GetSymta

Re: [Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

> On Dec 10, 2018, at 11:23 AM, Leonard Mosescu wrote: > > > BTW: check my changes in: https://reviews.llvm.org/D55522 > > > > It will be interesting to you since it parses the linux maps info if it is > > available in breakpad generated minidump files. This

Re: [Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

> On Dec 10, 2018, at 3:11 PM, Leonard Mosescu wrote: > > I can see how this works for the PDB, no-module-binary case. What about the > PDB & module-binary case? That would work fine because the symbol vendor will make an object file from the m_symfile_spec and use both the original binary +

Re: [Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

> On Dec 11, 2018, at 7:14 AM, Pavel Labath wrote: > > On 11/12/2018 01:08, Greg Clayton wrote: >>> On Dec 10, 2018, at 3:11 PM, Leonard Mosescu >> > wrote: >>> >>> I can see how this works for the PDB, no-module-binary case. What about the >>> PDB & module-binary c

Re: [Lldb-commits] [PATCH] D55356: Add a method to get the "base" file address of an object file

> On Dec 11, 2018, at 11:58 AM, Pavel Labath wrote: > > On 11/12/2018 20:39, Jim Ingham wrote: >> Sections can have parents. In MachO the text and data sections are actually >> contained in the TEXT and DATA segments respectively. LLDB represents this >> by having an lldb_private::Section fo

[Lldb-commits] [lldb] r348951 - NFC: fix compiler warning about code never being executed when compiling on non windows platform.

Author: gclayton Date: Wed Dec 12 10:14:27 2018 New Revision: 348951 URL: http://llvm.org/viewvc/llvm-project?rev=348951&view=rev Log: NFC: fix compiler warning about code never being executed when compiling on non windows platform. Modified: lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolF

[Lldb-commits] [lldb] r349062 - Fix MinidumpParser::GetFilteredModuleList() and test it

Author: gclayton Date: Thu Dec 13 09:24:30 2018 New Revision: 349062 URL: http://llvm.org/viewvc/llvm-project?rev=349062&view=rev Log: Fix MinidumpParser::GetFilteredModuleList() and test it The MinidumpParser::GetFilteredModuleList() code was attempting to iterate through the entire module list

[Lldb-commits] [lldb] r349122 - Fix test failures that depended on module order

Author: gclayton Date: Thu Dec 13 19:07:15 2018 New Revision: 349122 URL: http://llvm.org/viewvc/llvm-project?rev=349122&view=rev Log: Fix test failures that depended on module order Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.p

[Lldb-commits] [lldb] r349180 - Fix Xcode project for MIPS architecture plug-in and move of Event, Listener and Broadcaster to Utility.

Author: gclayton Date: Fri Dec 14 11:22:24 2018 New Revision: 349180 URL: http://llvm.org/viewvc/llvm-project?rev=349180&view=rev Log: Fix Xcode project for MIPS architecture plug-in and move of Event, Listener and Broadcaster to Utility. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj

[Lldb-commits] [lldb] r349182 - Cache memory regions in ProcessMinidump and use the linux maps as the source of the information if available

Author: gclayton Date: Fri Dec 14 11:36:01 2018 New Revision: 349182 URL: http://llvm.org/viewvc/llvm-project?rev=349182&view=rev Log: Cache memory regions in ProcessMinidump and use the linux maps as the source of the information if available Breakpad creates minidump files that sometimes have:

[Lldb-commits] [lldb] r349183 - Add missing .dmp files to test inputs.

Author: gclayton Date: Fri Dec 14 11:38:08 2018 New Revision: 349183 URL: http://llvm.org/viewvc/llvm-project?rev=349183&view=rev Log: Add missing .dmp files to test inputs. Modified: lldb/trunk/unittests/Process/minidump/CMakeLists.txt Modified: lldb/trunk/unittests/Process/minidump/CMakeL

[Lldb-commits] [lldb] r349429 - Add "dump" command as a custom "process plugin" subcommand when ProcessMinidump is used.

Author: gclayton Date: Mon Dec 17 16:50:11 2018 New Revision: 349429 URL: http://llvm.org/viewvc/llvm-project?rev=349429&view=rev Log: Add "dump" command as a custom "process plugin" subcommand when ProcessMinidump is used. Each process plug-in can create its own custom commands. I figured it wo

[Lldb-commits] [lldb] r349658 - Show the memory region name if there is one in the output of the "memory region" command

Author: gclayton Date: Wed Dec 19 10:16:52 2018 New Revision: 349658 URL: http://llvm.org/viewvc/llvm-project?rev=349658&view=rev Log: Show the memory region name if there is one in the output of the "memory region" command Prior to this change we would show the name of the section that a memory

[Lldb-commits] [lldb] r349926 - Don't duplicate the logic that detects if a section can/should be loaded (NFC)

Author: gclayton Date: Fri Dec 21 09:04:18 2018 New Revision: 349926 URL: http://llvm.org/viewvc/llvm-project?rev=349926&view=rev Log: Don't duplicate the logic that detects if a section can/should be loaded (NFC) Prior to this there were 3 places that were duplicating the logic to detect if a s

Re: [Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

> On Jan 4, 2019, at 9:45 AM, Leonard Mosescu wrote: > > I have a minidump generator if you need me to make any specific minidump > files for you. > > Maybe not in this case, but it seems an interesting idea. What are the > capabilities of this generator tool? I can generate threads context

Re: [Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

The main goal for this minidump module was so I could load it into lldb and then run "minidump --save" to save the current process as a minidump file since I like minidump files better than core files... It just happens to work for generating very small and targeted minidump files for testing as

Re: [Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

> On Jan 4, 2019, at 12:37 PM, Leonard Mosescu wrote: > > Sounds very useful. Are you planning to add it to the LLDB repository? Yes > > > On Fri, Jan 4, 2019 at 10:56 AM Greg Clayton > wrote: > > >> On Jan 4, 2019, at 9:45 AM, Leonard Mosescu >

[Lldb-commits] [lldb] r332050 - Fix the code that gets the Xcode path. After path normalization this could was failing.

Author: gclayton Date: Thu May 10 15:09:01 2018 New Revision: 332050 URL: http://llvm.org/viewvc/llvm-project?rev=332050&view=rev Log: Fix the code that gets the Xcode path. After path normalization this could was failing. This meant if the "debugserver" binary was removed from the LLDB.framewo

[Lldb-commits] [lldb] r332511 - Fix FileSpecTest after LLVM changes to remove_dots (https://reviews.llvm.org/D46887)

Author: gclayton Date: Wed May 16 11:37:00 2018 New Revision: 332511 URL: http://llvm.org/viewvc/llvm-project?rev=332511&view=rev Log: Fix FileSpecTest after LLVM changes to remove_dots (https://reviews.llvm.org/D46887) Modified: lldb/trunk/unittests/Utility/FileSpecTest.cpp Modified: lldb/

[Lldb-commits] [lldb] r332556 - Revert 332511 after reverting llvm revision 332508.

Author: gclayton Date: Wed May 16 16:32:45 2018 New Revision: 332556 URL: http://llvm.org/viewvc/llvm-project?rev=332556&view=rev Log: Revert 332511 after reverting llvm revision 332508. Modified: lldb/trunk/unittests/Utility/FileSpecTest.cpp Modified: lldb/trunk/unittests/Utility/FileSpecT

[Lldb-commits] [lldb] r332618 - FileSpec objects that resolve to "." should have "." in m_filename and m_directory empty.

Author: gclayton Date: Thu May 17 09:12:38 2018 New Revision: 332618 URL: http://llvm.org/viewvc/llvm-project?rev=332618&view=rev Log: FileSpec objects that resolve to "." should have "." in m_filename and m_directory empty. After switching to LLVM normalization, if we init FileSpec with "." we

Re: [Lldb-commits] [PATCH] D46783: FileSpec objects that resolve to "." should have "." in m_filename and m_directory empty.

The patch in the differential is off, this is the fixed version of this patch? > On May 17, 2018, at 10:09 AM, Pavel Labath wrote: > > This has broken the unit tests. Looks like a bad merge that did not take > into account the refactoring in r332088. > On Thu, 17 May 2018 at 17:16, Phabricator

Re: [Lldb-commits] [PATCH] D46783: FileSpec objects that resolve to "." should have "." in m_filename and m_directory empty.

I just updated the differential with the actual patch. If you tried to apply the old one, then try it again with the latest diff I just uploaded > On May 17, 2018, at 10:09 AM, Pavel Labath wrote: > > This has broken the unit tests. Looks like a bad merge that did not take > into account the r

[Lldb-commits] [lldb] r332633 - Fix buildbots after it 332618

Author: gclayton Date: Thu May 17 10:18:11 2018 New Revision: 332633 URL: http://llvm.org/viewvc/llvm-project?rev=332633&view=rev Log: Fix buildbots after it 332618 Modified: lldb/trunk/unittests/Utility/FileSpecTest.cpp Modified: lldb/trunk/unittests/Utility/FileSpecTest.cpp URL: http://l

Re: [Lldb-commits] [PATCH] D46783: FileSpec objects that resolve to "." should have "." in m_filename and m_directory empty.

Fixed with svn commit unittests/Utility/FileSpecTest.cpp Sendingunittests/Utility/FileSpecTest.cpp Transmitting file data .done Committing transaction... Committed revision 332633. > On May 17, 2018, at 10:18 AM, Pavel Labath via Phabricator > wrote: > > labath added a comment. > > h

[Lldb-commits] [lldb] r332842 - Fix PathMappingList for relative and empty paths after recent FileSpec normalization changes

Author: gclayton Date: Mon May 21 07:14:36 2018 New Revision: 332842 URL: http://llvm.org/viewvc/llvm-project?rev=332842&view=rev Log: Fix PathMappingList for relative and empty paths after recent FileSpec normalization changes PathMappingList was broken for relative and empty paths after normal

Re: [Lldb-commits] Support of MSVC function-level linking

> On May 31, 2018, at 2:31 AM, Aleksandr Urakov via lldb-commits > wrote: > > Hello! > > I'm Aleksandr from JetBrains. We are working on improving support of > MSVC-compiled binaries in lldb. We have made several fixes and would like to > upstream them. > > The first patch adds support of

Re: [Lldb-commits] [PATCH] D48049: Add a new SBTarget::LoadCore() overload which surfaces errors if the load fails

Should not have spaces before any ( characters. What you typed looks good. > On Jun 11, 2018, at 2:00 PM, Leonard Mosescu wrote: > > remove space before ( > > I'd be happy to make the change, but looking at the rest of the file it seems > that almost everything uses the opposite convention:

Re: [Lldb-commits] [lldb] r334642 - [lit] Split test_set_working_dir TestProcessLaunch into two tests and fix it on Windows

I like seeing the windows debugger plug-in getting fixes. LLDB currently encourages everyone to add native debugging support to lldb-server. Then you get remote debugging support for free. It seems like you are putting in some time on the windows fixes, so I thought I would pass this along. The

Re: [Lldb-commits] [lldb] r334743 - Add a script to setup codesigning on macOS.

Nice! I never took the time to get this working from the command line. Thanks for this. > On Jun 14, 2018, at 11:04 AM, Frederic Riss via lldb-commits > wrote: > > Author: friss > Date: Thu Jun 14 11:04:13 2018 > New Revision: 334743 > > URL: http://llvm.org/viewvc/llvm-project?rev=334743&vi

Re: [Lldb-commits] [PATCH] D48393: Make DWARFParsing more thread-safe

> On Jun 21, 2018, at 7:47 AM, Zachary Turner wrote: > > Related question: Is the laziness done to save memory, startup time, or both? Both. It allows us to fetch only what we need when we need it. Time to break at main.cpp:123 is much quicker. Using LLDB for symbolication is much quicker as

Re: [Lldb-commits] [PATCH] D48393: Make DWARFParsing more thread-safe

> On Jun 21, 2018, at 7:58 AM, Zachary Turner wrote: > > Performance i get. Gdb is almost unusable for large programs because of how > long it takes to load debug info. Agreed. With our new DWARF5 tables, we will be even better. Or test on a mac with dSYM files and you will get similar numbe

Re: [Lldb-commits] [PATCH] D48393: Make DWARFParsing more thread-safe

> On Jun 21, 2018, at 8:32 AM, Frédéric Riss wrote: > > > >> On Jun 21, 2018, at 3:18 AM, Pavel Labath via Phabricator >> wrote: >> >> labath added a comment. >> >> I am not sure this will actually solve the problems you are seeing. This may >> avoid corrupting the internal DenseMap data

Re: [Lldb-commits] [lldb] r335236 - ScriptInterpreterPython cleanup

> On Jun 21, 2018, at 10:30 AM, Pavel Labath via lldb-commits > wrote: > > Sure, I can do that. The though of xcode compatibility did enter my > mind briefly while doing this, but I just assumed that XCode always > builds with python enabled. I guess I was wrong. > > Out of curiosity, what ar

[Lldb-commits] [lldb] r335263 - Fix an issue where DW_OP_deref might be dereferencing a file address. Convert the file address to a load address so this works.

Author: gclayton Date: Thu Jun 21 10:58:06 2018 New Revision: 335263 URL: http://llvm.org/viewvc/llvm-project?rev=335263&view=rev Log: Fix an issue where DW_OP_deref might be dereferencing a file address. Convert the file address to a load address so this works. https://bugs.llvm.org/show_bug.cg

Re: [Lldb-commits] [lldb] r335263 - Fix an issue where DW_OP_deref might be dereferencing a file address. Convert the file address to a load address so this works.

I can't think if an easy way to add a test for this or I would have. Greg > On Jun 21, 2018, at 11:19 AM, Jonas Devlieghere > wrote: > > Hi Greg, > > Would you mind adding a test case for this? > > Thanks, > Jonas > >> On Jun 21, 2018, at 6:58 PM,

[Lldb-commits] [lldb] r335401 - Update cmdtemplate.py to use best pratices.

Author: gclayton Date: Fri Jun 22 16:34:24 2018 New Revision: 335401 URL: http://llvm.org/viewvc/llvm-project?rev=335401&view=rev Log: Update cmdtemplate.py to use best pratices. Fixes include: - fix all lint errors - add code that will automatically register and LLDB command classes by detectin

[Lldb-commits] [lldb] r337694 - Add support for parsing Breakpad minidump files that can have extra padding in the module, thread and memory lists.

Author: gclayton Date: Mon Jul 23 07:16:08 2018 New Revision: 337694 URL: http://llvm.org/viewvc/llvm-project?rev=337694&view=rev Log: Add support for parsing Breakpad minidump files that can have extra padding in the module, thread and memory lists. Differential Revision: https://reviews.llvm.o

[Lldb-commits] [lldb] r337758 - Fix Xcode project for unit tests.

Author: gclayton Date: Mon Jul 23 15:22:46 2018 New Revision: 337758 URL: http://llvm.org/viewvc/llvm-project?rev=337758&view=rev Log: Fix Xcode project for unit tests. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: http://llvm.

Re: [Lldb-commits] [PATCH] D49750: Add support for ARM and ARM64 breakpad generated minidump files.

> On Jul 30, 2018, at 12:17 PM, Leonard Mosescu wrote: > > FYI, Breakpad & Crashpad will start generating the Microsoft flavor of ARM > minidumps soon. How do we tell the difference? I am guessing the ProcessorArchitecture will both be set to "PROCESSOR_ARCHITECTURE_ARM". Are plug-ins expect

[Lldb-commits] [lldb] r338734 - Add support for ARM and ARM64 breakpad generated minidump files

Author: gclayton Date: Thu Aug 2 09:46:15 2018 New Revision: 338734 URL: http://llvm.org/viewvc/llvm-project?rev=338734&view=rev Log: Add support for ARM and ARM64 breakpad generated minidump files In this patch I add support for ARM and ARM64 break pad files. There are two flavors of ARM: Appl

Re: [Lldb-commits] [PATCH] D50336: Add support for ARM and ARM64 breakpad generated minidump files (version 2).

I was in the process of testing on linux. I will fix this. > On Aug 6, 2018, at 8:19 AM, Zachary Turner wrote: > > Did you see my comments on the first round about how the CMake build didn’t > work? Because I don’t see any changes to CMakeLists.txt here, which means it > still won’t work. >

[Lldb-commits] [lldb] r339032 - Add support for ARM and ARM64 breakpad generated minidump files (version 2).

Author: gclayton Date: Mon Aug 6 09:56:10 2018 New Revision: 339032 URL: http://llvm.org/viewvc/llvm-project?rev=339032&view=rev Log: Add support for ARM and ARM64 breakpad generated minidump files (version 2). In this patch I add support for ARM and ARM64 break pad files. There are two flavors

[Lldb-commits] [lldb] r339033 - Fix offsetof usage that got lost when passing patches between linux and mac.

Author: gclayton Date: Mon Aug 6 10:07:50 2018 New Revision: 339033 URL: http://llvm.org/viewvc/llvm-project?rev=339033&view=rev Log: Fix offsetof usage that got lost when passing patches between linux and mac. Modified: lldb/trunk/source/Plugins/Process/minidump/RegisterContextMinidump_ARM

[Lldb-commits] [lldb] r339034 - Fix more offsetof issues.

Author: gclayton Date: Mon Aug 6 10:26:53 2018 New Revision: 339034 URL: http://llvm.org/viewvc/llvm-project?rev=339034&view=rev Log: Fix more offsetof issues. Modified: lldb/trunk/source/Plugins/Process/minidump/RegisterContextMinidump_ARM.cpp Modified: lldb/trunk/source/Plugins/Process/

Re: [Lldb-commits] [PATCH] D50365: Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

It is a different protocol. The LLDB MI plugin didn't work very well as was quite flaky when I tested it a while back. Then I grabbed the CodeLLDB plugin by Vadim Chugunov and it worked very well. When I looked more closely at this plugin, it was using a javascript/typescript plug-in to launch a

Re: [Lldb-commits] [PATCH] D50365: Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

> On Aug 8, 2018, at 8:40 AM, Zachary Turner wrote: > > Ok sounds good then, mostly just wanted to make sure you weren't re-inventing > something that already existed :) Do you plan to publish this on the VSCode > marketplace? I would like to. Not sure how this works with native binaries as

Re: [Lldb-commits] [PATCH] D50365: Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

> On Aug 8, 2018, at 5:52 PM, Leonard Mosescu wrote: > > The LLDB MI plugin didn't work very well as was quite flaky when I tested it > a while back. > > Just curious, what was the flaky part, the debug adapter or the LLDB MI > interface? Not sure. Debugging wasn't rock solid. Don't know w

[Lldb-commits] [lldb] r339817 - Fix doc string variable name to quiet a compiler warning.

Author: gclayton Date: Wed Aug 15 14:21:22 2018 New Revision: 339817 URL: http://llvm.org/viewvc/llvm-project?rev=339817&view=rev Log: Fix doc string variable name to quiet a compiler warning. Modified: lldb/trunk/include/lldb/API/SBProcess.h Modified: lldb/trunk/include/lldb/API/SBProcess.

Re: [Lldb-commits] [PATCH] D50365: Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

Inline comments really help if you don't mind. > On Aug 16, 2018, at 9:23 AM, Zachary Turner via Phabricator > wrote: > > zturner added a comment. > > I had a couple of other comments, but since I responded from email since I > was on the go and I guess they didn't show up inline. Sorry abou

Re: [Lldb-commits] [lldb] r339920 - Fix lldb-vscode build on Windows

It would be interesting to have some sort of warning or static analyzer to avoid platform specific name conflicts like CreateEvent. People always use "id" as a variable name and that can cause problems when a header is included in objective C. Thanks for the windows fixes. > On Aug 16, 2018,

[Lldb-commits] [lldb] r339954 - Update the Core file loading instructions so they keep the process stopped after attaching to a core file.

Author: gclayton Date: Thu Aug 16 15:13:01 2018 New Revision: 339954 URL: http://llvm.org/viewvc/llvm-project?rev=339954&view=rev Log: Update the Core file loading instructions so they keep the process stopped after attaching to a core file. Modified: lldb/trunk/tools/lldb-vscode/README.md

[Lldb-commits] [lldb] r340050 - Change the attach test case to use self.assertEqual so we can get more info on what is going wrong on test bots.

Author: gclayton Date: Fri Aug 17 10:27:53 2018 New Revision: 340050 URL: http://llvm.org/viewvc/llvm-project?rev=340050&view=rev Log: Change the attach test case to use self.assertEqual so we can get more info on what is going wrong on test bots. Also add a cleanup function to remove the copied

Re: [Lldb-commits] [lldb] r339911 - Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

It it failing to set a breakpoint in a binary before we even run. If we run into other errors then increasing the timeout would make sense. But here it is setting a source regex breakpoint on "// breakpoint 1" and it isn't getting the number of locations. I just committed 340050 which uses a sel

Re: [Lldb-commits] [lldb] r339911 - Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

I can expectedFail this test if needed? > On Aug 17, 2018, at 10:34 AM, Greg Clayton wrote: > > It it failing to set a breakpoint in a binary before we even run. If we run > into other errors then increasing the timeout would make sense. But here it > is setting a source regex breakpoint on "/

[Lldb-commits] [lldb] r340077 - Skip the lldb-vscode attach with waitFor test for now, some build bots are having trouble.

Author: gclayton Date: Fri Aug 17 13:42:06 2018 New Revision: 340077 URL: http://llvm.org/viewvc/llvm-project?rev=340077&view=rev Log: Skip the lldb-vscode attach with waitFor test for now, some build bots are having trouble. Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-v

Re: [Lldb-commits] [lldb] r339911 - Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

I run everything on a mac and there are no failures on my machine. Can you find out exactly how the test suite is invoked so I can try to reproduce? > On Aug 17, 2018, at 1:39 PM, Adrian Prantl wrote: > > Here's a third failure: > > http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/90

[Lldb-commits] [lldb] r340112 - Skip tests on Darwin for now. The build bots are not passing due to heavy load and poor machines.

Author: gclayton Date: Fri Aug 17 17:33:15 2018 New Revision: 340112 URL: http://llvm.org/viewvc/llvm-project?rev=340112&view=rev Log: Skip tests on Darwin for now. The build bots are not passing due to heavy load and poor machines. Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/

Re: [Lldb-commits] [lldb] r339911 - Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

$ svn commit Sending packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py Sending packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py Sending packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_s

[Lldb-commits] [lldb] r340966 - Don't include the Age in the UUID for CvRecordPdb70 UUID records in minidump files for Apple vendors.

Author: gclayton Date: Wed Aug 29 13:34:08 2018 New Revision: 340966 URL: http://llvm.org/viewvc/llvm-project?rev=340966&view=rev Log: Don't include the Age in the UUID for CvRecordPdb70 UUID records in minidump files for Apple vendors. The CvRecordPdb70 structure looks like: struct CvRecordPdb

Re: [Lldb-commits] [lldb] r341535 - Reland [ClangUserExpression][NFC] Removed unused code

Might be a good idea to add a comment in the code for this explaining the desired side effects? > On Sep 6, 2018, at 3:24 AM, Raphael Isemann via lldb-commits > wrote: > > Author: teemperor > Date: Thu Sep 6 03:24:11 2018 > New Revision: 341535 > > URL: http://llvm.org/viewvc/llvm-project?r

Re: [Lldb-commits] [lldb] r341683 - Add input files to the "prepare swig bindings" step.

Is the space in the string for for SBHostOS.cpp ok? Might want to remove it just in case: + " $(SRCROOT)/source/API/SBHostOS.cpp", > On Sep 7, 2018, at 11:10 AM, Jim Ingham via lldb-commits > wrote: > > Author: jingham > Date: Fri Sep 7 11:10:26 2018 > New Revis

Re: [Lldb-commits] [lldb] r342029 - Reduce alignment on struct XSAVE, fixing a gcc warning

Don't we get a blob of register bytes back from ptrace when reading registers? The struct we use must match this byte for byte. This seems like this change could affect the ability to get correct register values? > On Sep 12, 2018, at 1:50 AM, Pavel Labath via lldb-commits > wrote: > > Author

Re: [Lldb-commits] [lldb] r342029 - Reduce alignment on struct XSAVE, fixing a gcc warning

Sounds good, thanks for clarifying. Just want to be safe. > On Sep 12, 2018, at 9:09 AM, Pavel Labath wrote: > > On 12/09/18 16:37, Greg Clayton wrote: >> Don't we get a blob of register bytes back from ptrace when reading >> registers? The struct we use must match this byte for byte. > > That

Re: [Lldb-commits] [PATCH] D50365: Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

> On Sep 20, 2018, at 3:05 PM, Leonard Mosescu wrote: > > Hi Greg, looking at request_evaluate() I noticed that it will evaluate the > string as a lldb command if prefixed by ` . > > This is a great feature (it allows building REPL consoles on top of DAP), but > I'm curious how you picked u

[Lldb-commits] [lldb] r317945 - Added a way to dump the full paths to all source files in a module that has debug info.

Author: gclayton Date: Fri Nov 10 14:39:07 2017 New Revision: 317945 URL: http://llvm.org/viewvc/llvm-project?rev=317945&view=rev Log: Added a way to dump the full paths to all source files in a module that has debug info. Modified: lldb/trunk/www/troubleshooting.html Modified: lldb/trunk/

Re: [Lldb-commits] [PATCH] D40079: Make sure DataBufferLLVM contents are writable

> On Nov 15, 2017, at 10:11 AM, Zachary Turner wrote: > > > > On Wed, Nov 15, 2017 at 9:51 AM Pavel Labath > wrote: > On 15 November 2017 at 17:42, Zachary Turner > wrote: > > Can we just extend llvm's mapped_file_region to support a boole

[Lldb-commits] [lldb] r318424 - Fixed up to use a class for the commands, renamed the commands and added a way to just dump the compile unit full paths and optionally their support files with the new

Author: gclayton Date: Thu Nov 16 09:14:48 2017 New Revision: 318424 URL: http://llvm.org/viewvc/llvm-project?rev=318424&view=rev Log: Fixed up to use a class for the commands, renamed the commands and added a way to just dump the compile unit full paths and optionally their support files with t

Re: [Lldb-commits] [PATCH] D40211: Add comments to DWARFCompileUnit length fields/methods

> On Nov 19, 2017, at 4:56 PM, Zachary Turner wrote: > > > > On Sun, Nov 19, 2017 at 6:35 AM Jan Kratochvil via Phabricator via > lldb-commits > wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL318626:

Re: [Lldb-commits] [PATCH] Use the DWARF linkage name when importing C++ methods

Please submit a review of this patch through reviews.llvm.org . - svn diff -x -U9 > /tmp/a.patch - login or create a login if you don't already have one - Select Differential from the top left corner - Click "+ Create Diff" in upper right - Click "Choose File" and s

Re: [Lldb-commits] [PATCH] D40211: Add comments to DWARFCompileUnit length fields/methods

sizeof(struct) tends to include system level padding for the current host. But to answer your question, no there isn't a structure defined like this and we wouldn't use them anyway as we want to fill out one compile unit struct that works for both. > On Nov 20, 2017, at 8:01 AM, Zachary Turner

Re: [Lldb-commits] [PATCH] D40537: Simplify UUID::IsValid()

> On Nov 27, 2017, at 10:11 PM, Zachary Turner wrote: > > As an aside, I don't really like this class. For example, You can currently > assign a UUID[16] to a UUID[20]. That doesn't make a lot of sense to me. What about an invalid UUID[0] being assigned with a valid UUID[16] or UUID[20]? Wh

Re: [Lldb-commits] [PATCH] D40537: Simplify UUID::IsValid()

> On Nov 28, 2017, at 10:24 AM, Zachary Turner wrote: > > > > On Tue, Nov 28, 2017 at 10:18 AM Greg Clayton > wrote: >> On Nov 27, 2017, at 10:11 PM, Zachary Turner > > wrote: >> >> As an aside, I don't really like this class. For exampl

[Lldb-commits] [lldb] r319213 - Update remote debugging page with many more details.

Author: gclayton Date: Tue Nov 28 12:04:43 2017 New Revision: 319213 URL: http://llvm.org/viewvc/llvm-project?rev=319213&view=rev Log: Update remote debugging page with many more details. Modified: lldb/trunk/www/remote.html Modified: lldb/trunk/www/remote.html URL: http://llvm.org/viewvc/

Re: [Lldb-commits] [PATCH] D40616: ObjectFileELF: Add support for compressed sections

> On Nov 29, 2017, at 2:10 PM, Jason Molenda via lldb-commits > wrote: > > The last time this discussion came up (Sep 2016), I pointed out that a great > approach here would be to use the lldb-mi driver. The MI (Machine Interface) > is a JSON-like debugger UI which closely models how people

Re: [Lldb-commits] [PATCH] D40745: Add a clang-ast subcommand to lldb-test

Didn't someone recently submit a patch to allow relocation of .o files? That should have taken care of the issue, no? > On Dec 4, 2017, at 5:01 AM, Pavel Labath via lldb-commits > wrote: > > The reason you hit the assert there, is because you're running lldb on > an un-linked object file. When

Re: [Lldb-commits] [PATCH] D40616: ObjectFileELF: Add support for compressed sections

> On Dec 11, 2017, at 10:25 AM, Zachary Turner wrote: > > What about adding GetMemorySize? We already have that as Section::GetByteSize(). > On Mon, Dec 11, 2017 at 10:23 AM Greg Clayton via Phabricator > mailto:revi...@reviews.llvm.org>> wrote: > clayborg added a comment. > > I think GetFi

Re: [Lldb-commits] [PATCH] D41086: [lldb] Check that a regex is valid before searching by regex for a symbol in a pdb.

Please do add this as that is the best solution. If no other plug-ins currently support it, it is fine to just stub out the virtual function in SymbolFile::FindTypesByRegex(...) to return Error("unsupported") and we can implement it in the regex search later for DWARF and other plug-ins. Greg

Re: [Lldb-commits] [PATCH] D41086: [lldb] Check that a regex is valid before searching by regex for a symbol in a pdb.

ok, good starting point then. We can submit another patch to add the find types by regex functionality. Greg > On Dec 18, 2017, at 9:54 AM, Zachary Turner wrote: > > I agree that's better long term, but this code was already there, and the > patch makes things strictly better than before (lit

Re: [Lldb-commits] [lldb] r321271 - Work around test failures on red-hat linux

> On Dec 21, 2017, at 7:24 AM, Pavel Labath via lldb-commits > wrote: > > On 21 December 2017 at 15:17, Pavel Labath wrote: >> Right now I'm looking at two (ignoring the debug-info multiplication): >> TestExprs2.py and TestTopLevelExprs.py >> TestExprs2 is encountering ambiguity when looking u

Re: [Lldb-commits] [lldb] r321271 - Work around test failures on red-hat linux

BTW: we should remove the GetIsDynamicLinkEditor() from Module.h/cpp and ObjectFile.h, ObjectFileMachO.h/.cpp since it is dead code now. > On Dec 21, 2017, at 7:24 AM, Pavel Labath via lldb-commits > wrote: > > On 21 December 2017 at 15:17, Pavel Labath wrote: >> Right now I'm looking at two

Re: [Lldb-commits] [PATCH] D41086: [lldb] Stop searching for a symbol in a pdb by regex

We should fix the test case to not require regex, or add SymbolFile::FindTypesByRegex(...) and pass that through to public API if needed. Not sure where the test is failing (gtest, or public API test). > On Dec 22, 2017, at 2:01 AM, Pavel Labath via Phabricator > wrote: > > labath added a com

Re: [Lldb-commits] [PATCH] D40283: lldb: Use the DWARF linkage name when importing C++ methods

The right solution seems to be adding some sort of custom GNU ABI tag to the DWARF. I know that won't help with existing binaries, but it sounds too expensive to set the ASM name for everything. > On Jan 10, 2018, at 2:23 PM, Nelson Elhage via Phabricator > wrote: > > nelhage added a comment

Re: [Lldb-commits] [PATCH] D41902: Remove Platform references from the Host module

> On Jan 11, 2018, at 5:12 AM, Pavel Labath wrote: > > Thanks for adding the test Jim. I have confirmed that it passes with > this patch applied (because the bundle is resolved during target > creating, not launching). > > However, this did make me aware of the fact that this patch removed > th

Re: [Lldb-commits] [PATCH] D41902: Remove Platform references from the Host module

> On Jan 11, 2018, at 8:10 AM, Pavel Labath wrote: > > On 11 January 2018 at 16:04, Greg Clayton wrote: >> >>> On Jan 11, 2018, at 5:12 AM, Pavel Labath wrote: >>> >>> Thanks for adding the test Jim. I have confirmed that it passes with >>> this patch applied (because the bundle is resolved

Re: [Lldb-commits] [PATCH] D41962: Fix TestYMMRegisters for older machines without AVX2

Why not just look for the AVX registers by name that are only available if they are correctly detected by the native lldb-server or debugserver? Then we can avoid all of this. If we don't execute any instructions that crash the program, we can stop before any specialized AVX instructions are exe

Re: [Lldb-commits] [PATCH] D42281: WIP: compile the LLDB tests out-of-tree

> On Jan 19, 2018, at 9:04 AM, Adrian Prantl via Phabricator > wrote: > > aprantl added a comment. > > In https://reviews.llvm.org/D42281#981969, @clayborg wrote: > >> Looks like a good start. It might be nice to validate that after "clean" >> that we have no files that are untracked in the

Re: [Lldb-commits] [lldb] r325068 - [cmake] Darwin: Copy in the system debugserver if needed

If "debugserver" isn't put into the LLDB.framework, then it falls back to using the one in the currently selected Xcode. We don't really need to copy it if we just want to use the active system version? > On Feb 13, 2018, at 3:08 PM, Vedant Kumar via lldb-commits > wrote: > > @Davide I think

Re: [Lldb-commits] [lldb] r327356 - [ExpressionParser] Fix crash when evaluating invalid expresssions.

I agree with Jason, we shouldn't be looking at magic naming and making assumptions. What is the name is a C function that starts with _Z. Both of Jason's examples below should work. Sometimes we only have symbol tables and if people are able to only get to the C++ function via a mangled name, t

  1   2   3   4   5   6   7   8   9   10   >