Please do add this as that is the best solution. If no other plug-ins currently
support it, it is fine to just stub out the virtual function in
SymbolFile::FindTypesByRegex(...) to return Error("unsupported") and we can
implement it in the regex search later for DWARF and other plug-ins.
Greg
> On Dec 11, 2017, at 1:40 PM, Zachary Turner <ztur...@google.com> wrote:
>
> SymbolFile does not have a method for searching by regex. There is a
> FindFunctions and FindGlobalVariables that allows searching by regex, but not
> one for types. That said, one could be added to the base class, yes. That
> does seem like a better long term solution.
>
> On Mon, Dec 11, 2017 at 1:37 PM Greg Clayton via Phabricator
> <revi...@reviews.llvm.org <mailto:revi...@reviews.llvm.org>> wrote:
> clayborg added a comment.
>
> We should have a dedicated API that actually searches for types using a
> lldb_private::RegularExpression. Why do we even try to create a regular
> expression in SymbolFilePDB::FindTypes()? Was it used in testing? No API in
> LLDB currently expects this and all other API in LLDB has a separate function
> call that uses lldb_private::RegularExpression. We can add one if needed to
> the lldb_private::SymbolFile API. I don't like API that magically tries to
> look at something and tries to compile a regular expression on each
> invocation. Can we change this?
>
>
> Repository:
> rL LLVM
>
> https://reviews.llvm.org/D41086 <https://reviews.llvm.org/D41086>
>
>
>
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
