> On Dec 10, 2018, at 11:23 AM, Leonard Mosescu <mose...@google.com> wrote: > > > BTW: check my changes in: https://reviews.llvm.org/D55522 > > <https://reviews.llvm.org/D55522> > > It will be interesting to you since it parses the linux maps info if it is > > available in breakpad generated minidump files. This will give us enough > > info to create correct sections for object files when we have no ELF file > > or no symbol file (ELF/DWARF or breakpad). > > Looks interesting, thanks for pointing it out. From a quick glance it seems > that your change would complement the generic support I'm adding here.
Indeed it will. Part of my patch was a hook in the placeholder module GetObjectFile() where if someone set the symbol file for it via "target symbol add ..." it would replace the "m_file" in the module with the symbol file and then get the object file from the symbol file that was added. So it is a different approach to yours. I will attach my copy of "PlaceholderModule" to your patch so you can see what I did.
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
