> On Jul 30, 2018, at 12:17 PM, Leonard Mosescu <mose...@google.com> wrote:
> 
> FYI, Breakpad & Crashpad will start generating the Microsoft flavor of ARM 
> minidumps soon.

How do we tell the difference? I am guessing the ProcessorArchitecture will 
both be set to "PROCESSOR_ARCHITECTURE_ARM". Are plug-ins expected to look at 
the byte size of the thread context then?

Greg

> 
> On Wed, Jul 25, 2018 at 9:44 AM, Leonard Mosescu via Phabricator 
> <revi...@reviews.llvm.org <mailto:revi...@reviews.llvm.org>> wrote:
> lemo added inline comments.
> 
> 
> ================
> Comment at: source/Plugins/Process/minidump/RegisterContextMinidump_ARM.cpp:51
> +  reg_fpscr,
> +  reg_d0,   reg_d1,  reg_d2,  reg_d3,  reg_d4,  reg_d5,  reg_d6,  reg_d7,
> +  reg_d8,   reg_d9, reg_d10, reg_d11, reg_d12, reg_d13, reg_d14, reg_d15,
> ----------------
> Pavel's comment reminded me: what about the S registers (32bit fp) and Q 
> registers (128bit Neon)?
> 
> 
> https://reviews.llvm.org/D49750 <https://reviews.llvm.org/D49750>
> 
> 
> 
> 

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to