[Lldb-commits] [PATCH] D52516: [lldbinline] Set directory attribute on test-specific classes

davide accepted this revision. davide added a comment. LGTM. https://reviews.llvm.org/D52516 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D51874: Fix buildbot regression by rL339929: NameError: global name 'test_directory' is not defined

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. I think this looks fine. Vedant, thoughts? Repository: rLLDB LLDB https://reviews.llvm.org/D51874 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D52851: Adding support to step into the callable wrapped by libc++ std::function

davide added a comment. Some basic comments. Haven't looked at the implementation very closely, I'll do that probably tomorrow. Thanks for working on this! Comment at: include/lldb/Target/CPPLanguageRuntime.h:59-60 + lldb::ThreadPlanSP GetStepThroughTrampolinePlan(Thread &t

[Lldb-commits] [PATCH] D52678: DWARFExpression: Resolve file addresses in the linked module

davide added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/target_var/globals.ll:1 +source_filename = "globals.c" +target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128" vsk wrote: > Should we check in bitcode instead? That mig

[Lldb-commits] [PATCH] D50304: [lldb] CommandObjectThreadUntil should set breakpoint at either on exact or the nearest subsequent line number but not on all the subsequent line numbers

davide added a comment. I'll commit this for you, but I might ask if you can try adding a test first? https://reviews.llvm.org/D50304 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [PATCH] D53010: Add an alias "var" for "frame var" and "vo" for "frame var -O"

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LG. If you can add a line to an existing inline test, I think it would be excellent. Repository: rLLDB LLDB https://reviews.llvm.org/D53010 _

[Lldb-commits] [PATCH] D52851: Adding support to step into the callable wrapped by libc++ std::function

davide accepted this revision. davide added a comment. LGTM too. Thanks for taking the time to address the comments. https://reviews.llvm.org/D52851 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [PATCH] D53530: Fix (and improve) the support for C99 variable length array types

davide added inline comments. Comment at: source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp:213-229 + // Handle variables with incomplete array types. + auto *type = in_value.GetCompilerType().GetOpaqueQualType(); + auto qual_type = clang::Qual

[Lldb-commits] [PATCH] D53788: [FileSystem] Remove GetByteSize() from FileSpec

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB https://reviews.llvm.org/D53788 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cg

[Lldb-commits] [PATCH] D53834: [FileSystem] Remove ResolveExecutableLocation() from FileSpec

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM, thanks. https://reviews.llvm.org/D53834 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [PATCH] D54003: Refactor ClangASTContext::AddEnumerationValueToEnumerationType() to remove redundant parameter which can be calculated from other parameter

davide added inline comments. Comment at: packages/Python/lldbsuite/test/expression_command/radar_43822994/TestScopedEnumType.py:42 +## integral is not implicitly convertible to a scoped enum +value = frame.EvaluateExpression("1 == Foo::FooBar") +self.ass

[Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

davide added a comment. This broke MacOS. I'm going to revert this. To reproduce, just run `ninja check-lldb` with your patches. Please let me know if you need other informations. Repository: rLLDB LLDB https://reviews.llvm.org/D53368 ___ lldb-c

[Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

davide added a comment. In https://reviews.llvm.org/D53368#1286361, @aleksandr.urakov wrote: > Thanks for catching that! Unfortunately, I have no access to MacOS, can you > provide some more info about failure, please? Unfortunately the bot logs are gone. When I originally looked at them they

[Lldb-commits] [PATCH] D54056: Add SetAllowJIT (the SBExpressionOptions equivalent of "expression --allow-jit")

davide added a comment. In https://reviews.llvm.org/D54056#1286620, @jankratochvil wrote: > It broke the testsuite for me: > > $ time > PYTHONPATH=$PWD/lib64/python2.7/site-packages:$PWD/lib64/python2.7/site-packages/lldb > ../llvm-git/tools/lldb/test/dotest.py --executable $PWD/bin/lldb -C

[Lldb-commits] [PATCH] D54057: Remove Go debugger plugin

davide accepted this revision. davide added a comment. LGTM. Thanks for picking up the slack. https://reviews.llvm.org/D54057 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54059: Remove Java debugger plugin

davide added inline comments. Comment at: tools/lldb-test/SystemInitializerTest.cpp:194 SystemRuntimeMacOSX::Initialize(); RenderScriptRuntime::Initialize(); - JavaLanguageRuntime::Initialize(); Aside, do you know why we have renderscript support? maybe th

[Lldb-commits] [PATCH] D51566: Add a relocation to ObjectFileELF::ApplyRelocations and a test

davide added a comment. @lanza Hey Nathan, it looks like your test exposed an UB in `ELFObjectFileReader`. May I ask you to take a look? - TEST 'lldb-Unit :: ObjectFile/ELF/./ObjectFileELFTests/ObjectFileELFTest.TestAARCH64Relocations' FAILED Note: Google Test filter = Ob

[Lldb-commits] [PATCH] D51566: Add a relocation to ObjectFileELF::ApplyRelocations and a test

davide added a comment. In https://reviews.llvm.org/D51566#1288792, @davide wrote: > @lanza Hey Nathan, it looks like your test exposed an UB in > `ELFObjectFileReader`. May I ask you to take a look? > > - TEST 'lldb-Unit :: > ObjectFile/ELF/./ObjectFileELFTests/ObjectFileELFTest.TestAARCH64Rel

[Lldb-commits] [PATCH] D44060: [lldb] Fix "code requires global destructor" warning in g_architecture_mutex

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D44060 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [PATCH] D44073: [lldb] Refactor ObjC/NSException.cpp (cleanup, avoid code duplication). NFC.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Sounds good. https://reviews.llvm.org/D44073 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [PATCH] D44081: [lldb] Add synthetic frontend for _NSCallStackArray

davide requested changes to this revision. davide added inline comments. This revision now requires changes to proceed. Comment at: source/Plugins/Language/ObjC/NSArray.cpp:446-451 + } else if (class_name == g_NSCallStackArray) { +Status error; +value = process_sp->ReadU

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

davide requested changes to this revision. davide added inline comments. This revision now requires changes to proceed. Comment at: source/Plugins/Language/ObjC/NSException.cpp:161-168 +static ConstString g___name("name"); +static ConstString g___reason("reason"); st

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. Thanks. https://reviews.llvm.org/D43884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [PATCH] D54431: [lldb] Add "ninja" to svn:ignore

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. This is trivial. I don't know why we didn't do this before. https://reviews.llvm.org/D54431 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D44081: [lldb] Add synthetic frontend for _NSCallStackArray

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Thanks for addressing my comments. https://reviews.llvm.org/D44081 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.or

[Lldb-commits] [PATCH] D54602: Use a shared module cache directory for LLDB.

davide accepted this revision. davide added a comment. lgtm https://reviews.llvm.org/D54602 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54680: Don't use lldb -O in lit tests

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. Is there a way of fixing this that doesn't require scattering the test between two files? https://reviews.llvm.org/D54680 ___ lldb-com

[Lldb-commits] [PATCH] D54680: Don't use lldb -O in lit tests

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. I don't have any other great ideas either and I'd say the proposed alternative is not worth the complexity. https://reviews.llvm.org/D54680 ___

[Lldb-commits] [PATCH] D54863: [ASTImporter] Set MustBuildLookupTable on PrimaryContext

davide added a comment. In D54863#1306947 , @martong wrote: > We have a change in Clang/ASTImporter which causes an LLDB assertion, unless > this patch is applied. > The related change is https://reviews.llvm.org/D53655 > > In that patch we change the im

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

davide added a comment. In D54692#1308071 , @clayborg wrote: > Would be great to see old and new output like Zach suggested. Is there a > reason we need to use TableGen? Other command line tools just use llvm:🆑:opt > stuff. Seems a bit obtuse to use Tabl

[Lldb-commits] [PATCH] D54863: [ASTImporter] Set MustBuildLookupTable on PrimaryContext

davide added a comment. In D54863#1308176 , @martong wrote: > > Can you write an lldb test for this? > > There is already an existing test for that: > > 2: test_expr_dwarf (TestSharedLib.SharedLibTestCase) > Test that types work when defined in a sh

[Lldb-commits] [PATCH] D54616: [Reproducers] Improve reproducer API and add unit tests.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54616/new/ https://reviews.llvm.org/D54616 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D55240: [FileSystem] Migrate CommandCompletions

davide added a comment. No objections from me, but I would appreciate if @labath can take a look. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55240/new/ https://reviews.llvm.org/D55240 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D55383: Implement basic DidAttach for DynamicLoaderWindowsDYLD for use with ds2

davide added subscribers: zturner, labath, davide. davide added a comment. You would recommend getting a post-commit review from @labath or @zturner Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55383/new/ https://reviews.llvm.org/D55383

[Lldb-commits] [PATCH] D55776: Fix lldb's macosx/heap.py cstr command

davide accepted this revision. davide added a comment. commit 44b5014ce138fa293238afeaa53cfd4c2f5b12d2 (HEAD -> master) Author: Davide Italiano Date: Mon Dec 17 10:23:44 2018 -0800 Fix lldb's macosx/heap.py cstr command. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55776/new

[Lldb-commits] [PATCH] D56014: [lldb] - Fix crash when listing the history with the key up.

davide added a comment. testcase? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56014/new/ https://reviews.llvm.org/D56014 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D56170: RangeMap.h: merge RangeDataArray and RangeDataVector

davide added inline comments. Comment at: unittests/Core/RangeMapTest.cpp:52-54 + // However, this does not always succeed. + // TODO: This should probably return the range (0, 40) as well. + EXPECT_THAT(Map.FindEntryThatContains(35), nullptr); I think this is

[Lldb-commits] [PATCH] D56170: RangeMap.h: merge RangeDataArray and RangeDataVector

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56170/new/ https://reviews.llvm.org/D56170 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D56389: [CMake] Fix standalone builds: make dependency to LLVM's `count` conditional

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56389/new/ https://reviews.llvm.org/D56389 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D45628: [LLDB] Support GNU-style compressed debug sections (.zdebug)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL332162: [LLDB] Support GNU-style compressed debug sections (.zdebug) (authored by davide, committed by ). Changed prior t

[Lldb-commits] [PATCH] D47014: Fix _NSCFBoolean data formatter.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D47014 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[Lldb-commits] [PATCH] D47062: Suggest lldb-dotest to reproduce a failure.

davide added a comment. Can you commit the whitespace fixes separately? Repository: rL LLVM https://reviews.llvm.org/D47062 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D47232: Break dependency from Expression -> Commands

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Looks fine to me, but let's wait for Pavel. Are you back working on lldb ? :) https://reviews.llvm.org/D47232 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D48084: [FileSpec] Delegate common operations to llvm::sys::path

davide accepted this revision. davide added a comment. LGTM with a nit. Comment at: source/Utility/FileSpec.cpp:18-21 +#include "llvm/ADT/Triple.h" // for Triple +#include "llvm/ADT/Twine.h" // for Twine +#include "llvm/Support/ErrorOr.h" // for ErrorOr #include "ll

[Lldb-commits] [PATCH] D48096: Disable warnings for the generated LLDB wrapper source

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Unfortunate, but this seems reasonable. lg. https://reviews.llvm.org/D48096 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://list

[Lldb-commits] [PATCH] D48114: Add dataformatter for NSDecimalNumber

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. I didn't check whether the representation was correct (although it looks lo). The structure of the patch looks fine to me, thanks for adding the comments :) Repository: rL LLVM https://rev

[Lldb-commits] [PATCH] D48450: [DataFormatter] Add CFDictionary data formatter

davide added a comment. LGTM. Repository: rL LLVM https://reviews.llvm.org/D48450 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D48500: [DWARFASTParser] Remove special cases for `llvm-gcc`

davide created this revision. davide added reviewers: friss, aprantl, clayborg, labath. Herald added a subscriber: JDevlieghere. To the best of my understanding modern compilers handle all these cases correctly. So, I think this is basically dead code. https://reviews.llvm.org/D48500 Files:

[Lldb-commits] [PATCH] D48500: [DWARFASTParser] Remove special cases for `llvm-gcc`

davide added a comment. I think it's fair and correct supporting everything we can, but I guess `llvm-gcc` is largely dead at this point. https://reviews.llvm.org/D48500 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.or

[Lldb-commits] [PATCH] D48704: [LLDB] Fix for "Bug 37950: ExecutionContext::GetByteOrder() always returns endian::InlHostByteOrder()"

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. Can you write a unittest for this? Thanks. https://reviews.llvm.org/D48704 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D49110: [testsuite] Implement a category to skip libstdcxx tests

davide created this revision. davide added a reviewer: labath. Herald added a subscriber: krytarowski. On systems where it's not supported. As far as I understand Linux is the only systems which now ships with libstdcxx (maybe NetBSD?, but I'm not entirely sure of the state of lldb on the platfor

[Lldb-commits] [PATCH] D49110: [testsuite] Implement a category to skip libstdcxx tests

davide added a comment. @labath this is breaking several bots for us internally so I would really love to get this in. As this seems to be reasonably close to what you ask, I might consider checking this in before end of day (PST) today and we can iterate from there. https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D49110: [testsuite] Implement a category to skip libstdcxx tests

davide added a comment. Thank you Pavel! https://reviews.llvm.org/D49110 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49110: [testsuite] Implement a category to skip libstdcxx tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL336724: [testsuite] Implement a category to skip libstdcxx tests (authored by davide, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D49110?vs

[Lldb-commits] [PATCH] D49155: [IRInterpreter] Fix misevaluation of interpretation expressions with `urem`

davide created this revision. davide added reviewers: jingham, jasonmolenda, friss. `Scalar::MakeUnsigned` was implemented incorrectly so it didn't really change the sign of the type (leaving signed types signed). This showed up as a misevaluation when IR-interpreting `urem` but it's likely to a

[Lldb-commits] [PATCH] D49155: [IRInterpreter] Fix misevaluation of interpretation expressions with `urem`

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Ack'ed by Jim offline. https://reviews.llvm.org/D49155 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [PATCH] D49155: [IRInterpreter] Fix misevaluation of interpretation expressions with `urem`

This revision was automatically updated to reflect the committed changes. Closed by commit rL336872: [IRInterpreter] Fix misevaluation of interpretation expressions with `urem`. (authored by davide, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

davide added a comment. Some comments. Jonas looked at many formatters recently so he's in a good position to take a look. Comment at: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/optional/Makefile:9 +CXXFLAGS += -std=c++17 +#CFLAGS

[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

davide added a comment. This is getting really close. Please try the `lldbInline` test format and revert the unrelated bits and I'll take another look. Thanks! Comment at: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:971-972 g_formatters.push_back([](lldb_priv

[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. Probably last round of comments. Thanks for your patience! Comment at: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/opti

[Lldb-commits] [PATCH] D48351: Move dumping code out of RegisterValue class

davide added a comment. I guess this is fine. @jingham? https://reviews.llvm.org/D48351 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49612: Use LLVM's new ItaniumPartialDemangler in LLDB

davide added a comment. Thanks for doing this. We may consider doing some A-B testing between the two demanglers. A strategy that worked very well for similar purposes was that of running `nm` on a large executable (e.g. clang or lldb itself) and see whether we demangle in the same exact way and

[Lldb-commits] [PATCH] D49695: [cmake] Remove unused ${LLDB_PLUGINS} dependency from our Objective-C++ CMake config

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D49695 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. This is good, but please add a comment explaining the type before committing. https://reviews.llvm.org/D49271 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D49708: Added unit test for StreamTee

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. lg. You probably don't need pre-commit reviews for adding tests. This is obvious goodness. https://reviews.llvm.org/D49708 ___ lldb-commits mail

[Lldb-commits] [PATCH] D49322: Narrow the CompletionRequest API to being append-only.

davide added inline comments. Comment at: source/Commands/CommandCompletions.cpp:251-261 request.SetWordComplete(false); StandardTildeExpressionResolver Resolver; - return DiskDirectories(request.GetCursorArgumentPrefix(), - request.GetMatches(), Re

[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

This revision was automatically updated to reflect the committed changes. Closed by commit rL337959: [DataFormatters] Add formatter for C++17 std::optional. (authored by davide, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D49271?vs=

[Lldb-commits] [PATCH] D49866: Fix duplicate suggestions after an ambiguous command

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LG. thanks for improving the interface, I think all these cleanups are really good. https://reviews.llvm.org/D49866 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D49322: Narrow the CompletionRequest API to being append-only.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Although I'm not entirely sure whether this is safe (as in, it doesn't break anything), it's probably not worth to block this further. My understanding is that Raphael did a bunch of testing a

[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

davide added a comment. Your latest update doesn't contain CMakeList.txt files and the Xcode project changes. That's why it failed to apply. Please upload a correct version and I'll commit it for you. Repository: rL LLVM https://reviews.llvm.org/D49271 ___

[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

davide added a comment. Recommitted: a11963323fc Recommit [DataFormatters] Add formatter for C++17 std::optional. Authentication realm: https://llvm.org:443 LLVM Subversion repository Password for 'davide': *** Sendinglldb/trunk/lldb.xcodeproj/project.pbxproj Adding lldb/

[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

davide added a comment. I'm afraid I had to revert this again. It broke an ubuntu lldb-cmake bot which builds with clang-3.5 (which has no `-std=c++17` support flag, as 17 wasn't there yet). I'd recommend to update this patch with another decorator to skip places where `-std=c++17` is not avai

[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

davide added a comment. Bot logs for completeness: Session logs for test failures/errors/unexpected successes will go into directory 'logs-clang-3.5-i386' Command invoked: /lldb-buildbot/lldbSlave/buildWorkingDir/scripts/../llvm/tools/lldb/test/dotest.py -A i386 -C clang-3.5 -v -s logs-cla

[Lldb-commits] [PATCH] D50026: Remove Stream::UnitTest

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D50026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [PATCH] D48500: [DWARFASTParser] Remove special cases for `llvm-gcc`

This revision was automatically updated to reflect the committed changes. Closed by commit rL338638: [DWARFASTParser] Remove special cases for `llvm-gcc` (authored by davide, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D48500?vs=152

[Lldb-commits] [PATCH] D50192: Fix: ClangHighlighter.cpp should not be in CopyFiles, but in lldb-core targets

davide added a comment. My understanding is that @t.p.northover just committed the same patch. https://reviews.llvm.org/D50192 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D50317: Remove duplicated code in CommandObjectQuit

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Sure. Repository: rLLDB LLDB https://reviews.llvm.org/D50317 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/c

[Lldb-commits] [PATCH] D50271: [IRMemoryMap] Shrink Allocation make it move-only (NFC)

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Looks reasonable to me. https://reviews.llvm.org/D50271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[Lldb-commits] [PATCH] D50677: Remove manual byte counting from Opcode::Dump

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. Repository: rLLDB LLDB https://reviews.llvm.org/D50677 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/c

[Lldb-commits] [PATCH] D51319: Use a RAII guard to control access to DisassemblerLLVMC.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM if Vedant is happy with this. https://reviews.llvm.org/D51319 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.or

[Lldb-commits] [PATCH] D51374: [LLDB] Fix script to work with GNU sed

davide added a comment. LGTM Repository: rLLDB LLDB https://reviews.llvm.org/D51374 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D51557: Replace uses of LazyBool with LazyBool template

davide added inline comments. Comment at: include/lldb/DataFormatters/ValueObjectPrinter.h:146 + +#define LLDB_VOP ValueObjectPrinter + LazyBoolMember m_should_print; can you typedef? Repository: rLLDB LLDB https://reviews.llvm.org/D51557 ___

[Lldb-commits] [PATCH] D51557: Replace uses of LazyBool with LazyBool template

davide added a comment. I agree. Repository: rLLDB LLDB https://reviews.llvm.org/D51557 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D51816: Fix raw address breakpoints not resolving

davide added a comment. Can you add a test for this behavior? Repository: rLLDB LLDB https://reviews.llvm.org/D51816 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D51930: Add a basic test for 'memory region'

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. I thought Vedant added an harness utility to test memory a bit ago. Have you looked into whether that's extensible for your purposes, Raphael? Repository: rLLDB LLDB https://revi

[Lldb-commits] [PATCH] D51930: Add a basic test for 'memory region'

davide added a comment. Yeah, that's the revision I had in mind. Can't you extend `lldb-test` to do what you need? Repository: rLLDB LLDB https://reviews.llvm.org/D51930 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

[Lldb-commits] [PATCH] D51930: Add a basic test for 'memory region'

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Yeah, sure :) Repository: rLLDB LLDB https://reviews.llvm.org/D51930 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.ll

[Lldb-commits] [PATCH] D51999: build: add libedit to include paths

davide added a comment. How exactly are you building (i.e. what triggers this error)? Repository: rLLDB LLDB https://reviews.llvm.org/D51999 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[Lldb-commits] [PATCH] D52247: Refactor FindVariable() core functionality into StackFrame out of SBFrame

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM modulo minor. Comment at: source/Target/StackFrame.cpp:1733-1738 +if (sc.block->AppendVariables( +can_create, get_parent_variables, stop_if_block_is_inl

[Lldb-commits] [PATCH] D52247: Refactor FindVariable() core functionality into StackFrame out of SBFrame

davide added inline comments. Comment at: include/lldb/Target/StackFrame.h:506-507 + lldb::ValueObjectSP FindVariable(const char *name); + //-- Also, I think you might want to add a doxygen com

[Lldb-commits] [PATCH] D52247: Refactor FindVariable() core functionality into StackFrame out of SBFrame

davide accepted this revision. davide added a comment. Sure. https://reviews.llvm.org/D52247 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D39689: Add a dependency from check-lldb on lld

davide added a subscriber: zturner. davide added a comment. Not sure lld is the default? I think I always build with bfd (or gold). I'll check later today when I'm in the office. I'm not against this change per se, but adding another dependency seems annoying. cc: @zturner https://reviews.llvm.

[Lldb-commits] [PATCH] D40519: Remove some duplicated code in UUID.cpp

davide accepted this revision. davide added a comment. LGTM https://reviews.llvm.org/D40519 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D40536: Simplify UUID constructors

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D40536 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [PATCH] D40537: Simplify UUID::IsValid()

davide added a comment. Yes, what Zachary said. Thanks for the cleanup. There's a decent amount of code in lldb that can be written in a very compact way but it's manually unrolled. I think in this case the code produced should be equivalent (and if not, I'd be curious to see the codegen). More

[Lldb-commits] [PATCH] D40539: Allow using the object file name for debug symbol resolution

davide added subscribers: vsk, aprantl, davide. davide added a comment. I thought about this, and it's the only patch from your patchset that I don't feel really confident about. I'm afraid it's a little risky to add more code to the objectfile reader without having proper unittesting. In partic

[Lldb-commits] [PATCH] D40616: ObjectFileELF: Add support for compressed sections

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. This one is a little weird when written as unittest. Not the worst thing, but I agree it should use `llvm-lit`. Can you give it a shot, Pavel? If that doesn't work, we should at least

[Lldb-commits] [PATCH] D40616: ObjectFileELF: Add support for compressed sections

davide added a comment. Another very good reason for writing a `FileCheck` test rather than a unittest is that writing unittest is tedious :) In particular for new contributors, FileCheck tests are much easier to write and in this case testing the API surface doesn't seem to add much value. ht

[Lldb-commits] [PATCH] D40475: DWZ 12/12: DWZ test mode

davide added a comment. @jankratochvil I run Fedora for now on my desktop, but I don't have time and resources to devote to a buildbot. IMHO, having a fedora bot would be a great thing for two reasons: 1. I found out Fedora exposes bugs that ubuntu doesn't (e.g. in symbol resolution, due to sli

[Lldb-commits] [PATCH] D40636: Create a trivial lldb-test program

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. This LGTM. I think we can iterate in tree from what we have. https://reviews.llvm.org/D40636 ___ lldb-commits mailing list lldb-commits@lists.llv

  1   2   3   4   5   6   >