[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Instruction/LoongArch/EmulateInstructionLoongArch.cpp:287 + uint32_t rj = Bits32(inst, 9, 5); + uint64_t rj_val; + uint64_t pc = ReadPC(&success); I would declare this where it is assigned.

[Lldb-commits] [PATCH] D140032: [LLDB][RISCV] Add RVD instruction support for EmulateInstructionRISCV

DavidSpickett added a comment. > Are we going to use C++20 or something else? But I see the function > transform() we need was introduced in C++23. Good point, it would be c++20. If you want to look into the status of the switchover feel free, but you can leave them as llvm::Optional for now.

[Lldb-commits] [PATCH] D140092: [NFC] Using namespace llvm in EmulateInstructionRISCV

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140092/new/ https://reviews.llvm.org/D140092 _

[Lldb-commits] [PATCH] D140092: [NFC] Using namespace llvm in EmulateInstructionRISCV

DavidSpickett added a comment. Please tag [LLDB] in the commit title. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140092/new/ https://reviews.llvm.org/D140092 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D140032: [LLDB][RISCV] Add RVD instruction support for EmulateInstructionRISCV

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Instruction/RISCV/EmulateInstructionRISCV.cpp:1452 [&](auto &&rs1) { - APFloat apf(APFloat::IEEEsingle(), rs1); + APFloa

[Lldb-commits] [PATCH] D140032: [LLDB][RISCV] Add RVD instruction support for EmulateInstructionRISCV

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140032/new/ https://reviews.llvm.org/D140032 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D140032: [LLDB][RISCV] Add RVD instruction support for EmulateInstructionRISCV

DavidSpickett added a comment. > Good point, it would be c++20. C++17 rather. People have been testing building with 20 but 17 is the standard for llvm right now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140032/new/ https://reviews.llvm.org/D140032 __

[Lldb-commits] [PATCH] D140051: [lldb] Add LTO dependency to lldb test suite

DavidSpickett added a comment. Sorry I should have been specific. With this change applied, when you don't have LTO, we'll just skip the individual test, or we'll not do testing at all? Wondering if this is an all or nothing situation, which would be unfortunate for a single test. Repository:

[Lldb-commits] [PATCH] D140051: [lldb] Add LTO dependency to lldb test suite

DavidSpickett added a comment. Well that was my confusion, no there isn't an option. So how does one end up with a build that doesn't include it. Perhaps a standalone build of lldb, built with a prebuilt llvm that didn't package libLTO? Which sounds perfectly legitimate and the test should be s

[Lldb-commits] [PATCH] D136938: [LLDB] Fix code breakpoints on tagged addresses

DavidSpickett added a comment. Completely forgot about this, ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136938/new/ https://reviews.llvm.org/D136938 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D140051: [lldb] Add LTO dependency to lldb test suite

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. > If you just run ninja check-lldb prior to this patch libLTO would not be > built. Great, put that in the commit message. What I was trying to get at was the meaning of depends

[Lldb-commits] [PATCH] D136938: [LLDB] Fix code breakpoints on tagged addresses

DavidSpickett added a comment. > What do you think about locating this change in ToAddress instead of > Target::GetBreakableLoadAddress? It looks like the one caller to > GetBreakableLoadAddress is Target::CreateBreakpoint(addr_t addr) - which is > probably called by an SBTarget method if we wa

[Lldb-commits] [PATCH] D136938: [LLDB] Fix code breakpoints on tagged addresses

DavidSpickett planned changes to this revision. DavidSpickett added a comment. > I can't test it on macOS platforms because the bots won't be able to build & > run arm64e (ARMv8.3 w/ ptrauth) binaries. :/ Well our bots can't either but I've got QEMU locally is what I mean. We can run top byte i

[Lldb-commits] [PATCH] D140368: [lldb] Consider all breakpoints in breakpoint detection

DavidSpickett added a reviewer: jingham. DavidSpickett added a subscriber: jingham. DavidSpickett added a comment. The intent makes sense. We should stop and report user breakpoints triggered while trying to execute some internal stepping plan, even if they overlap what lldb was planning to do i

[Lldb-commits] [PATCH] D140385: [lldb] Add lldb-server targets to build docs

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The current doc has people just do "ninja lldb" which is not incorrect, it does build lldb. However it does not

[Lldb-commits] [PATCH] D140385: [lldb] Add lldb-server targets to build docs

DavidSpickett added a reviewer: JDevlieghere. DavidSpickett added a comment. Current page: https://lldb.llvm.org/resources/build.html Github issue: https://github.com/llvm/llvm-project/issues/59575 This works for Linux but I don't know what happens on Mac OS. Would the equivalent be `ninja lldb

[Lldb-commits] [PATCH] D140386: [LLDB][LoongArch] Add FP branch instructions for EmulateInstructionLoongArch

DavidSpickett added a comment. Please split this patch into 2: - the cleanup of the existing branch instructions - the addition of the new ones The changes look good but let's keep each commit to doing 1 thing. You are missing tests though, and this is my mistake for not asking for them in the

[Lldb-commits] [PATCH] D140615: [LLDB][LoongArch] Delete the s9 register alias definition

DavidSpickett accepted this revision. DavidSpickett added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140615/new/ https://reviews.llvm.org/D140615 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D140386: [LLDB][LoongArch] Add unittests for EmulateInstructionLoongArch

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140386/new/ https://reviews.llvm.org/D140386 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D141245: [LLDB][LoongArch] ObjectFile: add a case for `EM_LOONGARCH`

DavidSpickett accepted this revision. DavidSpickett added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141245/new/ https://reviews.llvm.org/D141245 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D140759: [LLDB][LoongArch] Add FP branch instructions for EmulateInstructionLoongArch

DavidSpickett accepted this revision. DavidSpickett added a comment. Thanks for adding the testing in earlier patches. At this point my review isn't adding much value and @SixWeining has the ISA details covered. So changes like this can go in without extra approval in future unless there is som

[Lldb-commits] [PATCH] D138197: [lldb] Fix bitfield incorrectly printing when field crosses a storage unit

DavidSpickett added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138197/new/ https://reviews.llvm.org/D138197 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D136928: [LLDB] Fix help text for "platform settings"

DavidSpickett added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136928/new/ https://reviews.llvm.org/D136928 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D140385: [lldb] Add lldb-server targets to build docs

This revision was automatically updated to reflect the committed changes. Closed by commit rG3fa023970daf: [lldb] Add lldb-server targets to build docs (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140385/new/ https://re

[Lldb-commits] [PATCH] D141687: [LLDB] Remove return value from DumpRegisterValue

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. No one ever checks it. Also convert to early return. Repository: rG LLVM Github Monorepo https://reviews.ll

[Lldb-commits] [PATCH] D136928: [LLDB] Fix help text for "platform settings"

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8e4eb1043f4: [LLDB] Fix help text for "platform settings" (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136928/new/ https://re

[Lldb-commits] [PATCH] D141629: Run address expression argument values through ABI::FixCodeAddress to strip TBI/pointer auth bytes on AArch64

DavidSpickett added a comment. I am looking at this, just taking some time to get a PAC enabled environment going again. At first glance it seems like a better way to do things. I just want to run the test from my patch against this one. I can port the test to AArch64 Linux though that's not mu

[Lldb-commits] [PATCH] D141687: [LLDB] Remove return value from DumpRegisterValue

This revision was automatically updated to reflect the committed changes. Closed by commit rGae361d3d90a8: [LLDB] Remove return value from DumpRegisterValue (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141687/new/ https

[Lldb-commits] [PATCH] D140624: [LLDB] Fixes summary formatter for libc++ map allowing modification of contained value

DavidSpickett closed this revision. DavidSpickett added a comment. The fix worked - https://lab.llvm.org/buildbot/#/builders/17/builds/33176 Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140624/new/ https://reviews.llvm.org/D140624 __

[Lldb-commits] [PATCH] D141828: [lldb] Add support for DW_AT_default_value in template params

DavidSpickett added a comment. I've reverted this due to test failures on Arm and AArch64. They were obscured by the build failure so once you'd fixed that the bot was silent about it. Here's one of the builds: https://lab.llvm.org/buildbot/#/builders/96/builds/34718 SymbolFileDWARFTests: .

[Lldb-commits] [PATCH] D141828: [lldb] Add support for DW_AT_default_value in template params

DavidSpickett added a comment. It appears that they passed on Windows, could be a Linux only issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141828/new/ https://reviews.llvm.org/D141828 ___ lldb-com

[Lldb-commits] [PATCH] D142715: [LLDB] Apply FixCodeAddress to all forms of address arguments

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is a follow up to https://reviews.llvm.org/D141629 and applies th

[Lldb-commits] [PATCH] D142715: [LLDB] Apply FixCodeAddress to all forms of address arguments

DavidSpickett added reviewers: JDevlieghere, jasonmolenda. DavidSpickett added a comment. Apologies it took me so long to get around to this. As a superset of your change I presume the test you added will still pass. I don't have a Mac to confirm that myself. Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D142792: Add SBValue::GetValueAsAddress(), strip off ptrauth, TBI, MTE bits on AArch64 systems

DavidSpickett added a comment. > Script authors may want access to both the actual uint64_t value, and the > address that will be accessed, in an SBValue, so I added a new method in > addition to GetValueAsUnsigned to provide this. In my rough cut of API stuff for memory tagging I had: frame

[Lldb-commits] [PATCH] D136938: [LLDB] Fix code breakpoints on tagged addresses

DavidSpickett abandoned this revision. DavidSpickett added a comment. Superseded by https://reviews.llvm.org/D141629. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136938/new/ https://reviews.llvm.org/D136938 __

[Lldb-commits] [PATCH] D143215: Separate Process::GetWatchpointSupportInfo into two methods to get the two separate pieces of information

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. I like removing a return by ref and being explicit about what info is wanted where. So say the stub reports the "watchpoints received" but not the number of slots. Does lldb just send the watchpoint set packets and re

[Lldb-commits] [PATCH] D143215: Separate Process::GetWatchpointSupportInfo into two methods to get the two separate pieces of information

DavidSpickett added a comment. > Change lldb from depending on the remote gdb stub to tell it whether > watchpoints are received before or after the instruction, to knowing the > architectures where watchpoint exceptions are received before the instruction > executes, and allow the remote gdb s

[Lldb-commits] [PATCH] D142715: [LLDB] Apply FixCodeAddress to all forms of address arguments

DavidSpickett added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142715/new/ https://reviews.llvm.org/D142715 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D143215: Separate Process::GetWatchpointSupportInfo into two methods to get the two separate pieces of information

DavidSpickett added a subscriber: Emmmer. DavidSpickett added inline comments. Comment at: lldb/source/Target/Process.cpp:2373 +reported_after = false; + return reported_after; +} DavidSpickett wrote: > Would this be any clearer with multiple returns? Or one

[Lldb-commits] [PATCH] D143564: [LLDB] Add missing newline to "image lookup" output

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When using --name, due to a missing newline, multiple symbol results were not correctly printed: (lldb) image

[Lldb-commits] [PATCH] D143215: lldb can know architecture-dependent watchpoint behaviors, instead of depending on the remote stub

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. One minor comment otherwise LGTM. `[LLDB]` tag in the commit title please :) Comment at: lldb/source/Target/Process.cpp:2371 + if (triple.isAArch64() || tripl

[Lldb-commits] [PATCH] D143564: [LLDB] Add missing newline to "image lookup" output

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a4e9ccb2c6f: [LLDB] Add missing newline to "image lookup" output (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143564/new/ htt

[Lldb-commits] [PATCH] D143727: [Test][lldb] Fix YAML mapping keys duplication. NFC.

DavidSpickett accepted this revision. DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143727/new/ https://reviews.llvm.org/D143727 __

[Lldb-commits] [PATCH] D142715: [LLDB] Apply FixCodeAddress to all forms of address arguments

DavidSpickett updated this revision to Diff 496877. DavidSpickett added a comment. Address Jonas' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142715/new/ https://reviews.llvm.org/D142715 Files: lldb/include/lldb/Interpreter/OptionArg

[Lldb-commits] [PATCH] D142715: [LLDB] Apply FixCodeAddress to all forms of address arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rGe6ec76c647aa: [LLDB] Apply FixCodeAddress to all forms of address arguments (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142715

[Lldb-commits] [PATCH] D142792: Add SBValue::GetValueAsAddress(), strip off ptrauth, TBI, MTE bits on AArch64 systems

DavidSpickett added a comment. Looking good, one question left on the test file. Comment at: lldb/source/API/SBValue.cpp:936 + if (ABISP abi_sp = process_sp->GetABI()) +return abi_sp->FixCodeAddress(ret_val); +return ret_val; jasonmolenda wrote

[Lldb-commits] [PATCH] D138197: [lldb] Fix bitfield incorrectly printing when field crosses a storage unit

DavidSpickett added a comment. Note that this fixes https://github.com/llvm/llvm-project/issues/58769 in the commit message ("fixes #"). Also ping again! If you don't have the time to work on this in the near future, perhaps I can do the finishing touches and get it in (with you as co-author)?

[Lldb-commits] [PATCH] D144390: [lldb] Send QPassSignals packet on attach, and at start for remote platforms

DavidSpickett added a comment. What is the practical impact of the bug you are fixing? I guess it is something like if you set signal handling info, then attach to something, that info is not used. Until you set it again, then it'll be sent and used. Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D144904: [Linux] Add kernel.yama.ptrace_scope note when ptrace fails to attach.

DavidSpickett added inline comments. Comment at: lldb/unittests/Process/Linux/ProcfsTests.cpp:113 + + // At this point we shouldn't fail parsing the core ids + Expected ptrace_scope = GetPtraceScope(); What do you mean by core ids? Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D144904: [Linux] Add kernel.yama.ptrace_scope note when ptrace fails to attach.

DavidSpickett added a comment. And testing would require the test to `sudo ...` so I don't think this can be tested. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:235 +std::error_code(errno, std::generic_category()), +"The current value o

[Lldb-commits] [PATCH] D144904: [Linux] Add kernel.yama.ptrace_scope note when ptrace fails to attach.

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:235 +std::error_code(errno, std::generic_category()), +"The current va

[Lldb-commits] [PATCH] D142792: Add SBValue::GetValueAsAddress(), strip off ptrauth, TBI, MTE bits on AArch64 systems

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. 2 minor things otherwise LGTM. Comment at: lldb/test/API/api/clear-sbvalue-nonadressable-bits/TestClearSBValueNonAddressableBits.py:20 +@skipUnlessPlatform

[Lldb-commits] [PATCH] D145377: [LLDB] Show sub type of faults for ELF core files

DavidSpickett created this revision. Herald added subscribers: atanasyan, arichardson, sdardis, emaste. Herald added a project: All. DavidSpickett requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. Previously we only looked a

[Lldb-commits] [PATCH] D145377: [LLDB] Show sub type of signals for ELF core files

DavidSpickett planned changes to this revision. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp:230 + + siginfo_t info; + info.si_signo = m_signo; labath wrote: > I think this won't work on Windows (no sig

[Lldb-commits] [PATCH] D145450: [lldb] Respect empty arguments in target.run-args

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. A bit surprised there wasn't an existing test to just add an extra argument to, but looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D145462: [LLDB][ObjectFileELF] Support LoongArch64 in ApplyReloctions

DavidSpickett added a comment. I see from `/usr/include/elf.h` on my system that the numbers do restart for each architecture. We got away with it for the set of relocations we were looking at. I like the new structure, it is clearer especially for the signed checks. I presume the definitions

[Lldb-commits] [PATCH] D145462: [LLDB][ObjectFileELF] Support LoongArch64 in ApplyReloctions

DavidSpickett added inline comments. Comment at: lldb/test/Shell/ObjectFile/ELF/loongarch64-relocations.yaml:10 +# CHECK-NEXT: ) + +--- !ELF Please add a comment to explain briefly how this proves the relocations are being processed. As it is I don't see how the

[Lldb-commits] [PATCH] D145462: [LLDB][ObjectFileELF] Support LoongArch64 in ApplyReloctions

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2623 +(is_signed && + ((int64_t)value > INT32_MAX && (int64_t)value < INT

[Lldb-commits] [PATCH] D145550: [LLDB][ObjectFileELF] Correct the return type of RelocOffset64 and RelocAddend64

DavidSpickett added a comment. Seems to me that member functions of `ELFRelocation` should use the typedefs from `lldb/source/Plugins/ObjectFile/ELF/ELFHeader.h` where there is one. `elf_sxword` for example. If you want to do that in another patch, that's fine. Just in case some test case is r

[Lldb-commits] [PATCH] D145559: [lldb] Remove unused POSIX ProcessMessage files

DavidSpickett created this revision. Herald added a subscriber: emaste. Herald added a project: All. DavidSpickett requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. The last use of these was removed in cd443398566b953642ead7

[Lldb-commits] [PATCH] D145550: [LLDB][ObjectFileELF] Correct the return type of RelocOffset64 and RelocAddend64

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145550/new/ https://reviews.llvm.org/D145550

[Lldb-commits] [PATCH] D145561: [lldb] Remove unused CrashReasonAsString function

DavidSpickett created this revision. Herald added a subscriber: emaste. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The last user was ProcessMessage, which has itself been removed. Repository

[Lldb-commits] [PATCH] D145377: [LLDB] Show sub type of signals for ELF core files

DavidSpickett updated this revision to Diff 503274. DavidSpickett added a comment. Add code functionality to UnixSignals instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145377/new/ https://reviews.llvm.org/D145377 Files: lldb/include/lldb

[Lldb-commits] [PATCH] D145377: [LLDB] Show sub type of memory tagging SEGV when reading a core file

DavidSpickett added a comment. This should build anywhere now. I looked at `thread siginfo` and I see what you mean, but it'll take me some time to confirm exactly how much of siginfo is in the core file. I did get it to work using the full type, but I'm pretty sure some of the values were inv

[Lldb-commits] [PATCH] D145566: [lldb] Add RegisterFlags class

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This models the "flags" node from GDB's target XML: https://sourceware

[Lldb-commits] [PATCH] D145571: [LLDB][ObjectFileELF] Correct the return type of Reloc{Offset, Addend}32

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145571/new/ https://reviews.llvm.org/D145571 __

[Lldb-commits] [PATCH] D145574: [lldb] Read register fields from target XML

DavidSpickett created this revision. Herald added a subscriber: mgrang. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This teaches ProcessGDBRemote to look for "flags" nodes in the target XML tha

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett created this revision. Herald added subscribers: ChuanqiXu, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. This change uses the information from targ

[Lldb-commits] [PATCH] D145574: [lldb] Read register fields from target XML

DavidSpickett added a comment. Tests are added in https://reviews.llvm.org/D145580, because they use the formatting code added there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145574/new/ https://reviews.llvm.org/D145574 _

[Lldb-commits] [PATCH] D145559: [lldb] Remove unused POSIX ProcessMessage files

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fe114428551: [lldb] Remove unused POSIX ProcessMessage files (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145559/new/ https:/

[Lldb-commits] [PATCH] D145561: [lldb] Remove unused CrashReasonAsString function

This revision was automatically updated to reflect the committed changes. Closed by commit rGb7217a8fc94d: [lldb] Remove unused CrashReasonAsString function (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145561/new/ https

[Lldb-commits] [PATCH] D145566: [lldb] Add RegisterFlags class

DavidSpickett added inline comments. Comment at: lldb/include/lldb/Target/RegisterFlags.h:20 + public: +Field(const std::string &name, unsigned start, unsigned end, + const std::string &type) tschuett wrote: > There are a lot of `const std::string&

[Lldb-commits] [PATCH] D145566: [lldb] Add RegisterFlags class

DavidSpickett added inline comments. Comment at: lldb/include/lldb/Target/RegisterFlags.h:20 + public: +Field(const std::string &name, unsigned start, unsigned end, + const std::string &type) DavidSpickett wrote: > tschuett wrote: > > There are a lo

[Lldb-commits] [PATCH] D145566: [lldb] Add RegisterFlags class

DavidSpickett updated this revision to Diff 503374. DavidSpickett added a comment. Use StringRef for parameters. This is what the XML parser gives you by default in any case. Internally we want to keep a copy of the string because the XML document will go away after parsing. Repository: rG LL

[Lldb-commits] [PATCH] D145574: [lldb] Read register fields from target XML

DavidSpickett updated this revision to Diff 503376. DavidSpickett added a comment. Use StringRef instead of std::string. Though an empty StringRef is morally equivalent to optional, I've stuck with optional to keep the code looking consistent. Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett updated this revision to Diff 503377. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145580/new/ https://reviews.llvm.org/D145580 Files: lldb/include/lldb/Core/DumpRegisterValue.h lldb/include

[Lldb-commits] [PATCH] D145566: [lldb] Add RegisterFlags class

DavidSpickett updated this revision to Diff 503378. DavidSpickett marked an inline comment as done. DavidSpickett added a comment. Add newline at end of file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145566/new/ https://reviews.llvm.org/D14556

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett updated this revision to Diff 503379. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145580/new/ https://reviews.llvm.org/D145580 Files: lldb/include/lldb/Core/DumpRegisterValue.h lldb/include

[Lldb-commits] [PATCH] D145377: [LLDB] Show sub type of memory tagging SEGV when reading a core file

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:32 + AddSignalCode(11, 8 /*SEGV_MTEAERR*/, "async tag check fault"); + AddSignalCode(11, 9 /*SEGV_MTESERR*/, "sync tag check fault"); AddSignal(12, "SIGUSR2", false

[Lldb-commits] [PATCH] D145566: [lldb] Add RegisterFlags class

DavidSpickett updated this revision to Diff 504104. DavidSpickett added a comment. Fix typo, remove `m_type` which is not used by the following patches. We could use it down the road, but we can also just guess that single bit fields are bools and anything else is a number. So we don't lose much.

[Lldb-commits] [PATCH] D145574: [lldb] Read register fields from target XML

DavidSpickett updated this revision to Diff 504106. DavidSpickett added a comment. Remove use of type attribute on flags. We will recognise it as valid, but do nothing with it as it's not needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145574/

[Lldb-commits] [PATCH] D145574: [lldb] Read register fields from target XML

DavidSpickett updated this revision to Diff 504107. DavidSpickett added a comment. Correct printf for `unsigned`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145574/new/ https://reviews.llvm.org/D145574 Files: lldb/include/lldb/Target/DynamicR

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett updated this revision to Diff 504109. DavidSpickett added a comment. - Rebase - Add a test to show the register fields respect the child limit setting. - Make sure alignment is correct both when printed as one line and multiple. - Correct indentation in test file so it's all 4 space

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett added a comment. The last update changes the format slightly, though for the better I think. (lldb) register read cpsr x0 fpcr fpsr x1 cpsr = 0x60001000 = (N = 0, Z = 1, C = 1, V = 0, TCO = 0, DIT = 0, UAO = 0, PAN = 0, SS = 0, IL = 0, SSBS = 1, BTYPE = 0, D = 0,

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett added a comment. > This all looks good to me. the phab says there's a missing newline at the end > of TestXMLRegisterFlags.py. Fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145580/new/ https://reviews.llvm.org/D145580 __

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett updated this revision to Diff 504140. DavidSpickett added a comment. Remove need for aarch64 yaml file in tests. Refactor the responders. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145580/new/ https://reviews.llvm.org/D145580 File

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett added a comment. I'm trying to get an s390x test going in the same fashion but figuring it out is tricky. Also, I realise that all this XML substitution with strings is very brittle. I want to replace that with Python's xml.etree but will do that later in another patch. Reposit

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett updated this revision to Diff 504583. DavidSpickett added a comment. Add an s390x test for big endian byte ordering. Turns out you can fake AArch64 without the backend, but not s390x. Luckily, s390x is a default backend. So the LE host -> BE target part will be tested widely. BE to

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett added a comment. > If this skip is really needed, then I don't know how many people would > exercise an s390x test even if it was added - I don't personally build with > that target normally. This is now resolved. No skip needed for AArch64, but for whatever reason, it is needed

[Lldb-commits] [PATCH] D145940: [lldb] Add test for unavailable registers

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Prior to this the only check was that we did not print this message when reading registers that should exist. I

[Lldb-commits] [PATCH] D145940: [lldb] Add test for unavailable registers

DavidSpickett added inline comments. Comment at: lldb/test/API/commands/register/register/TestRegistersUnavailable.py:57 +"other:\n" +"1 registers were unavailable."]) The only difference here if you have the x86 backend vs. not, is that

[Lldb-commits] [PATCH] D145950: [lldb] Remove MipsLinuxSignals

DavidSpickett created this revision. Herald added subscribers: atanasyan, jrtc27, arichardson, sdardis. Herald added a project: All. DavidSpickett requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. Support for Linux MIPS debu

[Lldb-commits] [PATCH] D145950: [lldb] Remove MipsLinuxSignals

DavidSpickett added a reviewer: labath. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. One less set of signals I need to update to merge CrashReason into UnixSignals. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145950/new/

[Lldb-commits] [PATCH] D145377: [LLDB] Show sub type of memory tagging SEGV when reading a core file

DavidSpickett planned changes to this revision. DavidSpickett added a comment. I'm working on merging CrashReason into UnixSignals, so this will either be part of, or on top of that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145377/new/ https:

[Lldb-commits] [PATCH] D145950: [lldb] Remove MipsLinuxSignals

DavidSpickett abandoned this revision. DavidSpickett added a comment. Someone else had the same idea: https://github.com/llvm/llvm-project/commit/93a455375c0fa1dd014a3b4571b22e307d15bbf7 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145950/new/ ht

[Lldb-commits] [PATCH] D145377: [LLDB] Show sub type of memory tagging SEGV when reading a core file

DavidSpickett abandoned this revision. DavidSpickett added a comment. This will be back as part of a series. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145377/new/ https://reviews.llvm.org/D145377 ___

[Lldb-commits] [PATCH] D146043: [lldb] Refactor CrashReason

DavidSpickett created this revision. Herald added a subscriber: emaste. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. So that there is only one function that NativeThreads call, which takes a sig

[Lldb-commits] [PATCH] D146044: [lldb] Implement CrashReason using UnixSignals

DavidSpickett created this revision. Herald added subscribers: krytarowski, arichardson, emaste. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. By adding signal codes to UnixSignals and adding a n

[Lldb-commits] [PATCH] D146045: [LLDB] Show sub type of signals when debugging a core file

DavidSpickett created this revision. Herald added subscribers: atanasyan, arichardson, sdardis. Herald added a project: All. DavidSpickett requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. Previously we only looked at the si

[Lldb-commits] [PATCH] D146043: [lldb] Refactor CrashReason

DavidSpickett added reviewers: labath, JDevlieghere. DavidSpickett added a comment. Or in other words "make it look like UnixSignals on the inside". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146043/new/ https://reviews.llvm.org/D146043 ___

<    2   3   4   5   6   7   8   9   10   11   >