[Lldb-commits] [PATCH] D140032: [LLDB][RISCV] Add RVD instruction support for EmulateInstructionRISCV

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added inline comments.


================
Comment at: 
lldb/source/Plugins/Instruction/RISCV/EmulateInstructionRISCV.cpp:1452
                              [&](auto &&rs1) {
-                               APFloat apf(APFloat::IEEEsingle(), rs1);
+                               APFloat apf(semantics(), rs1);
                                return inst.rd.WriteAPFloat(m_emu, apf);
----------------
Can you explain the use of a callback here? At first glance it seems like you 
can just pass a value instead to APFloat.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140032/new/

https://reviews.llvm.org/D140032

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits