DavidSpickett added inline comments.
================ Comment at: lldb/source/Plugins/Instruction/LoongArch/EmulateInstructionLoongArch.cpp:287 + uint32_t rj = Bits32(inst, 9, 5); + uint64_t rj_val; + uint64_t pc = ReadPC(&success); ---------------- I would declare this where it is assigned. The llvm standards don't mandate that but in this case you save a line and IMO, declare as close to use is clearer. Same for `rj`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139833/new/ https://reviews.llvm.org/D139833 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
