DavidSpickett added inline comments.

================
Comment at: lldb/test/Shell/ObjectFile/ELF/loongarch64-relocations.yaml:10
+# CHECK-NEXT: )
+
+--- !ELF
----------------
Please add a comment to explain briefly how this proves the relocations are 
being processed. As it is I don't see how the content of the data section 
proves that any work was done, besides us not crashing.

Or the other way around, if the relocations were not applied what would we see 
here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145462/new/

https://reviews.llvm.org/D145462

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to