DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2623
+ (is_signed &&
+ ((int64_t)value > INT32_MAX && (int64_t)value < INT32_MIN))) {
+ Log *log = GetLog(LLDBLog::Modules);
----------------
SixWeining wrote:
> DavidSpickett wrote:
> > Should this be `||` not `&&`?
> Yes I think so. This should be an error in original code but not introduced
> this time. Do you mind I include the fix in current patch or in a separate
> one?
In this patch is fine.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145462/new/
https://reviews.llvm.org/D145462
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
