[Lldb-commits] [PATCH] D132803: [lldb][test] Speed up lldb arch determination (NFC)

kastiglione added a comment. I did a little cleanup while here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132803/new/ https://reviews.llvm.org/D132803 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D132803: [lldb][test] Speed up lldb arch determination (NFC)

kastiglione added a comment. I wonder if it's worth disabling `target.load-script-from-symbol-file` for all tests as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132803/new/ https://reviews.llvm.org/D132803

[Lldb-commits] [PATCH] D132868: [lldb][test] Enable clang modules in API/tools/lldb-server (NFC)

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, mib, jasonmolenda. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. While investigating slow tests, I noticed that `TestLl

[Lldb-commits] [PATCH] D132803: [lldb][test] Speed up lldb arch determination (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG296f7614edcf: [lldb][test] Speed up lldb arch determination (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132803/new/ https

[Lldb-commits] [PATCH] D132694: [lldb] Quietly source lit-lldb-init

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3172df59c32: [lldb] Quietly source lit-lldb-init (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132694/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D132868: [lldb][test] Enable clang modules in API/tools/lldb-server (NFC)

kastiglione added a comment. The file in question uses c++ headers: lldb/test/API/tools/lldb-server/main.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132868/new/ https://reviews.llvm.org/D132868 ___

[Lldb-commits] [PATCH] D132868: [lldb][test] Enable clang modules in API/tools/lldb-server (NFC)

kastiglione added a comment. I updated the description to remove the mention of `iostream`, since that's not the specific problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132868/new/ https://reviews.llvm.org/D132868

[Lldb-commits] [PATCH] D132868: [lldb][test] Enable clang modules in API/tools/lldb-server (NFC)

kastiglione added a comment. There are a number of Makefiles that use `MANDATORY_MODULE_BUILD_CFLAGS` unconditionally. Given the points made here, how do those test work on linux? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132868/new/ https://r

[Lldb-commits] [PATCH] D133130: [lldb][bindings] Fix module_access handling of regex

kastiglione created this revision. kastiglione added reviewers: mib, JDevlieghere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fixes broken support for: `target.module[re.compile("libFoo")]` The

[Lldb-commits] [PATCH] D133130: [lldb][bindings] Fix module_access handling of regex

kastiglione added a comment. @mib will do Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133130/new/ https://reviews.llvm.org/D133130 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [PATCH] D117383: [lldb] Expose std::pair children for unordered_map

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2ec18ee043f: [lldb] From unordered_map synthetic provider, return std::pair children (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D133130: [lldb][bindings] Fix module_access handling of regex

kastiglione updated this revision to Diff 457804. kastiglione added a comment. Add a test for subscripting a target.modules using regex Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133130/new/ https://reviews.llvm.org/D133130 Files: lldb/bindin

[Lldb-commits] [PATCH] D133130: [lldb][bindings] Fix module_access handling of regex

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG75f05fccbbdd: [lldb][bindings] Fix module_access handling of regex (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [PATCH] D117383: [lldb] Expose std::pair children for unordered_map

kastiglione added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp:74 + if (name.consume_front("std::")) +name.consume_front("__1::"); + return name.consume_front(type) && name.startswith("<"); rsmith wrote: > This

[Lldb-commits] [PATCH] D133259: [lldb] Don't assume name of libc++ inline namespace in LibCxxUnorderedMap

kastiglione created this revision. kastiglione added a reviewer: rsmith. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Follow up to D117383 , fixing the assumption

[Lldb-commits] [PATCH] D117383: [lldb] Expose std::pair children for unordered_map

kastiglione added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp:74 + if (name.consume_front("std::")) +name.consume_front("__1::"); + return name.consume_front(type) && name.startswith("<"); kastiglione wrote: >

[Lldb-commits] [PATCH] D133251: [lldb] [Core] Split read thread support into ThreadedCommunication

kastiglione added a comment. Herald added a subscriber: JDevlieghere. > `CommunicationKDP` is updated in order to (hopefully) compile with the new > code. However, I do not have a Darwin box to test it, so I've limited the > changes to the bare minimum. Compilation fails: /Users/buildslave/

[Lldb-commits] [PATCH] D133365: [lldb] Fix CommunicationKDP following D133251

kastiglione created this revision. kastiglione added reviewers: mgorny, labath, aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add `m_bytes` and `m_bytes_mutex` to `CommunicationKDP`, follo

[Lldb-commits] [PATCH] D133251: [lldb] [Core] Split read thread support into ThreadedCommunication

kastiglione added a comment. I created D133365 , which solves the compilation issue but I don't know whether it's semantically correct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133251/new/ https://reviews.llv

[Lldb-commits] [PATCH] D133365: [lldb] Fix CommunicationKDP following D133251

kastiglione added a comment. Note that these two fields are only used in `CommunicationKDP::CheckForPacket`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133365/new/ https://reviews.llvm.org/D133365 ___

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione created this revision. kastiglione added a reviewer: mib. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix `fullpath` to not assume a `/` path separator. This was discovered when D1331

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione added a comment. Herald added a subscriber: JDevlieghere. will add a test before committing, there was no immediately obvious place for a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.org/D133366

[Lldb-commits] [PATCH] D133365: [lldb] Fix CommunicationKDP following D133251

This revision was automatically updated to reflect the committed changes. Closed by commit rG940704cc585e: [lldb] Fix CommunicationKDP following D133251 (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133365/new/ https://rev

[Lldb-commits] [PATCH] D133365: [lldb] Fix CommunicationKDP following D133251

kastiglione added a comment. thanks for the fast reply Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133365/new/ https://reviews.llvm.org/D133365 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D133259: [lldb] Don't assume name of libc++ inline namespace in LibCxxUnorderedMap

kastiglione added a comment. Thanks for the report about the `__cc`, I can try to come up with something less fragile. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp:76 +auto ident_end = +name.find_if_not([](char c) { return std::isalnum(

[Lldb-commits] [PATCH] D133259: [lldb] Don't assume name of libc++ inline namespace in LibCxxUnorderedMap

kastiglione updated this revision to Diff 458347. kastiglione added a comment. Expect inline namespace to be __[[:alnum:]]+:: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133259/new/ https://reviews.llvm.org/D133259 Files: lldb/source/Plugins/L

[Lldb-commits] [PATCH] D133395: [lldb] Update regex to be less fragile in TestDataFormatterGenericUnordered

kastiglione created this revision. kastiglione added reviewers: mib, rupprecht, jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Follow up to D129386 where

[Lldb-commits] [PATCH] D133259: [lldb] Don't assume name of libc++ inline namespace in LibCxxUnorderedMap

kastiglione added a comment. I updated the test in D133395 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133259/new/ https://reviews.llvm.org/D133259 ___ lldb-commits m

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

kastiglione added a comment. Herald added a reviewer: ributzka. @clayborg friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114288/new/ https://reviews.llvm.org/D114288 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

kastiglione added a comment. SP and UP templates seems fine to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133906/new/ https://reviews.llvm.org/D133906 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [PATCH] D133961: [lldb] Use SWIG_fail in python-typemaps.swig (NFC)

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When attempting to use SWIG's `-builtin` flag, there were a few compile

[Lldb-commits] [PATCH] D134011: [lldb] Fix parentheses placement in GetExpressionPath

kastiglione created this revision. kastiglione added a reviewer: jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Adjust the placement of parentheses around a pointer dereference in `GetExpre

[Lldb-commits] [PATCH] D134011: [lldb] Fix parentheses placement in GetExpressionPath

kastiglione added a comment. I noticed this when running `v *SomeVar` and the variable contained a `llvm::PointerUnion`. The synthetic provider for `PointerUnion` uses `GetExpressionPath`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134011/new/

[Lldb-commits] [PATCH] D133961: [lldb] Use SWIG_fail in python-typemaps.swig (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e450d134755: [lldb] Use SWIG_fail in python-typemaps.swig (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133961/new/ https:

[Lldb-commits] [PATCH] D133259: [lldb] Don't assume name of libc++ inline namespace in LibCxxUnorderedMap

kastiglione added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp:70 +static void consumeNamespace(llvm::StringRef &name) { + // Delete past an inline namespace, if any: __[a-zA-Z0-9_]+:: JDevlieghere wrote: > rupprec

[Lldb-commits] [PATCH] D133259: [lldb] Don't assume name of libc++ inline namespace in LibCxxUnorderedMap

kastiglione updated this revision to Diff 460778. kastiglione added a comment. Rename to consumeInlineNamespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133259/new/ https://reviews.llvm.org/D133259 Files: lldb/source/Plugins/Language/CPlusP

[Lldb-commits] [PATCH] D134515: [lldb] Fix completion of 'settings set' values

kastiglione created this revision. kastiglione added reviewers: mib, augusto2112. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Some time ago, a refactor (1153dc960) broke completion for assigning

[Lldb-commits] [PATCH] D134515: [lldb] Fix completion of 'settings set' values

kastiglione updated this revision to Diff 462532. kastiglione added a comment. Rename test and change the docstring to be meaningful. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134515/new/ https://reviews.llvm.org/D134515 Files: lldb/source/C

[Lldb-commits] [PATCH] D134515: [lldb] Fix completion of 'settings set' values

kastiglione added inline comments. Comment at: lldb/test/API/functionalities/completion/TestCompletion.py:410 +"""Test that 'settins set stop-disassembly-display ' completes to [ +'never', 'always', 'no-debuginfo', 'no-source'].""" +self.complete_from_to('

[Lldb-commits] [PATCH] D134515: [lldb] Fix completion of 'settings set' values

kastiglione added inline comments. Comment at: lldb/test/API/functionalities/completion/TestCompletion.py:410 +"""Test that 'settins set stop-disassembly-display ' completes to [ +'never', 'always', 'no-debuginfo', 'no-source'].""" +self.complete_from_to('

[Lldb-commits] [PATCH] D134515: [lldb] Fix completion of 'settings set' values

This revision was automatically updated to reflect the committed changes. Closed by commit rGc418f0053600: [lldb] Fix completion of 'settings set' values (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134515/new/ https://re

[Lldb-commits] [PATCH] D134920: [lldb] Remove scoped timer from high firing and fast running ExtractUnitDIENoDwoIfNeeded

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Profiles show that `DWARFUnit::ExtractUnitDIENoDwoIfNeeded` is both high

[Lldb-commits] [PATCH] D134922: [lldb] Remove scoped timer from high firing and fast running SymbolFileDWARF::FindFunctions

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Profiles show that `SymbolFileDWARF::FindFunctions` is both high firing

[Lldb-commits] [PATCH] D134011: [lldb] Fix parentheses placement in GetExpressionPath

kastiglione abandoned this revision. kastiglione added a subscriber: tonkosi. kastiglione added a comment. This was already being worked on in D132734 by @tonkosi Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1340

[Lldb-commits] [PATCH] D134922: [lldb] Remove scoped timer from high firing and fast running SymbolFileDWARF::FindFunctions

This revision was automatically updated to reflect the committed changes. Closed by commit rG72a86a9dc4c5: [lldb] Remove scoped timer from high firing and fast running SymbolFileDWARF… (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D134920: [lldb] Remove scoped timer from high firing and fast running ExtractUnitDIENoDwoIfNeeded

This revision was automatically updated to reflect the committed changes. Closed by commit rG557a19ab0fce: [lldb] Remove scoped timer from high firing and fast running… (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134920/n

[Lldb-commits] [PATCH] D135310: [lldb/crashlog] Add support for 32bit frame addresses

kastiglione added a comment. looks good CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135310/new/ https://reviews.llvm.org/D135310 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [PATCH] D135482: [lldb/crashlog] Fix the image_regex_uuid to skip null UUID images

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. lgtm now CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135482/new/ https://reviews.llvm.org/D135482 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. > I expect the majority of places where we want to log to the diagnostic log > channel to be places where we already log today. This is my expectation too. Some logs are helpful for

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

kastiglione added a comment. > Do you have an repro case that will show this issue? I would need to debug it. @clayborg sorry for the late reply. The repro happened to me while debugging some Swift: func main() { let digits = /\d+/ let match = "abc123".firstMatch(of: digits)

[Lldb-commits] [PATCH] D137137: [lldb/Interpreter] Open saved transcript in GUI Editor

kastiglione accepted this revision. kastiglione added a comment. looks good CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137137/new/ https://reviews.llvm.org/D137137 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D135616: [lldb/Utility] Fix StructuredData::ParseJSONValue for null items

kastiglione accepted this revision. kastiglione added a comment. +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135616/new/ https://reviews.llvm.org/D135616 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D137582: [lldb] Fix issue with re.Pattern availability

kastiglione created this revision. kastiglione added reviewers: mib, rastogishubham, JDevlieghere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `re.Pattern` is introduced in Python 3.7. To support

[Lldb-commits] [PATCH] D137582: [lldb] Fix issue with re.Pattern availability

kastiglione updated this revision to Diff 473768. kastiglione added a comment. Simplify the fallback expression. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137582/new/ https://reviews.llvm.org/D137582 Files: lldb/packages/Python/lldbsuite/tes

[Lldb-commits] [PATCH] D137582: [lldb] Fix issue with re.Pattern availability

kastiglione added a comment. > Anyway to test this ? I don't have a Python 3.6 to test with. I did test locally which caught an issue, so I am at least confident it won't regress anything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137582/new/

[Lldb-commits] [PATCH] D137582: [lldb] Fix issue with re.Pattern availability

kastiglione updated this revision to Diff 473811. kastiglione added a comment. Use short circuit to avoid eager eval of `re.SRE_Pattern` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137582/new/ https://reviews.llvm.org/D137582 Files: lldb/packa

[Lldb-commits] [PATCH] D137582: [lldb] Fix issue with re.Pattern availability

kastiglione updated this revision to Diff 473812. kastiglione added a comment. Switch to getting the type dynamically instead of by name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137582/new/ https://reviews.llvm.org/D137582 Files: lldb/pack

[Lldb-commits] [PATCH] D137582: [lldb] Fix issue with re.Pattern availability

This revision was automatically updated to reflect the committed changes. Closed by commit rG7bf3cb3ee871: [lldb] Fix issue with re.Pattern availability (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137582/new/ https://rev

[Lldb-commits] [PATCH] D133395: [lldb] Update regex to be less fragile in TestDataFormatterGenericUnordered

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f121a3f18f7: [lldb] Update regex to be less fragile in TestDataFormatterGenericUnordered (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D133259: [lldb] Don't assume name of libc++ inline namespace in LibCxxUnorderedMap

This revision was automatically updated to reflect the committed changes. Closed by commit rGb66da73a05ab: [lldb] Don't assume name of libc++ inline namespace in LibCxxUnorderedMap (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D137860: [lldb] Allow flexible importing of in_call_stack

kastiglione created this revision. kastiglione added a reviewer: jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Allow `in_call_stack` to be imported in either of the following ways: comm

[Lldb-commits] [PATCH] D137860: [lldb] Allow flexible importing of in_call_stack

This revision was automatically updated to reflect the committed changes. Closed by commit rG307f395d4ffe: [lldb] Allow flexible importing of in_call_stack (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137860/new/ https://

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione updated this revision to Diff 474866. kastiglione added a comment. Add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.org/D133366 Files: lldb/bindings/interface/SBFileSpec.i lldb/test/API/pyth

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG5223366416fb: [lldb] Fix SBFileSpec.fullpath for Windows (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://review

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione added a comment. @stella.stamenova fix about to be committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.org/D133366 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione added a comment. @stella.stamenova fix is rG1ee299a57d0b5f49b6c37d81474ea030e3b122de Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione added a comment. @stella.stamenova I realized that test has more paths that need fixing. The rest are fixed in rG760c75fe2d25e06644271cb1338f8b0f8d9abc70 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione added a comment. Ugh, the test that is failing uses windows paths but runs on both windows and non-windows machines. I will revert this and the two fix commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione added a comment. Reverted in rG01f924d0e37a5deae51df0d77e10a15b63aa0c0f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.org/D133366 _

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione added a comment. I will do that and recommit, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.org/D133366 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D138060: Improve error logging when xcrun fails to execute successfully

kastiglione added inline comments. Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:384 -Log *log = GetLog(LLDBLog::Host); +Log *log = GetLog(LLDBLog::Host | LLDBLog::Types); if (log) { Maybe a comment explaining how this is useful in t

[Lldb-commits] [PATCH] D138315: [lldb] Introduce dwim-print command

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, aprantl, jingham, labath, werat, cmtice. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Implements `dwim-print`, a prin

[Lldb-commits] [PATCH] D138315: [lldb] Introduce dwim-print command

kastiglione updated this revision to Diff 476549. kastiglione added a comment. Add license. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138315/new/ https://reviews.llvm.org/D138315 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/l

[Lldb-commits] [PATCH] D138315: [lldb] Introduce dwim-print command

kastiglione updated this revision to Diff 476550. kastiglione added a comment. Add license in .cpp too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138315/new/ https://reviews.llvm.org/D138315 Files: lldb/include/lldb/Core/Debugger.h lldb/in

[Lldb-commits] [PATCH] D138348: [lldb] Fix SBFileSpec.fullpath

kastiglione created this revision. kastiglione added reviewers: mib, labath. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Reimplement of `SBFileSpec.fullpath` to (indirectly) use `FileSpec::GetPat

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione added a comment. @labath thanks, I believe a more correct fix here https://reviews.llvm.org/D138348 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.org/D133366 ___

[Lldb-commits] [PATCH] D138348: [lldb] Fix SBFileSpec.fullpath

kastiglione updated this revision to Diff 476652. kastiglione added a comment. Fix commit wording Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138348/new/ https://reviews.llvm.org/D138348 Files: lldb/bindings/interface/SBFileSpec.i Index: lld

[Lldb-commits] [PATCH] D138348: [lldb] Fix SBFileSpec.fullpath

This revision was automatically updated to reflect the committed changes. Closed by commit rGa59ed8fa8603: [lldb] Fix SBFileSpec.fullpath (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138348/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D138878: [lldb] Remove timer from Module::GetNumCompileUnits

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, augusto2112. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `GetNumCompileUnits` has fast execution, and is high firing.

[Lldb-commits] [PATCH] D138315: [lldb] Introduce dwim-print command

kastiglione updated this revision to Diff 478419. kastiglione added a comment. Address @labath's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138315/new/ https://reviews.llvm.org/D138315 Files: lldb/include/lldb/Core/Debugger.h lldb/

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

kastiglione added inline comments. Comment at: lldb/source/Target/Target.cpp:208 +// of the debugee. +m_scratch_type_system_map.Clear(); m_process_sp.reset(); Do we have some place in the life-cycle where we can perform this only if the target has c

[Lldb-commits] [PATCH] D138315: [lldb] Introduce dwim-print command

This revision was automatically updated to reflect the committed changes. Closed by commit rG185d4964a158: [lldb] Introduce dwim-print command (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138315/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D138960: [lldb] Enable use of dummy target from dwim-print

kastiglione created this revision. kastiglione added reviewers: jingham, labath. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Allow `dwim-print` to evaluate expressions using the dummy target if n

[Lldb-commits] [PATCH] D138960: [lldb] Enable use of dummy target from dwim-print

kastiglione updated this revision to Diff 479035. kastiglione added a comment. Add docstring to new test function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138960/new/ https://reviews.llvm.org/D138960 Files: lldb/source/Commands/CommandObjec

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

kastiglione added inline comments. Comment at: lldb/source/Core/ModuleList.cpp:1080 + bool ret = true; + ForEach([&](const ModuleSP &module_sp) { +ret &= callback(module_sp); I wonder why ForEach doesn't deal out a `Module &`? I would think a ModuleList sh

[Lldb-commits] [PATCH] D138878: [lldb] Remove timer from Module::GetNumCompileUnits

This revision was automatically updated to reflect the committed changes. Closed by commit rGe2a10d8ca34a: [lldb] Remove timer from Module::GetNumCompileUnits (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138878/new/ https

[Lldb-commits] [PATCH] D138960: [lldb] Enable use of dummy target from dwim-print

This revision was automatically updated to reflect the committed changes. Closed by commit rGcebb87e7dce8: [lldb] Enable use of dummy target from dwim-print (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138960/new/ https:/

[Lldb-commits] [PATCH] D106171: [lldb] Avoid moving ThreadPlanSP from plans vector

kastiglione created this revision. kastiglione added reviewers: jingham, aprantl. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Change `ThreadPlanStack::PopPlan` and `::DiscardPlan` to not do the following: 1. Move the last p

[Lldb-commits] [PATCH] D106122: Add a mutex to guard access to the ThreadPlanStack class

kastiglione added a comment. I've also opened D106171 as a potential fix. It could be that we merge both diffs, they aren't mutually exclusive. Comment at: lldb/include/lldb/Target/ThreadPlanStack.h:157 void Clear() { -for (auto plan :

[Lldb-commits] [PATCH] D106122: Add a mutex to guard access to the ThreadPlanStack class

kastiglione accepted this revision. kastiglione added inline comments. Comment at: lldb/include/lldb/Target/ThreadPlanStack.h:113 std::unordered_map m_completed_plan_store; + mutable std::recursive_mutex m_stack_mutex; }; JDevlieghere wrote: > Does this actu

[Lldb-commits] [PATCH] D106171: [lldb] Avoid moving ThreadPlanSP from plans vector

kastiglione updated this revision to Diff 359474. kastiglione added a comment. Also call pop_back just after retrieving back. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106171/new/ https://reviews.llvm.org/D106171 Files: lldb/source/Target/Th

[Lldb-commits] [PATCH] D106171: [lldb] Avoid moving ThreadPlanSP from plans vector

kastiglione updated this revision to Diff 360290. kastiglione added a comment. Rename WillPop to DidPop, and comment on m_plans invariant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106171/new/ https://reviews.llvm.org/D106171 Files: lldb/inc

[Lldb-commits] [PATCH] D106171: [lldb] Avoid moving ThreadPlanSP from plans vector

kastiglione added a comment. @aprantl I renamed `WillPop` to accurately reflect that it's `DidPop`. I also added a comment about the invariant that is broken when `std::move` is used on elements of `m_plans`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D106171: [lldb] Avoid moving ThreadPlanSP from plans vector

kastiglione updated this revision to Diff 362229. kastiglione added a comment. Re-simplify following discussion with Adrian and Jim. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106171/new/ https://reviews.llvm.org/D106171 Files: lldb/source/Ta

[Lldb-commits] [PATCH] D106171: [lldb] Avoid moving ThreadPlanSP from plans vector

kastiglione added a comment. In D106171#2910693 , @JDevlieghere wrote: > IIRC the fact that the shared pointer is null is implementation defined and > the standard just says that a moved-from object is in an undefined state. According to cppreference,

[Lldb-commits] [PATCH] D106171: [lldb] Avoid moving ThreadPlanSP from plans vector

kastiglione updated this revision to Diff 362880. kastiglione added a comment. - Reword comment using Jonas's suggestion - Pop the last plan right away, and thus change from WillPop to DidPop Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106171/new/

[Lldb-commits] [PATCH] D106171: [lldb] Avoid moving ThreadPlanSP from plans vector

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41d0b20cc90f: [lldb] Avoid moving ThreadPlanSP from plans vector (authored by kastiglione). Changed prior to commit: https://reviews.llvm.org/D106

[Lldb-commits] [PATCH] D96539: [lldb] Add step target to ThreadPlanStepInRange constructor

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `QueueThreadPlanForStepInRange` accepts a `step_into_target`, but the constructor for `ThreadPlanStepInRa

[Lldb-commits] [PATCH] D96539: [lldb] Add step target to ThreadPlanStepInRange constructor

kastiglione updated this revision to Diff 323127. kastiglione added a comment. Herald added a subscriber: JDevlieghere. Improved wording in summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96539/new/ https://reviews.llvm.org/D96539 Files: l

[Lldb-commits] [PATCH] D96539: [lldb] Add step target to ThreadPlanStepInRange constructor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5ab1dc4ad2c: [lldb] Add step target to ThreadPlanStepInRange constructor (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES

<    1   2   3   4   5   6   7   8   >