kastiglione created this revision.
kastiglione added a reviewer: mib.
Herald added a project: All.
kastiglione requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Fix `fullpath` to not assume a `/` path separator. This was discovered when
D133130 <https://reviews.llvm.org/D133130> failed on Windows. Use
`os.path.join()` to fix the issue.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D133366
Files:
lldb/bindings/interface/SBFileSpec.i
Index: lldb/bindings/interface/SBFileSpec.i
===================================================================
--- lldb/bindings/interface/SBFileSpec.i
+++ lldb/bindings/interface/SBFileSpec.i
@@ -88,7 +88,7 @@
spec_dir = self.GetDirectory()
spec_file = self.GetFilename()
if spec_dir and spec_file:
- return '%s/%s' % (spec_dir, spec_file)
+ return os.path.join(spec_dir, spec_file)
elif spec_dir:
return spec_dir
elif spec_file:
Index: lldb/bindings/interface/SBFileSpec.i
===================================================================
--- lldb/bindings/interface/SBFileSpec.i
+++ lldb/bindings/interface/SBFileSpec.i
@@ -88,7 +88,7 @@
spec_dir = self.GetDirectory()
spec_file = self.GetFilename()
if spec_dir and spec_file:
- return '%s/%s' % (spec_dir, spec_file)
+ return os.path.join(spec_dir, spec_file)
elif spec_dir:
return spec_dir
elif spec_file:
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
