kastiglione added inline comments.
================
Comment at: lldb/test/API/functionalities/completion/TestCompletion.py:410
+ """Test that 'settins set stop-disassembly-display ' completes to [
+ 'never', 'always', 'no-debuginfo', 'no-source']."""
+ self.complete_from_to('settings set stop-disassembly-display ',
----------------
kastiglione wrote:
> DavidSpickett wrote:
> > Could you add to the comment why this one was chosen in particular?
> > Something like:
> > ```
> > Checks that we can complete a setting that has enum values.
> > ```
> >
> > Since there is a `settings set` test above but clearly that wasn't enough
> > coverage.
> done, I also renamed the test to describe why not what.
correction: to describe what, not how.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134515/new/
https://reviews.llvm.org/D134515
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
