kastiglione created this revision.
kastiglione added reviewers: mib, augusto2112.
Herald added a project: All.
kastiglione requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Some time ago, a refactor (1153dc960) broke completion for assigning settings
values (`settings set`). This was most annoying for enum settings, where you'd
have to get the valid enum names separately.
This restores the logic in the post-refactor completion function, as well as
adding a test to catch future regressions.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D134515
Files:
lldb/source/Commands/CommandObjectSettings.cpp
lldb/test/API/functionalities/completion/TestCompletion.py
Index: lldb/test/API/functionalities/completion/TestCompletion.py
===================================================================
--- lldb/test/API/functionalities/completion/TestCompletion.py
+++ lldb/test/API/functionalities/completion/TestCompletion.py
@@ -405,6 +405,12 @@
['target.process.thread.step-avoid-regexp',
'target.process.thread.trace-thread'])
+ def test_settings_set_stop_disassembly_display_value(self):
+ """Test that 'settins set stop-disassembly-display ' completes to [
+ 'never', 'always', 'no-debuginfo', 'no-source']."""
+ self.complete_from_to('settings set stop-disassembly-display ',
+ ['never', 'always', 'no-debuginfo', 'no-source'])
+
def test_thread_plan_discard(self):
self.build()
(_, _, thread, _) = lldbutil.run_to_source_breakpoint(self,
Index: lldb/source/Commands/CommandObjectSettings.cpp
===================================================================
--- lldb/source/Commands/CommandObjectSettings.cpp
+++ lldb/source/Commands/CommandObjectSettings.cpp
@@ -154,7 +154,7 @@
return;
// Complete option name
- if (arg[0] != '-')
+ if (arg[0] == '-')
return;
// Complete setting value
Index: lldb/test/API/functionalities/completion/TestCompletion.py
===================================================================
--- lldb/test/API/functionalities/completion/TestCompletion.py
+++ lldb/test/API/functionalities/completion/TestCompletion.py
@@ -405,6 +405,12 @@
['target.process.thread.step-avoid-regexp',
'target.process.thread.trace-thread'])
+ def test_settings_set_stop_disassembly_display_value(self):
+ """Test that 'settins set stop-disassembly-display ' completes to [
+ 'never', 'always', 'no-debuginfo', 'no-source']."""
+ self.complete_from_to('settings set stop-disassembly-display ',
+ ['never', 'always', 'no-debuginfo', 'no-source'])
+
def test_thread_plan_discard(self):
self.build()
(_, _, thread, _) = lldbutil.run_to_source_breakpoint(self,
Index: lldb/source/Commands/CommandObjectSettings.cpp
===================================================================
--- lldb/source/Commands/CommandObjectSettings.cpp
+++ lldb/source/Commands/CommandObjectSettings.cpp
@@ -154,7 +154,7 @@
return;
// Complete option name
- if (arg[0] != '-')
+ if (arg[0] == '-')
return;
// Complete setting value
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
