kastiglione added inline comments.
================
Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp:74
+ if (name.consume_front("std::"))
+ name.consume_front("__1::");
+ return name.consume_front(type) && name.startswith("<");
----------------
kastiglione wrote:
> rsmith wrote:
> > This is not right -- libc++ allows customizing its inline namespace name
> > for versioning purpose; it's not `__1` across all deployments. For example,
> > with the libc++ unstable ABI, it will likely be something else. To handle
> > this properly I think you'll need to look for either `std::name<` or
> > something like `std::[a-zA-Z0-9_]*::name<`.
> thanks. Looks like `CPPLanguageRuntime.cpp` has makes some similar
> assumptions.
D133259
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117383/new/
https://reviews.llvm.org/D117383
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
