[Lldb-commits] [PATCH] D132307: [lldb] Switch RegularExpression from llvm::Regex to std::regex

kastiglione updated this revision to Diff 454247. kastiglione added a comment. Switch to llvm::Optional Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132307/new/ https://reviews.llvm.org/D132307 Files: lldb/include/lldb/Utility/RegularExpression

[Lldb-commits] [PATCH] D132307: [lldb] Switch RegularExpression from llvm::Regex to std::regex

kastiglione added inline comments. Comment at: lldb/source/Utility/CMakeLists.txt:29 + PROPERTIES COMPILE_OPTIONS + "-fcxx-exceptions" +) kastiglione wrote: > JDevlieghere wrote: > > kastiglione wrote: > > > the `std::regex` constructor throws `std::regex_error

[Lldb-commits] [PATCH] D132382: [lldb] Remove prefer-dynamic-value test override

kastiglione created this revision. kastiglione added reviewers: augusto2112, JDevlieghere, mib, aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Remove the test override of `target.prefer-dyn

[Lldb-commits] [PATCH] D132382: [lldb] Remove prefer-dynamic-value test override

kastiglione added inline comments. Comment at: lldb/test/API/sanity/TestSettingSkipping.py:15-32 + @skipIf(py_version=('>=', (3, 0))) def testSkip(self): """This setting is on by default""" self.assertTrue(False, "This test should not run!") - @skipIf(setting=('t

[Lldb-commits] [PATCH] D132307: [lldb] Switch RegularExpression from llvm::Regex to std::regex

kastiglione added inline comments. Comment at: lldb/source/Utility/CMakeLists.txt:29 + PROPERTIES COMPILE_OPTIONS + "-fcxx-exceptions" +) labath wrote: > kastiglione wrote: > > kastiglione wrote: > > > JDevlieghere wrote: > > > > kastiglione wrote: > > > > > th

[Lldb-commits] [PATCH] D132382: [lldb] Remove prefer-dynamic-value test override

kastiglione updated this revision to Diff 454636. kastiglione added a comment. Fixed description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132382/new/ https://reviews.llvm.org/D132382 Files: lldb/packages/Python/lldbsuite/test/configuration.

[Lldb-commits] [PATCH] D132382: [lldb] Remove prefer-dynamic-value test override

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc21dfa9e4931: [lldb] Remove prefer-dynamic-value test override (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

kastiglione added inline comments. Herald added subscribers: pmatos, asb. Herald added a project: All. Comment at: lldb/source/Symbol/ObjectFile.cpp:739 +// are protected by a mutex in the Symtab object itself. +llvm::call_once(*m_symtab_once_up, [&]() { + ElapsedTi

[Lldb-commits] [PATCH] D117383: [lldb] Expose std::pair children for unordered_map

kastiglione added a comment. @jingham what do you think of this update? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117383/new/ https://reviews.llvm.org/D117383 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D122041: [llvm][utils] Fix llvm::Optional summary provider

kastiglione created this revision. kastiglione added reviewers: jingham, aprantl. kastiglione added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-com

[Lldb-commits] [PATCH] D122041: [llvm][utils] Fix llvm::Optional summary provider

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG826bdf51ff31: [lldb] Fix llvm::Optional summary provider (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D122347: Expose GetAddressingBits() in the Process API

kastiglione added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:216 +llvm::Optional ProcessGDBRemote::GetAddressingBits() { + return m_gdb_comm.GetAddressingBits(); +} Thought: should this API return a mask instead? R

[Lldb-commits] [PATCH] D122041: [llvm][utils] Fix llvm::Optional summary provider

kastiglione added a comment. > There's some CMake trickery Can you shed some more light on this? Am I understanding right: these formatters are llvm, but the test would be in lldb? It seems weird that something in llvm/ would only have tests in lldb/. Would it be bad to move this file into lld

[Lldb-commits] [PATCH] D123698: [lldb] Port Process::PrintWarning* to use the new diagnostic events

kastiglione accepted this revision. kastiglione added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Core/Module.h:820-825 + void ReportWarningOptimization( + llvm::Optional debugger_id = llvm::None); + + void ReportWarningU

[Lldb-commits] [PATCH] D123954: [lldb] Add setting for max depth of value object printing (NFC)

kastiglione updated this revision to Diff 425338. kastiglione added a comment. Herald added a subscriber: lldb-commits. Updated for code review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123954/new/ https://reviews.llvm.org/D123954 Files: ll

[Lldb-commits] [PATCH] D123954: [lldb] Add setting for max depth of value object printing (NFC)

kastiglione added inline comments. Comment at: lldb/include/lldb/Interpreter/CommandInterpreter.h:718 + /// been told. + ChildrenOmissionWarningStatus m_truncation_warning; + /// Whether we reached the maximum child nesting depth and whether the user shafik wr

[Lldb-commits] [PATCH] D123954: [lldb] Add setting for max depth of value object printing (NFC)

kastiglione added inline comments. Comment at: lldb/include/lldb/Interpreter/CommandInterpreter.h:718 + /// been told. + ChildrenOmissionWarningStatus m_truncation_warning; + /// Whether we reached the maximum child nesting depth and whether the user kastiglio

[Lldb-commits] [PATCH] D123954: [lldb] Add setting for max depth of value object printing (NFC)

kastiglione updated this revision to Diff 425826. kastiglione added a comment. Fixed: comment formatting; bool logic bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123954/new/ https://reviews.llvm.org/D123954 Files: lldb/include/lldb/DataForm

[Lldb-commits] [PATCH] D123954: [lldb] Add setting for max depth of value object printing (NFC)

kastiglione added inline comments. Comment at: lldb/include/lldb/Interpreter/OptionGroupValueObjectDisplay.h:50 uint32_t max_depth; + bool max_depth_is_default; uint32_t ptr_depth; aprantl wrote: > Should this be with the other bools on line 45? It wasn't

[Lldb-commits] [PATCH] D123954: [lldb] Add setting for max depth of value object printing (NFC)

kastiglione updated this revision to Diff 426755. kastiglione added a comment. Addresses Adrian's feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123954/new/ https://reviews.llvm.org/D123954 Files: lldb/include/lldb/DataFormatters/DumpVa

[Lldb-commits] [PATCH] D123954: [lldb] Add setting for max depth of value object printing (NFC)

kastiglione updated this revision to Diff 426761. kastiglione added a comment. Fixed/improved docstring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123954/new/ https://reviews.llvm.org/D123954 Files: lldb/include/lldb/DataFormatters/DumpValueO

[Lldb-commits] [PATCH] D123954: [lldb] Add setting for max depth of value object printing (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f9fc576be20: [lldb] Add setting for max depth of value object printing (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123954

[Lldb-commits] [PATCH] D125042: have crashlog.py insert a stack frame with $lr when stack frame 0 is address 0

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. thanks for fixing these, especially the `lr` technique! Comment at: lldb/examples/python/crashlog.py:520 + +# on arm64 systems, if jump through a null f

[Lldb-commits] [PATCH] D125148: Add an example command that runs to one of a set of breakpoints

kastiglione added inline comments. Comment at: lldb/examples/python/cont_to_bkpt.py:13 +try: +int_val = int(str) +except: is it worth supporting named breakpoints in addition to IDs Comment at: lldb/examp

[Lldb-commits] [PATCH] D125148: Add an example command that runs to one of a set of breakpoints

kastiglione added inline comments. Comment at: lldb/examples/python/cont_to_bkpt.py:21 + +if len(bkpt_ids) == 0: +result.SetError("No breakpoint to run to") can also be `if not bkpt_ids:` Comment at: lldb/examples/python/con

[Lldb-commits] [PATCH] D125148: Add an example command that runs to one of a set of breakpoints

kastiglione added inline comments. Comment at: lldb/examples/python/cont_to_bkpt.py:5-6 +def __init__(self, debugger, unused): +self.dbg = debugger +self.interp = debugger.GetCommandInterpreter() + Are these properties needed by lldb?

[Lldb-commits] [PATCH] D125154: [lldb] Specify aguments of `image list`

kastiglione created this revision. kastiglione added reviewers: aprantl, jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Register positional argument details in `CommandObjectTargetModulesLi

[Lldb-commits] [PATCH] D125154: [lldb] Specify aguments of `image list`

kastiglione updated this revision to Diff 428481. kastiglione added a comment. add to TestHelp.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125154/new/ https://reviews.llvm.org/D125154 Files: lldb/source/Commands/CommandObjectTarget.cpp ll

[Lldb-commits] [PATCH] D125154: [lldb] Specify aguments of `image list`

kastiglione added a comment. @DavidSpickett I might do some follow up work, if so I will add coverage then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125154/new/ https://reviews.llvm.org/D125154 ___

[Lldb-commits] [PATCH] D126078: [lldb] Improve formatting of dlopen error messages (NFC)

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added a subscriber: emaste. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Ensure there's a space between "utili

[Lldb-commits] [PATCH] D126078: [lldb] Improve formatting of dlopen error messages (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG0da230ff4439: [lldb] Improve formatting of dlopen error messages (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126078/new/

[Lldb-commits] [PATCH] D125154: [lldb] Specify aguments of `image list`

This revision was automatically updated to reflect the committed changes. Closed by commit rG760298adc264: [lldb] Specify aguments of `image list` (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125154/new/ https://reviews.l

[Lldb-commits] [PATCH] D125148: Add an example command that runs to one of a set of breakpoints

kastiglione added a comment. > The patch gets a little hard to read with all the no-longer in the right > places comments I just learned there's a keyboard shortcut (`A`) that hides them all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125148/ne

[Lldb-commits] [PATCH] D126730: Fix a bug where `break com add -s py -o "some_python" BKPT_NAME` only added the command to the first breakpoint

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126730/new/ https://reviews.llvm.org/D126730 __

[Lldb-commits] [PATCH] D126789: Stop regex commands from double entry into the history

kastiglione added a comment. thank you for fixing! Q: why does this test have this thin `test_X`/`do_x_test` separation? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126789/new/ https://reviews.llvm.org/D126789 __

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

kastiglione added a comment. I noticed that the example python command and this feature don't support specifying breakpoint locations. Should it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126513/new/ https://reviews.llvm.org/D126513 _

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectProcess.cpp:668 + [this, old_sync]() { +this->GetDebugger().SetAsyncExecution(!old_sync); + }); this should be `old_sync` (no `!`) Repository: rG LL

[Lldb-commits] [PATCH] D127016: [lldb] Prevent crash due to reading memory from page zero.

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectMemory.cpp:597-598 +ABISP abi; +if (Process * proc = m_exe_ctx.GetProcessPtr()) + abi = proc->GetABI(); + Should `memory read` emit an error if there's no process (and n

[Lldb-commits] [PATCH] D127258: [lldb] Parse the dotest output to determine the most appropriate result code

kastiglione added a comment. > That means that if you have a test that has 3 passes and 4 skips, it will be > reported as unsupported (while currently it's considered a pass). My initial reaction to this is that I don't love it. I think N passes and M skips is a **pass**, even if M>N. ==

[Lldb-commits] [PATCH] D127258: [lldb] Parse the dotest output to determine the most appropriate result code

kastiglione added a comment. instead of reducing and picking returning a single result, can we return the raw counts and then report the totals of the counts? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127258/new/ https://reviews.llvm.org/D127258 ___

[Lldb-commits] [PATCH] D127258: [lldb] Parse the dotest output to determine the most appropriate result code

kastiglione accepted this revision. kastiglione added inline comments. Comment at: lldb/test/API/lldbtest.py:126 +# being stable for ties. +lit_results.sort(reverse=True, key=operator.itemgetter(0)) +return lit_results[0][1], output you co

[Lldb-commits] [PATCH] D127378: [lldb] Use assertState in more tests (NFC)

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, mib. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Follow to D127355 , converting mor

[Lldb-commits] [PATCH] D127355: [lldb] Add assertState function

kastiglione added a comment. nice, I've wanted this too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127355/new/ https://reviews.llvm.org/D127355 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [PATCH] D127378: [lldb] Use assertState in more tests (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG47c4c6a7469f: [lldb] Use assertState in more tests (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127378/new/ https://review

[Lldb-commits] [PATCH] D127378: [lldb] Use assertState in more tests (NFC)

kastiglione added a comment. @JDevlieghere `assertEquals` is the deprecated name, `assertEqual` is the Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127378/new/ https://reviews.llvm.org/D127378 ___ lldb-

[Lldb-commits] [PATCH] D127458: [lldb][bindings] Implement __repr__ instead of __str__

kastiglione created this revision. kastiglione added reviewers: jingham, JDevlieghere, mib. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When using the `script` Python repl, SB objects are printed

[Lldb-commits] [PATCH] D127458: [lldb][bindings] Implement __repr__ instead of __str__

kastiglione added a comment. @mib I tried but failed to answer that in the original commit description. I have reworded it to be more clear. Here's the relevant paragraph: > For convenience, this change switches all SB classes that implement to > `__str__` to instead implement `__repr__`. **The

[Lldb-commits] [PATCH] D127038: Add some documentation for the "breakpoint name" feature

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. thank you again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127038/new/ https://reviews.llvm.org/D127038 __

[Lldb-commits] [PATCH] D127458: [lldb][bindings] Implement __repr__ instead of __str__

kastiglione added a comment. Note also that the tests use `str()` in many places, so we can be sure this hasn't regressed that. I will add a test for `repr`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127458/new/ https://reviews.llvm.org/D12745

[Lldb-commits] [PATCH] D127458: [lldb][bindings] Implement __repr__ instead of __str__

kastiglione updated this revision to Diff 435972. kastiglione added a comment. add test/API/sanity/TestReprStrEquality.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127458/new/ https://reviews.llvm.org/D127458 Files: lldb/bindings/macros.swig

[Lldb-commits] [PATCH] D127458: [lldb][bindings] Implement __repr__ instead of __str__

kastiglione updated this revision to Diff 435980. kastiglione added a comment. update TestConvenienceVariables.test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127458/new/ https://reviews.llvm.org/D127458 Files: lldb/bindings/macros.swig lld

[Lldb-commits] [PATCH] D127458: [lldb][bindings] Implement __repr__ instead of __str__

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7a56af3072c: [lldb][bindings] Implement __repr__ instead of __str__ (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127458/new/ ht

[Lldb-commits] [PATCH] D127586: [lldb][Interpreter] Add newline terminal to one-line script calls

kastiglione created this revision. kastiglione added reviewers: mib, JDevlieghere, jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix `script -lpython` to handle control flow in one-line co

[Lldb-commits] [PATCH] D127605: [lldb] Support non-pointer implicit this/self in GetValueForVariableExpressionPath

kastiglione created this revision. kastiglione added reviewers: aprantl, jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The `frame variable` command supports an implicit `this`/`self`, allo

[Lldb-commits] [PATCH] D127605: [lldb] Support non-pointer implicit this/self in GetValueForVariableExpressionPath

kastiglione updated this revision to Diff 436243. kastiglione added a comment. Herald added a subscriber: JDevlieghere. use explicit type instead of auto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127605/new/ https://reviews.llvm.org/D127605 Fi

[Lldb-commits] [PATCH] D127605: [lldb] Support non-pointer implicit this/self in GetValueForVariableExpressionPath

kastiglione updated this revision to Diff 436260. kastiglione added a comment. check valid compiler type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127605/new/ https://reviews.llvm.org/D127605 Files: lldb/source/Target/StackFrame.cpp Index:

[Lldb-commits] [PATCH] D127605: [lldb] Support non-pointer implicit this/self in GetValueForVariableExpressionPath

kastiglione added a comment. > This is good, but it also illustrates how the strings "->" and ".'" should > actually come from the typesystem and not be hardcoded. We're just lucky that > all languages have a "." operator. > > More elegant would be to just add an API to TypeSystem to get the ope

[Lldb-commits] [PATCH] D127895: [lldb] Don't overwrite quit and exit builtins in the interactive python interpreter

kastiglione added inline comments. Comment at: lldb/source/Interpreter/embedded_interpreter.py:49-52 +if line == 'exit': +raise LLDBExit +if line == 'quit': +raise LLDBExit could do: ``` if line in ('exit', 'quit'): ```

[Lldb-commits] [PATCH] D127895: [lldb] Don't overwrite quit and exit builtins in the interactive python interpreter

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. Before this, I didn't realize that `quit`/`exit` worked without being a function call. I think it's unfortunate we have to preserve that, but oh well. CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D127605: [lldb] Support non-pointer implicit this/self in GetValueForVariableExpressionPath

This revision was automatically updated to reflect the committed changes. Closed by commit rGe30c493894c4: [lldb] Support non-pointer implicit this/self in… (authored by kastiglione). Herald added a subscriber: Michael137. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D127586: [lldb][Interpreter] Add newline terminal to one-line script calls

This revision was automatically updated to reflect the committed changes. Closed by commit rGe9349ef9e6d8: Fix `script -lpython` to handle control flow in one-line commands. (authored by kastiglione). Changed prior to commit: https://reviews.llvm.org/D127586?vs=436191&id=437446#toc Repository:

[Lldb-commits] [PATCH] D127937: [lldb] Add RotatingLogHandler

kastiglione added inline comments. Comment at: lldb/include/lldb/Utility/Log.h:98 + + std::vector m_messages; + size_t m_next_index = 0; this could be an array, since it's not being dynamically resized. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[Lldb-commits] [PATCH] D127937: [lldb] Add RotatingLogHandler

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. lgtm Comment at: lldb/unittests/Utility/LogTest.cpp:112 + handler.Dump(stream); + return stream.str(); +} minor: `return buffer;` CHANGES SINCE

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. thanks Jim Comment at: lldb/source/Commands/CommandObjectProcess.cpp:600 + m_options.m_run_to_bkpt_args, target, result, &run_to_bkpt_ids, + Brea

[Lldb-commits] [PATCH] D140056: [lldb] Report clang module builds remarks

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, aprantl, mib. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Update the Clang diagnostic consumer (in ClangModulesDeclVe

[Lldb-commits] [PATCH] D140056: [lldb] Report clang module build remarks

kastiglione added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp:82 Log *m_log; + std::unique_ptr m_current_progress_up; + std::vector m_module_build_stack; mib wrote: > `Progress` makes use of RAII to com

[Lldb-commits] [PATCH] D139951: [lldb/crashlog] Refactor CrashLogParser into a Factory patern

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:419-426 +def CrashLogParserFactory(debugger, path, verbose): +data = JSONCrashLogParser.is_valid_json(path) +if data: +parser = JSONCrashLogParser(debugger, path, verbose) +par

[Lldb-commits] [PATCH] D140056: [lldb] Report clang module build remarks

kastiglione added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp:82 Log *m_log; + std::unique_ptr m_current_progress_up; + std::vector m_module_build_stack; aprantl wrote: > kastiglione wrote: > > mib wrot

[Lldb-commits] [PATCH] D140056: [lldb] Report clang module build remarks

kastiglione added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp:198 +// End the previous event before starting a new event. +m_current_progress_up.reset(nullptr); +m_current_progress_up.reset(new Progress(

[Lldb-commits] [PATCH] D140056: [lldb] Report clang module build remarks

kastiglione updated this revision to Diff 483379. kastiglione added a comment. Optimized test by using a minimal clang module; Addressed review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140056/new/ https://reviews.llvm.org/D140056 Fil

[Lldb-commits] [PATCH] D140056: [lldb] Report clang module build remarks

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c5b97570502: [lldb] Report clang module build remarks (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140056/new/ https://reviews.

[Lldb-commits] [PATCH] D141425: [lldb] Add --gdb-format flag to dwim-print

kastiglione created this revision. kastiglione added reviewers: jingham, labath, aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add support for the `--gdb-format`/`-G` flag to `dwim-print`.

[Lldb-commits] [PATCH] D141425: [lldb] Add --gdb-format flag to dwim-print

kastiglione added a comment. @jingham The brief answer is that decisions have been based on compatibility with the behavior of `p`. 1. `expression` (also `p`) and `frame variable`, only support the the format part of gdb options. Neither support `--count` or `--size` and so don't support the e

[Lldb-commits] [PATCH] D141539: [lldb][test] Replace use of p with expression (NFC)

kastiglione created this revision. kastiglione added a reviewer: aprantl. Herald added subscribers: kbarton, nemanjai. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In API tests, replace use of the

[Lldb-commits] [PATCH] D141539: [lldb][test] Replace use of p with expression (NFC)

kastiglione added a comment. I will add explicit tests for `p`. Comment at: lldb/test/API/python_api/file_handle/TestFileHandle.py:138 self.dbg.SetOutputFileHandle(f, False) -self.handleCmd('p/x 3735928559', collect_result=False, check=False) +

[Lldb-commits] [PATCH] D141539: [lldb][test] Replace use of p with expression (NFC)

kastiglione added inline comments. Comment at: lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py:74 +self.expect("expression/d ((int*)&first)[0]", substrs=['= 5']) +self.expect("expression/d ((int*)&second)[0]", substrs=['= 6']) self.as

[Lldb-commits] [PATCH] D142141: [lldb][test] Skip TestRerunAndExprDylib on Ubuntu 18.04

kastiglione created this revision. kastiglione added a reviewer: Michael137. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Disable this test on Ubuntu 18.04, where it fails for yet to be determined

[Lldb-commits] [PATCH] D142150: [lldb] Remove timer from SBModule copy ctor

kastiglione created this revision. kastiglione added a reviewer: aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The SBModule copy constructor has fast execution, and is high firing. Fast an

[Lldb-commits] [PATCH] D142141: [lldb][test] Skip TestRerunAndExprDylib on Ubuntu 18.04

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd4180dbf90b: [lldb][test] Skip TestRerunAndExprDylib on Ubuntu 18.04 (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142141/new/ h

[Lldb-commits] [PATCH] D142245: [lldb/swig] Remove deprecated `-py3` flag to generate bindings

kastiglione added a comment. Looks like -py3 was marked deprecated and no-effect in 4.1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142245/new/ https://reviews.llvm.org/D142245 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D142245: [lldb/swig] Remove deprecated `-py3` flag to generate bindings

kastiglione added inline comments. Comment at: lldb/bindings/python/CMakeLists.txt:11 -c++ -shadow -python Note that `-shadow` has been deprecated since 2002 and is on by default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D142150: [lldb] Remove timer from SBModule copy ctor

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG84c6129c9431: [lldb] Remove timer from SBModule copy ctor (authored by kastiglione). Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D141539: [lldb][test] Replace use of p with expression (NFC)

kastiglione updated this revision to Diff 490968. kastiglione added a comment. Add a test for `p`; Replace few instances of `print` with `expression` too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141539/new/ https://reviews.llvm.org/D141539 F

[Lldb-commits] [PATCH] D142150: [lldb] Remove timer from SBModule copy ctor

kastiglione added a comment. In D142150#4074015 , @aprantl wrote: > What about adding a `trivial` parameter to the macro that has the effect of > skipping it in instrumentation if the instrumentation is the costly signpost > mechanism? sounds good to m

[Lldb-commits] [PATCH] D142513: [lldb][test] Set minimum compiler_versions

kastiglione created this revision. kastiglione added reviewers: aprantl, JDevlieghere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Set compiler_versions on these tests, as they fail if tested on

[Lldb-commits] [PATCH] D142513: [lldb][test] Set minimum compiler_versions

kastiglione added a comment. These are failing on green dragon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142513/new/ https://reviews.llvm.org/D142513 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D142513: [lldb][test] Set minimum compiler_versions

kastiglione added a comment. It's the LLDB matrix that's failing, where previous compiler versions are also used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142513/new/ https://reviews.llvm.org/D142513 __

[Lldb-commits] [PATCH] D141539: [lldb][test] Replace use of p with expression (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG407666422838: [lldb][test] Replace use of p with expression (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141539/new/ https

[Lldb-commits] [PATCH] D142513: [lldb][test] Set minimum compiler_versions

This revision was automatically updated to reflect the committed changes. Closed by commit rG47f0384bb969: [lldb][test] Set minimum compiler_versions (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142513/new/ https://review

[Lldb-commits] [PATCH] D142245: [lldb/swig] Remove deprecated flags for generating bindings

kastiglione added a comment. nice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142245/new/ https://reviews.llvm.org/D142245 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [PATCH] D141425: [lldb] Add --gdb-format flag to dwim-print

kastiglione updated this revision to Diff 494401. kastiglione edited the summary of this revision. kastiglione added a comment. Add display options to `dwim-print` command Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141425/new/ https://reviews.ll

[Lldb-commits] [PATCH] D142926: [lldb][RFC] Replace SB swig interfaces with API headers

kastiglione added inline comments. Comment at: lldb/include/lldb/API/SBAddress.h:14-16 +#ifdef SWIG +%include "interface/SBAddressDocstrings.i" +#endif bulbazord wrote: > clayborg wrote: > > bulbazord wrote: > > > clayborg wrote: > > > > Do we want two different

[Lldb-commits] [PATCH] D143282: [lldb] Accept negative indexes in __getitem__

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, mib, bulbazord. Herald added a subscriber: arphaman. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. To the Python bindin

[Lldb-commits] [PATCH] D142926: [lldb][RFC] Replace SB swig interfaces with API headers

kastiglione added inline comments. Comment at: lldb/bindings/interface/SBAddressDocstrings.i:1-2 +%feature("docstring", +"A section + offset based address class. + How much of these header docs are specific to the API, but not specific to Swig bindings? Should/c

[Lldb-commits] [PATCH] D143282: [lldb] Accept negative indexes in __getitem__

kastiglione added a comment. I wondered what to do about tests. Should I pick one of these to test? Just doesn't seem worth tests for each… Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143282/new/ https://reviews.llvm.org/D143282

[Lldb-commits] [PATCH] D143282: [lldb] Accept negative indexes in __getitem__

kastiglione updated this revision to Diff 494783. kastiglione added a comment. Add a couple tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143282/new/ https://reviews.llvm.org/D143282 Files: lldb/bindings/interface/SBBreakpoint.i lldb/bin

[Lldb-commits] [PATCH] D141425: [lldb] Add --gdb-format flag to dwim-print

kastiglione updated this revision to Diff 495694. kastiglione added a comment. Add test with standard lldb flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141425/new/ https://reviews.llvm.org/D141425 Files: lldb/source/Commands/CommandObject

[Lldb-commits] [PATCH] D143282: [lldb] Accept negative indexes in __getitem__

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ff636729d06: [lldb] Accept negative indexes in __getitem__ (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143282/new/ https://rev

[Lldb-commits] [PATCH] D141425: [lldb] Add --gdb-format flag to dwim-print

kastiglione updated this revision to Diff 495887. kastiglione added a comment. remove unnecessary header addition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141425/new/ https://reviews.llvm.org/D141425 Files: lldb/source/Commands/CommandObjec

[Lldb-commits] [PATCH] D141425: [lldb] Add --gdb-format flag to dwim-print

kastiglione updated this revision to Diff 495895. kastiglione added a comment. Add a test for display options too (-T) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141425/new/ https://reviews.llvm.org/D141425 Files: lldb/source/Commands/Command

<    1   2   3   4   5   6   7   8   >