kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land.
thanks for fixing these, especially the `lr` technique! ================ Comment at: lldb/examples/python/crashlog.py:520 + + # on arm64 systems, if jump through a null function pointer, + # we end up at address 0 and the crash reporter unwinder ---------------- (minor) I think a word is missing between "if" and "jump". ================ Comment at: lldb/examples/python/crashlog.py:533 + frame_offset = pc - text_lo + thread.frames.append(self.crashlog.Frame(idx, pc, frame_offset)) + ---------------- What do you think of adding a `break` here? Not that it would change the outcome, but it might make the intention of the loop slightly better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125042/new/ https://reviews.llvm.org/D125042 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
