kastiglione added inline comments.
================ Comment at: lldb/examples/python/crashlog.py:419-426 +def CrashLogParserFactory(debugger, path, verbose): + data = JSONCrashLogParser.is_valid_json(path) + if data: + parser = JSONCrashLogParser(debugger, path, verbose) + parser.data = data + return parser + else: ---------------- JDevlieghere wrote: > This looks like a class now. The common patter for a factory is to create a > static method (e.g. `create`) in the class you're instantiating. +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139951/new/ https://reviews.llvm.org/D139951 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
