kastiglione created this revision.
kastiglione added reviewers: aprantl, jingham.
Herald added a project: All.
kastiglione requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Register positional argument details in `CommandObjectTargetModulesList`.
I recently learned that `image list` takes a module name, but the help info
does not indicate this. With this change, `help image list` will show that it
accepts zero or more module names.
This makes it easier to get info abot specific modules, without having to
find/grep through the full image list.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D125154
Files:
lldb/source/Commands/CommandObjectTarget.cpp
Index: lldb/source/Commands/CommandObjectTarget.cpp
===================================================================
--- lldb/source/Commands/CommandObjectTarget.cpp
+++ lldb/source/Commands/CommandObjectTarget.cpp
@@ -50,6 +50,7 @@
#include "lldb/Utility/LLDBLog.h"
#include "lldb/Utility/State.h"
#include "lldb/Utility/Timer.h"
+#include "lldb/lldb-enumerations.h"
#include "lldb/lldb-private-enumerations.h"
#include "llvm/ADT/ScopeExit.h"
@@ -2882,8 +2883,10 @@
CommandObjectTargetModulesList(CommandInterpreter &interpreter)
: CommandObjectParsed(
interpreter, "target modules list",
- "List current executable and dependent shared library images.",
- "target modules list [<cmd-options>]") {}
+ "List current executable and dependent shared library images.") {
+ CommandArgumentData module_arg{eArgTypeShlibName, eArgRepeatStar};
+ m_arguments.push_back({module_arg});
+ }
~CommandObjectTargetModulesList() override = default;
Index: lldb/source/Commands/CommandObjectTarget.cpp
===================================================================
--- lldb/source/Commands/CommandObjectTarget.cpp
+++ lldb/source/Commands/CommandObjectTarget.cpp
@@ -50,6 +50,7 @@
#include "lldb/Utility/LLDBLog.h"
#include "lldb/Utility/State.h"
#include "lldb/Utility/Timer.h"
+#include "lldb/lldb-enumerations.h"
#include "lldb/lldb-private-enumerations.h"
#include "llvm/ADT/ScopeExit.h"
@@ -2882,8 +2883,10 @@
CommandObjectTargetModulesList(CommandInterpreter &interpreter)
: CommandObjectParsed(
interpreter, "target modules list",
- "List current executable and dependent shared library images.",
- "target modules list [<cmd-options>]") {}
+ "List current executable and dependent shared library images.") {
+ CommandArgumentData module_arg{eArgTypeShlibName, eArgRepeatStar};
+ m_arguments.push_back({module_arg});
+ }
~CommandObjectTargetModulesList() override = default;
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
