kastiglione added inline comments.
================
Comment at: lldb/test/API/sanity/TestSettingSkipping.py:15-32
+ @skipIf(py_version=('>=', (3, 0)))
def testSkip(self):
"""This setting is on by default"""
self.assertTrue(False, "This test should not run!")
- @skipIf(setting=('target.prefer-dynamic-value', 'run-target'))
+ @skipIf(py_version=('<', (3, 0)))
def testNoMatch(self):
----------------
these tests had nothing to do with `prefer-dynamic-value`, they picked
something to decorate on. I picked something else to decorate on. I couldn't
pick a setting now that `configuration.settings` is empty.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132382/new/
https://reviews.llvm.org/D132382
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
