aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: zturner, asmith, labath.
aleksandr.urakov added a project: LLDB.
Herald added subscribers: lldb-commits, teemperor, mgorny.
This patch introduces the simple `PDBNameParser`. It is needed for parsing
names of PDB symbols cor
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: asmith, zturner, labath.
aleksandr.urakov added a project: LLDB.
Herald added subscribers: lldb-commits, teemperor.
`char`, `signed char` and `unsigned char` are three different types, and they
are mangled differently:
v
aleksandr.urakov added a comment.
Ok, I'll look into that, thanks!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52461
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: clayborg, zturner, labath, asmith.
aleksandr.urakov added a project: LLDB.
Herald added subscribers: lldb-commits, teemperor.
This patch implements restoring of the calling convention from PDB. It is
necessary for expressio
aleksandr.urakov updated this revision to Diff 167081.
aleksandr.urakov added a comment.
Thanks!
I just have extracted the test cases in a separate test and have specified
`-m32` key, so the test can run also on 64-bit machines.
https://reviews.llvm.org/D52501
Files:
include/lldb/Symbol/Cla
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343084: [PDB] Restore the calling convention from PDB
(authored by aleksandr.urakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52501?vs=
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: zturner, asmith, stella.stamenova, labath.
aleksandr.urakov added a project: LLDB.
Herald added subscribers: lldb-commits, teemperor, abidh.
This patch adds a basic implementation of `DoAllocateMemory` and
`DoDeallocateMemo
aleksandr.urakov updated this revision to Diff 167338.
aleksandr.urakov added a comment.
Clang-format patch.
https://reviews.llvm.org/D52618
Files:
lit/Expr/TestIRMemoryMap.test
lit/Expr/TestIRMemoryMapWindows.test
source/Plugins/Process/Windows/Common/ProcessWindows.cpp
source/Plugins/
aleksandr.urakov added a comment.
I didn't know about such a priority, thanks... But in this case `lldb-server`
also must be able to allocate, read and write in a debuggee. Doesn't it use the
process plugin for that? Or somehow duplicates this functionality?
I have made some work on expressions
aleksandr.urakov added a comment.
Yes, sure! Thanks all!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52468
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343298: [PDB] Handle `char` as a builtin type (authored by
aleksandr.urakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52468?vs=166876&i
aleksandr.urakov added a comment.
Thanks for explanations!
Unfortunately I can't promise that I'll begin porting `lldb-server` on Windows
in the nearest future. I've looked at my working copy, and there are only two
small changes related to `ProcessWindows` plugin (but they are not related to
aleksandr.urakov added a reviewer: clayborg.
aleksandr.urakov added a comment.
In https://reviews.llvm.org/D52461#1245058, @clayborg wrote:
> Try to use and extend CPlusPlusLanguage::MethodName as needed. I believe it
> was recently backed by a new clang parser that knows how to chop up C++
> d
aleksandr.urakov added a comment.
Ok, I'll look at this, thank you!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52461
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aleksandr.urakov added a comment.
I've tried to parse with it a name like
N0::`unnamed namespase'::Name
and it can't parse it correctly. May be it just can't parse MSVC demangled
names?
Unfortunately, I can't look at the tests right now, I have a vacation. I'll
look at these a week later, o
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: zturner, rnk, stella.stamenova.
aleksandr.urakov added a project: LLDB.
Herald added subscribers: lldb-commits, abidh, JDevlieghere, aprantl.
This patch fixes the flaky test `variables-locations.test`. The test began
flakin
aleksandr.urakov added a comment.
Thanks a lot for so detailed answer, it helps!
So we need to parse a FPO program and to convert it in a DWARF expression too.
The problem here (in the DIA case) is that I don't know how to retrieve the
required FPO range (we have a symbol context when creating
aleksandr.urakov updated this revision to Diff 169181.
https://reviews.llvm.org/D53086
Files:
lit/SymbolFile/PDB/Inputs/VariablesLocationsTest.cpp
lit/SymbolFile/PDB/Inputs/VariablesLocationsTest.script
Index: lit/SymbolFile/PDB/Inputs/VariablesLocationsTest.script
=
aleksandr.urakov added subscribers: zturner, jasonmolenda, labath.
aleksandr.urakov added a comment.
As for aligned stack cross-platform problems, I mean also problems with stack
unwinding. They seem to appear on non-Windows too. It's because
`x86AssemblyInspectionEngine` doesn't support stack a
aleksandr.urakov added a comment.
Otherwise LGTM!
Comment at: unittests/Utility/StatusTest.cpp:68-74
+ EXPECT_STREQ("Access is denied. ", s.AsCString());
+
+ s.SetError(ERROR_IPSEC_IKE_TIMED_OUT, ErrorType::eErrorTypeWin32);
+ EXPECT_STREQ("Negotiation timed out ", s.AsCStri
aleksandr.urakov added inline comments.
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:801-804
+ if (m_filespec_ap.get())
+return m_filespec_ap->GetSize();
+
+ m_filespec_ap.reset(new FileSpecList());
I'm afraid of a race condition here.
aleksandr.urakov accepted this revision.
aleksandr.urakov added a comment.
This revision is now accepted and ready to land.
LGTM after https://reviews.llvm.org/D53094 will be done!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53096
___
lldb-c
aleksandr.urakov added a comment.
In https://reviews.llvm.org/D53086#1263002, @zturner wrote:
> Do we have access to the current instruction pointer? That's what you need
> to find the correct FPO record.
No, it seems that we haven't. But if there's the only one
`S_DEFRANGE_FRAMEPOINTER_REL`
aleksandr.urakov added a subscriber: labath.
aleksandr.urakov added a comment.
Hello!
I just have tried to patch `CPlusPlusNameParser` in the way to support MSVC
demangled names, but there is a problem. `CPlusPlusNameParser` splits an
incoming name in tokens with `clang::Lexer`. I've lexed the
aleksandr.urakov added a comment.
In https://reviews.llvm.org/D52461#1265633, @zturner wrote:
> Just handle the `anonymous namespace' thing specially before passing to
> `CPlusPlusNameParser`.
Yes, it's an interesting idea to somehow preprocess an MSVC demangled name and
make a GCC demangled
aleksandr.urakov added a comment.
Yes, I mean exactly the same case. For sequences like you've written yes, the
unwind should work, but there must be some problems with saved registers.
`x86AssemblyInspectionEngine` doesn't handle instructions like `and %-8, %esp`,
so the register save would wo
aleksandr.urakov added a comment.
Yes, it's simpler to move it to the `CPlusPlusLanguage::MethodName` (or
`CPlusPlusNameParser`?) I think. The only question left is how to differentiate
MSVC demangled names from others? May be it would be ok to treat name as an
MSVC name if it contains a grave
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: zturner, clayborg.
aleksandr.urakov added a project: LLDB.
Herald added a subscriber: lldb-commits.
This patch makes Windows threads to compare by a thread ID, not by a handle.
It's because the same thread can have differen
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: labath, zturner, jingham.
aleksandr.urakov added a project: LLDB.
Herald added a subscriber: lldb-commits.
This patch extends the `SBThreadPlan` to allow retrieving of thread plans for
scripted steps.
Repository:
rLLDB
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: zturner, asmith, labath.
aleksandr.urakov added a project: LLDB.
Herald added a subscriber: lldb-commits.
This patch adds possibility of searching a public symbol with name and type in
a symbol file, not only in a symtab. I
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: zturner, asmith, labath.
aleksandr.urakov added a project: LLDB.
Herald added a subscriber: lldb-commits.
This patch improves performance of `SymbolFilePDB` on huge executables in two
ways:
- cache names of public symbols
aleksandr.urakov added a comment.
Thank you!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344729: [Windows] Fix threads comparison on Windows
(authored by aleksandr.urakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53357?vs=16
aleksandr.urakov added a comment.
In https://reviews.llvm.org/D53086#1267988, @labath wrote:
> The thing that's not clear to me is: are you specifically interested in
> unwinding from these kinds of functions **without debug info**? Because it
> sounds to me like the info Zachary provided is en
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: labath, zturner, jasonmolenda,
stella.stamenova.
aleksandr.urakov added a project: LLDB.
Herald added subscribers: lldb-commits, abidh.
This patch fixes issues with a stack realignment.
MSVC maintains two frame pointers (`
aleksandr.urakov added a comment.
Thank you!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53375
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aleksandr.urakov added a comment.
Thanks!
Yes, I've added this exactly to allow usage of a scripted plan from another
scripted plan. Sure, I will add a test for this :) But I can't figure out how
this part is tested, can you explain me this a little, please?
Repository:
rLLDB LLDB
https://
aleksandr.urakov added a comment.
Thanks for explanations!
I completely agree with you that it were better (and simpler) to implement it
with the help of debug info. And if I will improve it later, I'll also choose
the way you have described. But the problem is that this sketch was made a
coup
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: clayborg, labath, granata.enrico.
aleksandr.urakov added a project: LLDB.
Herald added subscribers: lldb-commits, teemperor, abidh.
This patch processes the case of retrieving a virtual base when the object is
already read
aleksandr.urakov added a comment.
In https://reviews.llvm.org/D53506#1270893, @zturner wrote:
> What's missing that you're unable to restore the VBase offset properly?
If I understand correctly, in the PDB there is only info about offset to
VTablePtr and index in VTable, so there is enough inf
aleksandr.urakov added a comment.
In https://reviews.llvm.org/D53375#1271336, @Hui wrote:
> I think parsing types e.g. SymbolFilePDB::ParseTypes also has speed bumps.
> Will be good to have them cached too.
We are already caching them, see `m_types` field.
Repository:
rLLDB LLDB
https://r
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345013: [PDB] Improve performance of the PDB DIA plugin
(authored by aleksandr.urakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53375?v
aleksandr.urakov added a comment.
Ok, I'll do it, thanks!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53361
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aleksandr.urakov added a comment.
Ok, I'll reimplement this, thanks!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53368
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aleksandr.urakov added a reviewer: zturner.
aleksandr.urakov added a comment.
In https://reviews.llvm.org/D53506#1270933, @zturner wrote:
> So, the point is, just because we don't have access to the info via DIA
> doesn't mean we won't have access to the info once the native pdb plugin is
> com
aleksandr.urakov accepted this revision.
aleksandr.urakov added a comment.
Looks good to me, thank you!
https://reviews.llvm.org/D53511
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
aleksandr.urakov updated this revision to Diff 170852.
aleksandr.urakov added a comment.
I've added the test. Can you see, please, is it ok?
https://reviews.llvm.org/D53361
Files:
include/lldb/API/SBThreadPlan.h
packages/Python/lldbsuite/test/functionalities/step_scripted/Makefile
package
aleksandr.urakov updated this revision to Diff 170889.
aleksandr.urakov added a comment.
I've implemented things as Greg have said, except for a few moments:
- haven't added `AddSymbols` to `SymbolVendor` because it is not used anywhere,
and we can just use `SymbolFile::AddSymbols` directly insi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345247: [API] Extend the `SBThreadPlan` interface (authored
by aleksandr.urakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53361?vs=1708
aleksandr.urakov marked 5 inline comments as done.
aleksandr.urakov added a comment.
Ah, yes, sure! It's my mistake. I didn't pay attention to the fact that a
symtab owns symbols. I'll update the patch, thanks!
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:1344-1
aleksandr.urakov updated this revision to Diff 171056.
aleksandr.urakov marked 3 inline comments as done.
https://reviews.llvm.org/D53368
Files:
include/lldb/Symbol/SymbolFile.h
include/lldb/Symbol/SymbolVendor.h
source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
source/Plugins/SymbolFile/PD
aleksandr.urakov added a comment.
Yes, I'll implement it tomorrow (I'm already OOO now), thanks. But is it really
necessary to check the number of symbols added if we must to calculate /
finalize the symtab after getting it from object file anyway? May be just
always do it after creation and pr
aleksandr.urakov updated this revision to Diff 171267.
aleksandr.urakov added a comment.
Herald added subscribers: arichardson, emaste.
Herald added a reviewer: espindola.
That's done!
https://reviews.llvm.org/D53368
Files:
include/lldb/Symbol/SymbolFile.h
include/lldb/Symbol/SymbolVendor.h
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: zturner, stella.stamenova.
aleksandr.urakov added a project: LLDB.
Herald added a subscriber: lldb-commits.
This one fixes tests compilation preserving the type of the `scope` parameter.
Repository:
rLLDB LLDB
https://r
aleksandr.urakov added a comment.
Ok, thanks! I didn't know about such rule. I'll reduce usages of auto :)
As for such an obvious changes, is it ok to commit them without a review? Or is
it still preferable to create reviews for them?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53749
aleksandr.urakov added a comment.
Ok, good!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53749
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB345374: [PDB] Fix `SymbolFilePDBTests` after r345313
(authored by aleksandr.urakov, committed by ).
Changed prior to c
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: zturner, stella.stamenova, labath.
aleksandr.urakov added a project: LLDB.
Herald added a subscriber: lldb-commits.
When evaluating expressions the generic arguments registers are required by
ABI. This patch defines them.
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: zturner, asmith, stella.stamenova.
aleksandr.urakov added a project: LLDB.
Herald added subscribers: lldb-commits, teemperor, JDevlieghere, aprantl.
This patch contains several small fixes, which makes it possible to evaluat
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: jingham, zturner, boris.ulasevich.
aleksandr.urakov added a project: LLDB.
Herald added subscribers: lldb-commits, teemperor.
This patch fixes the next situation. On Windows `clang-cl` makes no stub before
the `main` functi
aleksandr.urakov added a comment.
Thanks!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53753
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345385: [Windows] Define generic arguments registers for
Windows x64 (authored by aleksandr.urakov, committed by ).
Herald
aleksandr.urakov added a comment.
In https://reviews.llvm.org/D52618#1278442, @zturner wrote:
> Is this still blocked on anything?
It seems that it's not blocked on anything. The test, as you have mentioned in
the earlier message, is already duplicating only `RUN: lldb-test` lines, there
are
aleksandr.urakov marked 2 inline comments as done.
aleksandr.urakov added inline comments.
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:819
if (!section_list)
m_entry_point_address.SetOffset(offset);
else
Hui wrote:
> This still ne
aleksandr.urakov updated this revision to Diff 171489.
aleksandr.urakov marked 2 inline comments as done.
aleksandr.urakov added a comment.
Update the diff according to comments.
https://reviews.llvm.org/D53759
Files:
lit/SymbolFile/PDB/Inputs/ExpressionsTest.cpp
lit/SymbolFile/PDB/Inputs/E
aleksandr.urakov updated this revision to Diff 171496.
aleksandr.urakov added a comment.
Thanks! I've updated the diff according to comments.
https://reviews.llvm.org/D53761
Files:
include/lldb/API/SBModule.h
packages/Python/lldbsuite/test/functionalities/expr-entry-bp/Makefile
packages/
aleksandr.urakov added a comment.
Ping! Can you look at this, please?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53435
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aleksandr.urakov added a comment.
Thank you!
https://reviews.llvm.org/D53761
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aleksandr.urakov marked 2 inline comments as done.
aleksandr.urakov added a comment.
Thank you! I'll update the patch.
Comment at: source/Plugins/Process/Utility/RegisterContextLLDB.h:195
// Get the CFA register for a given frame.
+ bool ReadFrameAddress(lldb::RegisterKin
aleksandr.urakov updated this revision to Diff 171650.
aleksandr.urakov marked 2 inline comments as done.
aleksandr.urakov added a comment.
Update the patch according to comments.
https://reviews.llvm.org/D53435
Files:
include/lldb/Symbol/UnwindPlan.h
source/Plugins/Process/Utility/Register
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB345577: [x86] Fix issues with a realigned stack in MSVC
compiled applications (authored by aleksandr.urakov, committed by ).
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53435
Files:
include/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345577: [x86] Fix issues with a realigned stack in MSVC
compiled applications (authored by aleksandr.urakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://rev
aleksandr.urakov accepted this revision.
aleksandr.urakov added a comment.
This revision is now accepted and ready to land.
Looks awesome, thank you!
https://reviews.llvm.org/D53822
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://li
aleksandr.urakov added a comment.
Ping! Can you take a look at this, please?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53506
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
aleksandr.urakov updated this revision to Diff 171707.
aleksandr.urakov retitled this revision from "[PDB] Introduce `PDBNameParser`"
to "[PDB] Introduce `MSVCUndecoratedNameParser`".
aleksandr.urakov edited the summary of this revision.
aleksandr.urakov added a reviewer: shafik.
aleksandr.urakov
aleksandr.urakov added a comment.
In https://reviews.llvm.org/D52461#1281742, @zturner wrote:
> What do you think?
Yes, it's a really cool idea! When I was starting the implementation of the
parser from this patch, I thought that it would be good to have mangled names
instead - then we could
aleksandr.urakov accepted this revision.
aleksandr.urakov added a comment.
This revision is now accepted and ready to land.
Looks good, thanks!
https://reviews.llvm.org/D53951
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345815: [Windows] A basic implementation of memory
allocations in a debuggee process (authored by aleksandr.urakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
http
aleksandr.urakov marked 2 inline comments as done.
aleksandr.urakov added a comment.
Thank you for comments! I've updated the patch.
https://reviews.llvm.org/D52461
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-
aleksandr.urakov updated this revision to Diff 172101.
https://reviews.llvm.org/D52461
Files:
lit/SymbolFile/PDB/Inputs/AstRestoreTest.cpp
lit/SymbolFile/PDB/ast-restore.test
source/Plugins/Language/CPlusPlus/CMakeLists.txt
source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
source/
aleksandr.urakov updated this revision to Diff 172102.
https://reviews.llvm.org/D52461
Files:
lit/SymbolFile/PDB/Inputs/AstRestoreTest.cpp
lit/SymbolFile/PDB/ast-restore.test
source/Plugins/Language/CPlusPlus/CMakeLists.txt
source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
source/
aleksandr.urakov added a comment.
Ping! Can you look at this, please?
https://reviews.llvm.org/D53368
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aleksandr.urakov added a comment.
This commit breaks the Windows build.
Repository:
rL LLVM
https://reviews.llvm.org/D53915
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aleksandr.urakov added a comment.
It's ok, I was able to fix it myself. Here is the commit: r345956
Repository:
rL LLVM
https://reviews.llvm.org/D53915
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
aleksandr.urakov added a comment.
Thank you!
https://reviews.llvm.org/D53368
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB345957: [Symbol] Search symbols with name and type in a
symbol file (authored by aleksandr.urakov, committed by ).
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53368
Files:
include/lldb/Symbo
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: zturner, stella.stamenova.
aleksandr.urakov added a project: LLDB.
Herald added subscribers: lldb-commits, teemperor.
This patch fixes the NativePDB tests to make them work from x86 command line
too.
Repository:
rLLDB L
aleksandr.urakov added a comment.
Thanks!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D54031
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345974: [NativePDB] Make tests work on x86 too (authored by
aleksandr.urakov, committed by ).
Herald added a subscriber: l
aleksandr.urakov added a comment.
Thanks for catching that! Unfortunately, I have no access to MacOS, can you
provide some more info about failure, please?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53368
___
lldb-commits mailing list
lldb
aleksandr.urakov added a comment.
I'm not sure, but have an assumption. Here is the first green build of the
green-dragon-24: http://green.lab.llvm.org/green/job/lldb-cmake/12090/ It
became green after three changes, one of them is your revert of my commit,
while another is Zachary's "Fix the l
aleksandr.urakov added a comment.
Thank you!
https://reviews.llvm.org/D52461
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aleksandr.urakov reopened this revision.
aleksandr.urakov added a comment.
This revision is now accepted and ready to land.
@davide You are right, this patch was the cause of the failure, sorry for that.
It seems that I've found a generic issue with this patch. Thanks again for
pointing to that!
aleksandr.urakov added a comment.
Ping! Is it ok to proceed with it? Does anyone have objections?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53506
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
aleksandr.urakov added a comment.
Yes, sure. It happens in the following functions:
- `Module::ResolveSymbolContextForAddress`
- `DynamicLoaderHexagonDYLD::SetRendezvousBreakpoint` through
`findSymbolAddress`
- `DynamicLoaderHexagonDYLD::RendezvousBreakpointHit` through
`findSymbolAddress`
- `J
aleksandr.urakov accepted this revision.
aleksandr.urakov added a comment.
In https://reviews.llvm.org/D54053#1286653, @zturner wrote:
> Bleh, I think I found a problem with this approach. Since we assume
> everything is a namespace, it can lead to ambiguities. I think we need to
> actually c
aleksandr.urakov accepted this revision.
aleksandr.urakov added a comment.
This revision is now accepted and ready to land.
Looks good, thank you!
The only question is performance, haven't you checked how much time takes the
preprocessing on huge PDBs? Intuitively it seems that it shouldn't take
aleksandr.urakov added a comment.
In https://reviews.llvm.org/D54216#1291852, @zturner wrote:
> I checked on clang.pdb. For my local build of LLVM this about 780MB. It's
> quite slow in debug build (14 seconds for `ParseSectionContribs` and 60
> seconds for `PreprocessTpiStream`), but in rele
aleksandr.urakov added a comment.
This change looks reasonable to me for solving the problem with the current
`LF_NESTTYPE` approach. But I'm not sure... Now we all the same need to analyze
mangled names and make a decision based on this. Does the current `LF_NESTTYPE`
approach still has advant
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346669: [ClangASTContext] Extract VTable pointers from C++
objects (authored by aleksandr.urakov, committed by ).
Herald a
1 - 100 of 331 matches
Mail list logo
