aleksandr.urakov added a comment.
Otherwise LGTM!
================
Comment at: unittests/Utility/StatusTest.cpp:68-74
+ EXPECT_STREQ("Access is denied. ", s.AsCString());
+
+ s.SetError(ERROR_IPSEC_IKE_TIMED_OUT, ErrorType::eErrorTypeWin32);
+ EXPECT_STREQ("Negotiation timed out ", s.AsCString());
+
+ s.SetError(16000, ErrorType::eErrorTypeWin32);
+ EXPECT_STREQ("unknown error", s.AsCString());
----------------
I'm not sure, can we rely on the fact that messages are the same in different
versions of Windows?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53092
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits