aleksandr.urakov added a comment.

Thanks for explanations!

I completely agree with you that it were better (and simpler) to implement it 
with the help of debug info. And if I will improve it later, I'll also choose 
the way you have described. But the problem is that this sketch was made a 
couple of months ago, and it seems work, so may be it is not a so bad idea to 
use it (and not redo it now to work with a debug info)? Besides, in ideal 
implementation we would still need something like this to cover that rare cases 
with prologues and epilogues.

I've been stashing a lot of changes for past few months, and now the stash is 
big enough, so I'm trying to send it all on review. Now I understand that it's 
not a good strategy :) The such approach makes inconvenient situations like 
this, so I think it is better to send reviews as soon as possible. Sorry for 
that.

I've brushed the sketch and have sent it for review last week, here it is: 
https://reviews.llvm.org/D53435


https://reviews.llvm.org/D53086



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to