aleksandr.urakov added a comment.

In https://reviews.llvm.org/D52461#1281742, @zturner wrote:

> What do you think?


Yes, it's a really cool idea! When I was starting the implementation of the 
parser from this patch, I thought that it would be good to have mangled names 
instead - then we could retrieve fully structured names (with all its scope 
specifiers, template parameters etc.), but I didn't know that we actually have 
them on the lower level!

I want to join the development of the new PDB plugin, but some time later - may 
be in a month or two. I want to contribute now all changes I made to support 
expressions on Windows, and then I have some LLVM unrelated work to do. But I 
think that the way you suggest to solve the problem from the patch is the 
really right way to do it, and I'm planning to implement it when I'll join the 
new plugin development.

But is the MSVC demangled names parsing really necessary for 
`CPlusPlusLanguage`? Can such names ever somehow occur there? May be (if they 
can't) we could move this parser back to the old PDB plugin, and then drop it 
as a weirder solution when the new plugin will be done? Then we could commit 
this as a solution for the old PDB plugin to proceed with some dependent (and 
not related to the old PDB plugin) patches?


https://reviews.llvm.org/D52461



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to