aleksandr.urakov accepted this revision.
aleksandr.urakov added a comment.
This revision is now accepted and ready to land.

Looks good, thank you!

The only question is performance, haven't you checked how much time takes the 
preprocessing on huge PDBs? Intuitively it seems that it shouldn't take too 
much time (n*log(n) where n is the count of LF_NESTTYPE records), but may be 
you have checked this?


https://reviews.llvm.org/D54216



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to