labath wrote:
> That would be easy to find out on Compiler Explorer :-)
I was curious, so I [tried it out](https://godbolt.org/z/E5j5afqso). The answer
appears to be "no". :)
https://github.com/llvm/llvm-project/pull/120226
___
lldb-commits mailing l
DavidSpickett wrote:
I assume the macro is `_ALL_SOURCE` with the leading underscore, you put
`ALL_SOURCE` in the title and description.
I see that
https://github.com/llvm/llvm-project/blob/d66f653c8db90d0c643f8f2740bbdc01bf647f18/third-party/unittest/CMakeLists.txt#L18
also does this.
https
labath wrote:
I think this is fine. We could come up with an abstraction for this, but I
don't think it's necessary for a simple change like this. Like
@DhruvSrivastavaX said, the rest of the ptrace calls are going to be in
platform-specific code.
https://github.com/llvm/llvm-project/pull/12
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/120390
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dhruv Srivastava
Date: 2024-12-20T11:08:17Z
New Revision: cf0bc8d0321a55f3f166131ec3fe45cdef7d5e3c
URL:
https://github.com/llvm/llvm-project/commit/cf0bc8d0321a55f3f166131ec3fe45cdef7d5e3c
DIFF:
https://github.com/llvm/llvm-project/commit/cf0bc8d0321a55f3f166131ec3fe45cdef7d5e3c.diff
L
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/120390
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> > In which case, GetDIEToType().lookup(decl_die) will return a nullptr. This
> > is already a bit iffy because some of the surrounding code assumes we don't
> > call CompleteTypeFromDWARF with a nullptr Type*. E.g., CompleteEnumType
> > blindly dereferences it (though enums
https://github.com/labath commented:
I'm pretty sure this is not correct. `p_offset` is an offset in the file. It
tells you nothing about how the file is mapped into memory.
What you're *probably* running into is an executable whose base address
(`p_vaddr` of the first `PT_LOAD` segment) is no
@@ -11,6 +11,11 @@ if(APPLE)
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS}
-Wl,-sectcreate,__TEXT,__info_plist,${CMAKE_CURRENT_BINARY_DIR}/lldb-Info.plist")
endif()
+if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
+ remove_definition
Michael137 wrote:
> As an alternative, we might be able to make the die-to-type map shared
> between all symbol files in a debug map (similar to how "unique dwarf ast
> type map" is shared).
Yea I considered that, but I was concerned with the unforeseen complications
this might have. Particul
Michael137 wrote:
> Maybe, but I don't expect the test to be pretty. What I (sometimes) do in
> these cases is to make the test bidirectional, i.e., have two compile unit
> where each one has a definition for a type declared/used in the other one.
> This way, you're guaranteed to hit the error
Author: Michael Buch
Date: 2024-12-20T12:16:19Z
New Revision: 000febd0290698728abd9e23da6b27969c529177
URL:
https://github.com/llvm/llvm-project/commit/000febd0290698728abd9e23da6b27969c529177
DIFF:
https://github.com/llvm/llvm-project/commit/000febd0290698728abd9e23da6b27969c529177.diff
LOG:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/120279
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> I would recommend not squashing, because that will make it much easier to
> find the incorrect change if there are regressions.
I agree, but "squash and merge" is the only strategy enabled for this
repository. Could you create a separate PR (or two, but probably not eight)
wit
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/120569
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/120569
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -235,6 +235,40 @@ Do a source level single step in the currently selected
thread
(lldb) step
(lldb) s
+Ignore a function when doing a source level single step in
+~~
+
+.. code-block:: shell
+
+ (gdb) skip abc
+
https://github.com/labath approved this pull request.
Nice.
https://github.com/llvm/llvm-project/pull/120456
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/SixWeining commented:
Could you add some tests in `lldb/test/Shell/Register/` ?
https://github.com/llvm/llvm-project/pull/120664
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
@@ -27,6 +27,14 @@
// struct iovec definition
#include
+#ifndef NT_LARCH_LSX
SixWeining wrote:
Why not use the `NT_LOONGARCH_LSX` defined in elf.h?
https://github.com/llvm/llvm-project/pull/120664
___
lldb-commits
https://github.com/SixWeining edited
https://github.com/llvm/llvm-project/pull/120664
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> > However, it shows an issue that is a concern actually: Do we really want to
> > prefer gmake over make on all platforms?
>
> I was using RHEL9 today and it has gmake and make but they are both GNU make.
> So I think we're safe using gmake if we find it.
On my system (Gentoo)
oltolm wrote:
Is there still some TODO for me?
https://github.com/llvm/llvm-project/pull/119103
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/GeorgeHuyubo created
https://github.com/llvm/llvm-project/pull/120814
This PR include two changes:
1. Change debuginfod cache file name to include origin file name, the new file
name would be something like:
llvmcache-13267c5f5d2e3df472c133c8efa45fb3331ef1ea-liblzma.so.5.2.2.
ZequanWu wrote:
> This particular example was fixed by
> https://github.com/llvm/llvm-project/pull/120569 but this still feels a
> little inconsistent. I'm not entirely sure we can get into that situation
> after that patch anymore. So the only test-case I could come up with was the
> unit-te
https://github.com/ZequanWu approved this pull request.
LGTM, thanks for fixing it.
https://github.com/llvm/llvm-project/pull/120809
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This addresses an issue encountered when investigating
https://github.com/llvm/llvm-project/pull/120569.
In `ParseTypeFromDWARF`, we insert the parsed type into `UniqueDWARFASTTypeMap`
using the typename
Michael137 wrote:
If we don't want to introduce language specifics into `UniqueDWARFASTTypeList`,
we could just not update `MapDeclDIEToDefDIE` with the `Declaration` info of
the definition when we're dealing with C++.
On the other hand, assuming the debuggee doesn't violate ODR might be a bit
slydiman wrote:
The test `lldb-api::TestExprDiagnostics.py` is broken after this patch.
https://lab.llvm.org/buildbot/#/builders/195/builds/2683
https://github.com/llvm/llvm-project/pull/120784
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/120809
This addresses an issue encountered when investigating
https://github.com/llvm/llvm-project/pull/120569.
In `ParseTypeFromDWARF`, we insert the parsed type into `UniqueDWARFASTTypeMap`
using the typename an
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/120784
>From 88f6c19a87e82f1cc0c589029d8eb288ec53eaba Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Fri, 20 Dec 2024 10:35:47 -0800
Subject: [PATCH] [lldb] Expose structured errors in SBError
Building on to
kastiglione wrote:
for anyone interested: I override `s` to take an optional argument, so that it
behaves like `sif`. In my .lldbinit:
```
command unalias s
command regex s
s/^$/step/
s/(.+)/sif %1/
```
https://github.com/llvm/llvm-project/pull/120740
__
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/120569
>From 9aa49efdcde5887e8de6bcd6cfbb08c0a499e24b Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 19 Dec 2024 12:25:19 +
Subject: [PATCH 1/5] [lldb][SymbolFileDWARF] CompleteType: Lookup type in the
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/120784
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -183,6 +186,9 @@ class Status {
/// NULL otherwise.
const char *AsCString(const char *default_error_str = "unknown error") const;
+ /// Get the error in machine-readable form.
+ StructuredData::ObjectSP GetErrorData() const;
JDevlieghere wrote:
W
adrian-prantl wrote:
> LGTM. nit: I'd have called the API `SBError::GetStructuredError`.
I have no strong feelings about this — I chose GetErrorData, because that's
what `SBStructuredData SBCommandReturnObject::GetErrorData()` is called.
https://github.com/llvm/llvm-project/pull/120784
___
https://github.com/kuilpd updated
https://github.com/llvm/llvm-project/pull/115005
>From 5290832b802d98b9d293b6910c0837911ec490c4 Mon Sep 17 00:00:00 2001
From: Ilia Kuklin
Date: Mon, 4 Nov 2024 14:33:45 +0500
Subject: [PATCH 1/6] [lldb] Analyze enum promotion type during parsing
---
clang/in
@@ -2299,11 +2301,103 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_va
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/120784
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2024-12-20T13:02:54-08:00
New Revision: d9cc37fea7b02954079ca59e8f7f28cffacc7e9e
URL:
https://github.com/llvm/llvm-project/commit/d9cc37fea7b02954079ca59e8f7f28cffacc7e9e
DIFF:
https://github.com/llvm/llvm-project/commit/d9cc37fea7b02954079ca59e8f7f28cffacc7e9e.diff
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/120457
>From 4131b8c5af83a219efb2513a1ac90e8b9877d2ef Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 17 Dec 2024 17:45:34 -0800
Subject: [PATCH 1/5] [lldb-dap] Ensure the IO forwarding threads are managed
by t
llvmbot wrote:
@llvm/pr-subscribers-debuginfo
Author: None (GeorgeHuyubo)
Changes
This PR include two changes:
1. Change debuginfod cache file name to include origin file name, the new file
name would be something like:
llvmcache-13267c5f5d2e3df472c133c8efa45fb3331ef1ea-liblzma.so.5.2.2.d
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c1e7e4500c6e3b921f5e0cda8ba8d8d66e086db6
58134726a34790fa23db0fe18e3cb4cc178a389b --e
https://github.com/GeorgeHuyubo converted_to_draft
https://github.com/llvm/llvm-project/pull/120814
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/120814
>From 6923737d728191816567e7874a01c5dfce68bfde Mon Sep 17 00:00:00 2001
From: George Hu
Date: Fri, 20 Dec 2024 15:20:00 -0800
Subject: [PATCH 1/2] [lldb] Change debuginfod cache file name to include
origin
https://github.com/labath commented:
@JDevlieghere, it looks like the llvm part of this is going to land imminently,
so maybe this is a good time to take another look at this. In particular, I
expect you'll want to say something about the use of the string "lldb" in
identifier names.
https://
@@ -0,0 +1,95 @@
+
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,95 @@
+
labath wrote:
delete empty line
https://github.com/llvm/llvm-project/pull/119716
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,95 @@
+
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,101 @@
+//===-- Telemetry.h --*- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,95 @@
+
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,101 @@
+//===-- Telemetry.h --*- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/119716
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -108,6 +108,9 @@ endfunction(add_lldb_test_dependency)
add_lldb_test_dependency(lldb)
add_lldb_test_dependency(lldb-test)
+# Enable Telemetry for testing.
+target_compile_definitions(lldb PRIVATE -DTEST_TELEMETRY)
+
labath wrote:
This doesn't do what you t
https://github.com/DavidSpickett approved this pull request.
LGTM.
Please correct the macro name in the title/description then I'll merge this.
https://github.com/llvm/llvm-project/pull/120607
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/DavidSpickett commented:
Please note in the PR description that this is for live processes and core
files (at least it looks like it is). I would also like to see test cases for
both scenarios.
Are your vector registers ever absent?
Because in AArch64's case we assume we al
@@ -48,6 +48,10 @@ bool RegisterContextCorePOSIX_loongarch64::ReadGPR() {
return true; }
bool RegisterContextCorePOSIX_loongarch64::ReadFPR() { return true; }
+bool RegisterContextCorePOSIX_loongarch64::ReadLSX() { return true; }
+
+bool RegisterContextCorePOSIX_loongarch64:
@@ -27,6 +27,14 @@
// struct iovec definition
#include
+#ifndef NT_LARCH_LSX
DavidSpickett wrote:
Our usual pattern is:
```
#ifndef THE_MACRO
#define THE_MACRO the_value_it_is_in_the_latest_kernel_headers
#endif
```
This allows you to build with older kernel
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/120664
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> > As an alternative, we might be able to make the die-to-type map shared
> > between all symbol files in a debug map (similar to how "unique dwarf ast
> > type map" is shared).
>
> Yea I considered that, but I was concerned with the unforeseen complications
> this might ha
@@ -11,6 +11,11 @@ if(APPLE)
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS}
-Wl,-sectcreate,__TEXT,__info_plist,${CMAKE_CURRENT_BINARY_DIR}/lldb-Info.plist")
endif()
+if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
+ remove_definition
@@ -173,6 +178,63 @@ ExceptionBreakpoint *DAP::GetExceptionBreakpoint(const
lldb::break_id_t bp_id) {
return nullptr;
}
+llvm::Error DAP::ConfigureIO(std::optional overrideOut,
+ std::optional overrideErr) {
+ auto *inull = lldb_private::FileSys
@@ -138,15 +140,20 @@ struct SendEventRequestHandler : public
lldb::SBCommandPluginInterface {
struct DAP {
llvm::StringRef debug_adaptor_path;
+ std::optional &log;
labath wrote:
This isn't that big of an issue but I'd still consider using a plain pointe
@@ -1099,6 +1098,14 @@ void request_disconnect(DAP &dap, const
llvm::json::Object &request) {
dap.broadcaster.BroadcastEventByType(eBroadcastBitStopProgressThread);
dap.progress_event_thread.join();
}
+ if (dap.stdout_forward_thread.joinable()) {
+dap.pout.Close
@@ -5027,43 +5019,77 @@ int main(int argc, char *argv[]) {
}
#endif
+ std::optional log = std::nullopt;
+ const char *log_file_path = getenv("LLDBDAP_LOG");
+ if (log_file_path)
+log.emplace(log_file_path);
+
// Initialize LLDB first before we do anything.
lldb:
@@ -173,6 +178,63 @@ ExceptionBreakpoint *DAP::GetExceptionBreakpoint(const
lldb::break_id_t bp_id) {
return nullptr;
}
+llvm::Error DAP::ConfigureIO(std::optional overrideOut,
+ std::optional overrideErr) {
+ auto *inull = lldb_private::FileSys
@@ -5027,43 +5019,77 @@ int main(int argc, char *argv[]) {
}
#endif
+ std::optional log = std::nullopt;
+ const char *log_file_path = getenv("LLDBDAP_LOG");
+ if (log_file_path)
+log.emplace(log_file_path);
+
// Initialize LLDB first before we do anything.
lldb:
@@ -52,16 +52,24 @@ struct StreamDescriptor {
struct InputStream {
StreamDescriptor descriptor;
- bool read_full(std::ofstream *log, size_t length, std::string &text);
+ explicit InputStream(StreamDescriptor descriptor)
+ : descriptor(std::move(descriptor)) {};
- b
@@ -173,6 +178,63 @@ ExceptionBreakpoint *DAP::GetExceptionBreakpoint(const
lldb::break_id_t bp_id) {
return nullptr;
}
+llvm::Error DAP::ConfigureIO(std::optional overrideOut,
labath wrote:
optional is overkill in most of the cases (and confusing in the r
kastiglione wrote:
Should this also mention `sif`? When I want to skip one or more functions when
stepping, I run `sif desiredFunction`.
https://github.com/llvm/llvm-project/pull/120740
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:/
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/120569
>From 9aa49efdcde5887e8de6bcd6cfbb08c0a499e24b Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 19 Dec 2024 12:25:19 +
Subject: [PATCH 1/5] [lldb][SymbolFileDWARF] CompleteType: Lookup type in the
@@ -235,6 +235,23 @@ Do a source level single step in the currently selected
thread
(lldb) step
(lldb) s
+Ignore a function when doing a source level single step in
+~~
+
+.. code-block:: shell
+
+ (gdb) skip abc
+
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/120740
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/GeorgeHuyubo edited
https://github.com/llvm/llvm-project/pull/120655
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
Building on top of previous work that exposed expression diagnostics via
SBCommandReturnObject, this patch generalizes the support to expose any SBError
as machine-readable structured data. One use-cas
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/120784
Building on top of previous work that exposed expression diagnostics via
SBCommandReturnObject, this patch generalizes the support to expose any SBError
as machine-readable structured data. One use-case o
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
8c0090030bf89df7e0dbe5827a83d52627b2c87f...88f6c19a87e82f1cc0c589029d8eb288ec53eaba
lldb/
ZequanWu wrote:
> Just tried this. Unfortunately [we remove the CompilerType from the
> `GetForwardDeclCompilerTypeToDIE`](https://github.com/llvm/llvm-project/blob/d7ddc976d544528fe7f16882f5bec66c3b2a7884/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp#L1577)
> map inside of `Complete
ZequanWu wrote:
> > > As an alternative, we might be able to make the die-to-type map shared
> > > between all symbol files in a debug map (similar to how "unique dwarf ast
> > > type map" is shared).
> >
> >
> > Yea I considered that, but I was concerned with the unforeseen
> > complication
https://github.com/kuilpd created
https://github.com/llvm/llvm-project/pull/120794
None
>From b5cb9a262a5e1bdb19eb72e7e357c98e90fa9f4e Mon Sep 17 00:00:00 2001
From: Ilia Kuklin
Date: Sat, 21 Dec 2024 02:04:35 +0500
Subject: [PATCH] Negate is_signed variable for argument isUnsigned
---
lldb/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ilia Kuklin (kuilpd)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/120794.diff
1 Files Affected:
- (modified) lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp (+1-1)
``diff
diff --git a/lldb/source/
kuilpd wrote:
This change doesn't really affect anything in lldb yet, but will be used and
tested afterwards in #115005
https://github.com/llvm/llvm-project/pull/120794
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/c
@@ -8544,7 +8524,8 @@ clang::EnumConstantDecl
*TypeSystemClang::AddEnumerationValueToEnumerationType(
bool is_signed = false;
underlying_type.IsIntegerType(is_signed);
- llvm::APSInt value(enum_value_bit_size, is_signed);
+ // APSInt constructor's sign argument is isUns
keith wrote:
did this one reland somewhere?
https://github.com/llvm/llvm-project/pull/114973
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/120166
>From d5dfb15e1ae90ade9b25374eefc605cc36685a43 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 16 Dec 2024 16:04:01 -0800
Subject: [PATCH 1/2] Make workaround for the Dynamic loader issue
---
.../Minid
Jlalond wrote:
@labath I went with your suggestion as the better idea. I ended up just writing
'LLDB' to the stream, because the current API behavior for MinidumpParser is to
return an empty ArrayRef. So there was no direct way to detect an existing but
empty stream. For now I just set the che
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/120166
>From d5dfb15e1ae90ade9b25374eefc605cc36685a43 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 16 Dec 2024 16:04:01 -0800
Subject: [PATCH 1/3] Make workaround for the Dynamic loader issue
---
.../Minid
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/120457
>From 4131b8c5af83a219efb2513a1ac90e8b9877d2ef Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 17 Dec 2024 17:45:34 -0800
Subject: [PATCH 1/4] [lldb-dap] Ensure the IO forwarding threads are managed
by t
@@ -52,16 +52,24 @@ struct StreamDescriptor {
struct InputStream {
StreamDescriptor descriptor;
- bool read_full(std::ofstream *log, size_t length, std::string &text);
+ explicit InputStream(StreamDescriptor descriptor)
+ : descriptor(std::move(descriptor)) {};
- b
@@ -138,15 +140,20 @@ struct SendEventRequestHandler : public
lldb::SBCommandPluginInterface {
struct DAP {
llvm::StringRef debug_adaptor_path;
+ std::optional &log;
ashgti wrote:
Removed the optional and just passed a plain pointer instead.
https://gith
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/120171
>From fcad0a35ec2e10ec90591079d05c3b1726d22967 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 16 Dec 2024 17:57:44 -0800
Subject: [PATCH 1/6] Add external progress bit category
---
lldb/include/lldb/C
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/120784
>From 59e2d804d49b549f0d3679caf72ed29493e8fd01 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Fri, 20 Dec 2024 10:35:47 -0800
Subject: [PATCH] [lldb] Expose structured errors in SBError
Building on to
@@ -173,6 +178,63 @@ ExceptionBreakpoint *DAP::GetExceptionBreakpoint(const
lldb::break_id_t bp_id) {
return nullptr;
}
+llvm::Error DAP::ConfigureIO(std::optional overrideOut,
ashgti wrote:
Removed the optional and just passed a `std::FILE *` instead.
ht
@@ -173,6 +178,63 @@ ExceptionBreakpoint *DAP::GetExceptionBreakpoint(const
lldb::break_id_t bp_id) {
return nullptr;
}
+llvm::Error DAP::ConfigureIO(std::optional overrideOut,
+ std::optional overrideErr) {
+ auto *inull = lldb_private::FileSys
@@ -173,6 +178,63 @@ ExceptionBreakpoint *DAP::GetExceptionBreakpoint(const
lldb::break_id_t bp_id) {
return nullptr;
}
+llvm::Error DAP::ConfigureIO(std::optional overrideOut,
+ std::optional overrideErr) {
+ auto *inull = lldb_private::FileSys
@@ -1099,6 +1098,14 @@ void request_disconnect(DAP &dap, const
llvm::json::Object &request) {
dap.broadcaster.BroadcastEventByType(eBroadcastBitStopProgressThread);
dap.progress_event_thread.join();
}
+ if (dap.stdout_forward_thread.joinable()) {
+dap.pout.Close
@@ -5027,43 +5019,77 @@ int main(int argc, char *argv[]) {
}
#endif
+ std::optional log = std::nullopt;
+ const char *log_file_path = getenv("LLDBDAP_LOG");
+ if (log_file_path)
+log.emplace(log_file_path);
+
// Initialize LLDB first before we do anything.
lldb:
@@ -5027,43 +5019,77 @@ int main(int argc, char *argv[]) {
}
#endif
+ std::optional log = std::nullopt;
+ const char *log_file_path = getenv("LLDBDAP_LOG");
+ if (log_file_path)
+log.emplace(log_file_path);
+
// Initialize LLDB first before we do anything.
lldb:
rocallahan wrote:
> Could you create a separate PR (or two, but probably not eight) with the
> refactoring changes, and we can rebase this PR on top of that when they land?
Ok. I assume "Require pull request reviews before merging" is enabled so you
can't push a group of commits manually.
ht
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/120784
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 113 matches
Mail list logo
