ZequanWu wrote:

> This particular example was fixed by 
> https://github.com/llvm/llvm-project/pull/120569 but this still feels a 
> little inconsistent. I'm not entirely sure we can get into that situation 
> after that patch anymore. So the only test-case I could come up with was the 
> unit-test which calls MapDeclDIEToDefDIE directly.

That sounds still possible to happens without this change: parse decl die -> 
complete its type -> update the map with def die and non-zeroed def die -> 
parse a second decl die for the same type -> without this change, it will fail 
to find the existing type in the map because zeroed declaration.

https://github.com/llvm/llvm-project/pull/120809
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to