ZequanWu wrote: > Just tried this. Unfortunately [we remove the CompilerType from the > `GetForwardDeclCompilerTypeToDIE`](https://github.com/llvm/llvm-project/blob/d7ddc976d544528fe7f16882f5bec66c3b2a7884/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp#L1577) > map inside of `CompleteType`. So in the next iteration of the > `SymbolFileDWARFDebugMap::CompleteType` loop, it [won't ever call into > `SymbolFileDWARF::CompleteType` > again](https://github.com/llvm/llvm-project/blob/d7ddc976d544528fe7f16882f5bec66c3b2a7884/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp#L808) > :( > > I guess we could put it back on failure? Not sure if it's worth the potential > trouble
We can move the the retrieval and null check of `Type*` before we remove it from `GetForwardDeclCompilerTypeToDIE()`, right? https://github.com/llvm/llvm-project/pull/120569 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
