DavidSpickett wrote: I assume the macro is `_ALL_SOURCE` with the leading underscore, you put `ALL_SOURCE` in the title and description.
I see that https://github.com/llvm/llvm-project/blob/d66f653c8db90d0c643f8f2740bbdc01bf647f18/third-party/unittest/CMakeLists.txt#L18 also does this. https://github.com/llvm/llvm-project/blob/d66f653c8db90d0c643f8f2740bbdc01bf647f18/clang/tools/libclang/CMakeLists.txt#L132 says it does the same thing but it doesn't add `_ALL_SOURCE` it only removes the other macro. The one in third-party seems more logical and matches the one you're adding, so this is fine. https://github.com/llvm/llvm-project/pull/120607 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
