[Lldb-commits] [PATCH] D145450: [lldb] Respect empty arguments in target.run-args

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. A bit surprised there wasn't an existing test to just add an extra argument to, but looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D145462: [LLDB][ObjectFileELF] Support LoongArch64 in ApplyReloctions

DavidSpickett added a comment. I see from `/usr/include/elf.h` on my system that the numbers do restart for each architecture. We got away with it for the set of relocations we were looking at. I like the new structure, it is clearer especially for the signed checks. I presume the definitions

[Lldb-commits] [PATCH] D145462: [LLDB][ObjectFileELF] Support LoongArch64 in ApplyReloctions

DavidSpickett added inline comments. Comment at: lldb/test/Shell/ObjectFile/ELF/loongarch64-relocations.yaml:10 +# CHECK-NEXT: ) + +--- !ELF Please add a comment to explain briefly how this proves the relocations are being processed. As it is I don't see how the

[Lldb-commits] [PATCH] D145242: [lldb][TypeSystemClang] Use the CXXFunctionPointerSummaryProvider for member-function pointers

labath added a comment. You may want to check that pointers to virtual functions get printed here. In particular, that `0x0001` (pointer to the first virtual function) does not get printed as `nullptr` or something like that (due to the truncation of the 128-bit valu

[Lldb-commits] [lldb] 6e3f2de - Revert "[lldb][TypeSystemClang] Use the CXXFunctionPointerSummaryProvider for member-function pointers"

Author: Michael Buch Date: 2023-03-07T11:18:38Z New Revision: 6e3f2dedc8221571852323cf24f03c01ab5ca217 URL: https://github.com/llvm/llvm-project/commit/6e3f2dedc8221571852323cf24f03c01ab5ca217 DIFF: https://github.com/llvm/llvm-project/commit/6e3f2dedc8221571852323cf24f03c01ab5ca217.diff LOG:

[Lldb-commits] [lldb] 1cd78f5 - Revert "[lldb][TypeSystemClang] Format pointers to member functions as eFormatHex"

Author: Michael Buch Date: 2023-03-07T11:18:39Z New Revision: 1cd78f5000d0c05d7f3267e86bb5616cd036a3f3 URL: https://github.com/llvm/llvm-project/commit/1cd78f5000d0c05d7f3267e86bb5616cd036a3f3 DIFF: https://github.com/llvm/llvm-project/commit/1cd78f5000d0c05d7f3267e86bb5616cd036a3f3.diff LOG:

[Lldb-commits] [lldb] bc112b1 - Revert "[lldb][test] NativePDB/ast-types: fix expected pointer format"

Author: Michael Buch Date: 2023-03-07T11:18:37Z New Revision: bc112b144741c977880ddd8021d8073f643c51b6 URL: https://github.com/llvm/llvm-project/commit/bc112b144741c977880ddd8021d8073f643c51b6 DIFF: https://github.com/llvm/llvm-project/commit/bc112b144741c977880ddd8021d8073f643c51b6.diff LOG:

[Lldb-commits] [lldb] a97bdba - Revert "[lldb] Build fix: variable name typo"

Author: Michael Buch Date: 2023-03-07T11:25:24Z New Revision: a97bdba02dcec1ade1b10dee76127d653d0ad8e6 URL: https://github.com/llvm/llvm-project/commit/a97bdba02dcec1ade1b10dee76127d653d0ad8e6 DIFF: https://github.com/llvm/llvm-project/commit/a97bdba02dcec1ade1b10dee76127d653d0ad8e6.diff LOG:

[Lldb-commits] [lldb] b7e667b - Revert "[lldb] Ignore libcxx std::ranges global variables in frame var"

Author: Michael Buch Date: 2023-03-07T11:25:36Z New Revision: b7e667bfd2a9bce0e3d5ca9fd6b97da553e03bd9 URL: https://github.com/llvm/llvm-project/commit/b7e667bfd2a9bce0e3d5ca9fd6b97da553e03bd9 DIFF: https://github.com/llvm/llvm-project/commit/b7e667bfd2a9bce0e3d5ca9fd6b97da553e03bd9.diff LOG:

[Lldb-commits] [PATCH] D145487: [lldb][test] TestDataFormatterCpp.py: add test-case for member function pointer format

Michael137 created this revision. Michael137 added a reviewer: labath. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a test for formatting of member function pointers. This was split

[Lldb-commits] [PATCH] D145487: [lldb][test] TestDataFormatterCpp.py: add test-case for member function pointer format

labath added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-cpp/TestDataFormatterCpp.py:301 +"frame variable virt_member_func_ptr", +patterns=['virt_member_func_ptr = ([0-9]{2}\s)+01']) If [[ http

[Lldb-commits] [PATCH] D145487: [lldb][test] TestDataFormatterCpp.py: add test-case for member function pointer format

Michael137 added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-cpp/TestDataFormatterCpp.py:301 +"frame variable virt_member_func_ptr", +patterns=['virt_member_func_ptr = ([0-9]{2}\s)+01']) labath

[Lldb-commits] [PATCH] D145487: [lldb][test] TestDataFormatterCpp.py: add test-case for member function pointer format

Michael137 updated this revision to Diff 502993. Michael137 added a comment. - Remove virtual function pointer test for now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145487/new/ https://reviews.llvm.org/D145487 Files: lldb/test/API/function

[Lldb-commits] [PATCH] D145487: [lldb][test] TestDataFormatterCpp.py: add test-case for member function pointer format

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D145487#4174832 , @Michael137 wrote: > - Remove virtual function pointer test for now You can keep it in, I think. Just don't assert the value of

[Lldb-commits] [PATCH] D145487: [lldb][test] TestDataFormatterCpp.py: add test-case for member function pointer format

Michael137 updated this revision to Diff 503021. Michael137 added a comment. - Add back simplified virtual function ptr assertion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145487/new/ https://reviews.llvm.org/D145487 Files: lldb/test/API/fu

[Lldb-commits] [lldb] 554f79e - [lldb][test] TestDataFormatterCpp.py: add test-case for member function pointer format

Author: Michael Buch Date: 2023-03-07T14:17:35Z New Revision: 554f79e050cb240d00e239ee4ca8d6aefdfa737d URL: https://github.com/llvm/llvm-project/commit/554f79e050cb240d00e239ee4ca8d6aefdfa737d DIFF: https://github.com/llvm/llvm-project/commit/554f79e050cb240d00e239ee4ca8d6aefdfa737d.diff LOG:

[Lldb-commits] [PATCH] D145487: [lldb][test] TestDataFormatterCpp.py: add test-case for member function pointer format

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG554f79e050cb: [lldb][test] TestDataFormatterCpp.py: add test-case for member function pointer… (authored by Michael137). Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D145487: [lldb][test] TestDataFormatterCpp.py: add test-case for member function pointer format

Michael137 added a comment. Ok it looks like this is still failing on Windows... I can't repro it on my Windows machine either so I'll split this test out and skip it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145487/new/ https://reviews.llvm.o

[Lldb-commits] [lldb] 110ce5a - [lldb][test] TestDataFormatterCpp.py: split assertions failing on Windows

Author: Michael Buch Date: 2023-03-07T15:25:38Z New Revision: 110ce5ab76449f06058e49a154b9b741c75c9d05 URL: https://github.com/llvm/llvm-project/commit/110ce5ab76449f06058e49a154b9b741c75c9d05 DIFF: https://github.com/llvm/llvm-project/commit/110ce5ab76449f06058e49a154b9b741c75c9d05.diff LOG:

[Lldb-commits] [lldb] 905a757 - [lldb][test] TestDataFormatterCpp.py: set breakpoint after all locals have been initialized

Author: Michael Buch Date: 2023-03-07T15:45:01Z New Revision: 905a7577c5845c0ad40f8a98f704cc3747e0e4fa URL: https://github.com/llvm/llvm-project/commit/905a7577c5845c0ad40f8a98f704cc3747e0e4fa DIFF: https://github.com/llvm/llvm-project/commit/905a7577c5845c0ad40f8a98f704cc3747e0e4fa.diff LOG:

[Lldb-commits] [PATCH] D145241: [lldb][TypeSystemClang] Format pointers to member functions as eFormatHex

Michael137 updated this revision to Diff 503044. Michael137 added a comment. - Rebase on top of latest test changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145241/new/ https://reviews.llvm.org/D145241 Files: lldb/source/Plugins/TypeSystem/

[Lldb-commits] [PATCH] D145242: [lldb][TypeSystemClang] Use the CXXFunctionPointerSummaryProvider for member-function pointers

Michael137 updated this revision to Diff 503055. Michael137 added a comment. - Rebase on latest test changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145242/new/ https://reviews.llvm.org/D145242 Files: lldb/include/lldb/Symbol/CompilerType.

[Lldb-commits] [PATCH] D145241: [lldb][TypeSystemClang] Format pointers to member functions as eFormatHex

Michael137 updated this revision to Diff 503056. Michael137 added a comment. - Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145241/new/ https://reviews.llvm.org/D145241 Files: lldb/source/Plugins/TypeSystem/Clang/TypeSyste

[Lldb-commits] [PATCH] D145437: [lldb-vscode] Use `expression` command for completion

kastiglione updated this revision to Diff 503105. kastiglione added a comment. Fix adjacent code and make the tests pass Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145437/new/ https://reviews.llvm.org/D145437 Files: lldb/tools/lldb-vscode/lld

[Lldb-commits] [lldb] e221dab - [lldb-vscode] Use `expression` command for completion

Author: Dave Lee Date: 2023-03-07T11:13:25-08:00 New Revision: e221dab07815016fb04deb5d38441e77d1cd300a URL: https://github.com/llvm/llvm-project/commit/e221dab07815016fb04deb5d38441e77d1cd300a DIFF: https://github.com/llvm/llvm-project/commit/e221dab07815016fb04deb5d38441e77d1cd300a.diff LOG:

[Lldb-commits] [PATCH] D145437: [lldb-vscode] Use `expression` command for completion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe221dab07815: [lldb-vscode] Use `expression` command for completion (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] ca8faf8 - [lldb] Respect empty arguments in target.run-args

Author: Alex Langford Date: 2023-03-07T11:29:27-08:00 New Revision: ca8faf8f465962e5c39d145a0e2236648cbcc27d URL: https://github.com/llvm/llvm-project/commit/ca8faf8f465962e5c39d145a0e2236648cbcc27d DIFF: https://github.com/llvm/llvm-project/commit/ca8faf8f465962e5c39d145a0e2236648cbcc27d.diff

[Lldb-commits] [PATCH] D145450: [lldb] Respect empty arguments in target.run-args

This revision was automatically updated to reflect the committed changes. Closed by commit rGca8faf8f4659: [lldb] Respect empty arguments in target.run-args (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145450/new/ https://r

[Lldb-commits] [PATCH] D145276: [lldb] Let 'v' command directly access ivars of _any_ self/this

kastiglione added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:9818 +if (ClangASTMetadata *metadata = GetMetadata(fun_decl)) + return metadata->GetObjectPtrLanguage(); + } aprantl wrote: > Couple of questions for

[Lldb-commits] [lldb] ef7adbe - Reland "[lldb][TypeSystemClang] Format pointers to member functions as eFormatHex"

Author: Michael Buch Date: 2023-03-07T19:45:49Z New Revision: ef7adbe2b7bcdb1fca88f77a7d4da2a8dea63699 URL: https://github.com/llvm/llvm-project/commit/ef7adbe2b7bcdb1fca88f77a7d4da2a8dea63699 DIFF: https://github.com/llvm/llvm-project/commit/ef7adbe2b7bcdb1fca88f77a7d4da2a8dea63699.diff LOG:

[Lldb-commits] [lldb] 8200848 - Reland "[lldb][TypeSystemClang] Use the CXXFunctionPointerSummaryProvider for member-function pointers"

Author: Michael Buch Date: 2023-03-07T19:45:50Z New Revision: 8200848c4125f2307abe38801ce9ca1288ea3081 URL: https://github.com/llvm/llvm-project/commit/8200848c4125f2307abe38801ce9ca1288ea3081 DIFF: https://github.com/llvm/llvm-project/commit/8200848c4125f2307abe38801ce9ca1288ea3081.diff LOG:

[Lldb-commits] [PATCH] D145242: [lldb][TypeSystemClang] Use the CXXFunctionPointerSummaryProvider for member-function pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rG8200848c4125: Reland "[lldb][TypeSystemClang] Use the CXXFunctionPointerSummaryProvider for… (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D145241: [lldb][TypeSystemClang] Format pointers to member functions as eFormatHex

This revision was automatically updated to reflect the committed changes. Closed by commit rGef7adbe2b7bc: Reland "[lldb][TypeSystemClang] Format pointers to member functions as… (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D145276: [lldb] Let 'v' command directly access ivars of _any_ self/this

kastiglione added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:9818 +if (ClangASTMetadata *metadata = GetMetadata(fun_decl)) + return metadata->GetObjectPtrLanguage(); + } kastiglione wrote: > aprantl wrote: > >

[Lldb-commits] [PATCH] D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption

jingham updated this revision to Diff 503136. jingham added a comment. Converted the test from using a lock to synchronize the command and test threads to using barriers. Changed the CommandInterpreter to print partial results when commands are interrupted. Fixed other review comments. Reposit

[Lldb-commits] [PATCH] D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption

jingham marked 5 inline comments as done. jingham added inline comments. Comment at: lldb/test/API/python_api/was_interrupted/TestDebuggerInterruption.py:39 +def rendevous(self): +# We smuggle out lock and event to the runner thread using thread local data:

[Lldb-commits] [PATCH] D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption

jingham updated this revision to Diff 503138. jingham added a comment. Forgot to address Pavel's const comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145136/new/ https://reviews.llvm.org/D145136 Files: lldb/include/lldb/API/SBCommandInte

[Lldb-commits] [PATCH] D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption

jingham added inline comments. Comment at: lldb/include/lldb/Core/Debugger.h:563 + // the previous IOHandler thread. + const HostThread SetIOHandlerThread(HostThread &new_thread); labath wrote: > `const` on a return value rarely makes sense. OTOH, `const` on

[Lldb-commits] [lldb] 9584ef1 - Recommit "[lldb] Redefine p alias to dwim-print command"

Author: Dave Lee Date: 2023-03-07T13:08:08-08:00 New Revision: 9584ef1b02c0c2f77454c15008cb4a047a91a348 URL: https://github.com/llvm/llvm-project/commit/9584ef1b02c0c2f77454c15008cb4a047a91a348 DIFF: https://github.com/llvm/llvm-project/commit/9584ef1b02c0c2f77454c15008cb4a047a91a348.diff LOG:

[Lldb-commits] [PATCH] D143695: [lldb] Make repeat commands work for regex commands

kastiglione updated this revision to Diff 503142. kastiglione added a comment. Introduce new allow_repeat_command parameter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143695/new/ https://reviews.llvm.org/D143695 Files: lldb/include/lldb/Inter

[Lldb-commits] [PATCH] D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption

jingham updated this revision to Diff 503143. jingham added a comment. Update the test comments for the new test method. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145136/new/ https://reviews.llvm.org/D145136 Files: lldb/include/lldb/API/SBCo

[Lldb-commits] [PATCH] D143695: [lldb] Make repeat commands work for regex commands

kastiglione added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2005 // stored "repeat command" which we should give a chance to produce it's // repeat command, even though we don't add repeat commands to the history. +Args command_args

[Lldb-commits] [PATCH] D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption

bulbazord added a comment. Small nits Comment at: lldb/include/lldb/API/SBCommandInterpreter.h:251-253 + /// Interrupts the command currently executing in the RunCommandInterpreter + /// thread. + bool InterruptCommand(); Some info on the return value would

[Lldb-commits] [PATCH] D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption

clayborg added inline comments. Comment at: lldb/include/lldb/API/SBDebugger.h:203 + void CancelInterruptRequest(); + bool InterruptRequested(); bulbazord wrote: > Could this be marked `const` if the mutex was marked `mutable`? We don't tend to mark things in

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

clayborg added inline comments. Comment at: lldb/include/lldb/Symbol/Symbol.h:27 + std::optional id; + std::optional section; + std::optional type; Come to think of it, we might not need the section as a name as it adds no real value unless we want to add a "

[Lldb-commits] [lldb] b461398 - Add a new SBDebugger::SetDestroyCallback() API

Author: Jeffrey Tan Date: 2023-03-07T14:48:15-08:00 New Revision: b461398f1ce307ec80708b7eb50f3bc82b76ed3f URL: https://github.com/llvm/llvm-project/commit/b461398f1ce307ec80708b7eb50f3bc82b76ed3f DIFF: https://github.com/llvm/llvm-project/commit/b461398f1ce307ec80708b7eb50f3bc82b76ed3f.diff L

[Lldb-commits] [PATCH] D143520: Add a new SBDebugger::SetDestroyCallback() API

This revision was automatically updated to reflect the committed changes. Closed by commit rGb461398f1ce3: Add a new SBDebugger::SetDestroyCallback() API (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143520/new/ https://rev

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Symbol/Symbol.cpp:44-49 + if (!section_list) +return; + + // This should've been caught during deserialization. + if (!symbol.value && !symbol.address) +return; -

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Symbol/Symbol.cpp:44-49 + if (!section_list) +return; + + // This should've been caught during deserialization. + if (!symbol.value && !symbol.address) +return; -

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

JDevlieghere updated this revision to Diff 503166. JDevlieghere added a comment. - Remove section field - Support raw value symbols - Update test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145180/new/ https://reviews.llvm.org/D145180 Files: lldb/include/lldb/Symbol/Symbol.h lldb

[Lldb-commits] [PATCH] D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption

jingham updated this revision to Diff 503171. jingham added a comment. Fix up some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145136/new/ https://reviews.llvm.org/D145136 Files: lldb/include/lldb/API/SBCommandInterpreter.h lldb/in

[Lldb-commits] [PATCH] D145529: [lldb] Change default value of dwim-print-verbosity setting

kastiglione created this revision. kastiglione added a reviewer: aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Reduce the default value of `dwim-print-verbosity` to `eDWIMPrintVerbosityNon

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

clayborg added a comment. Looks good. Only questions is if we can add a C++ unit test for this file and test the new Symbol::FromJSON() and test all error conditions. Comment at: lldb/source/Symbol/Symbol.cpp:99-100 +llvm::Expected Symbol::FromJSON(const JSONSymbol &symbol,

[Lldb-commits] [lldb] 9d311dd - [lldb] Copy log files into diagnostic directory

Author: Jonas Devlieghere Date: 2023-03-07T16:00:27-08:00 New Revision: 9d311dd6a71ba3910554b81fec5e6d5799ce0453 URL: https://github.com/llvm/llvm-project/commit/9d311dd6a71ba3910554b81fec5e6d5799ce0453 DIFF: https://github.com/llvm/llvm-project/commit/9d311dd6a71ba3910554b81fec5e6d5799ce0453.d

[Lldb-commits] [PATCH] D135631: [lldb] Copy log files into diagnostic directory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d311dd6a71b: [lldb] Copy log files into diagnostic directory (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: h

[Lldb-commits] [PATCH] D145276: [lldb] Let 'v' command directly access ivars of _any_ self/this

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:9818 +if (ClangASTMetadata *metadata = GetMetadata(fun_decl)) + return metadata->GetObject

[Lldb-commits] [lldb] 5195e14 - [lldb] Add missing switch case for SveCount in TypeSystemClang::GetEncoding (NFC)

Author: Jie Fu Date: 2023-03-08T09:08:42+08:00 New Revision: 5195e14bc1222e1b3f1b7b43c04e1c1ac3504cb1 URL: https://github.com/llvm/llvm-project/commit/5195e14bc1222e1b3f1b7b43c04e1c1ac3504cb1 DIFF: https://github.com/llvm/llvm-project/commit/5195e14bc1222e1b3f1b7b43c04e1c1ac3504cb1.diff LOG: [

[Lldb-commits] [PATCH] D145533: [lldb] Fix after __SVCount_t added for AArch64

asbirlea created this revision. asbirlea added reviewers: jgorbe, rupprecht. Herald added a subscriber: kristof.beyls. Herald added a project: All. asbirlea requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix after https://github.com/llvm/l

[Lldb-commits] [PATCH] D145533: [lldb] Fix after __SVCount_t added for AArch64

rupprecht added a comment. 5195e14bc1222e1b3f1b7b43c04e1c1ac3504cb1 just landed the same thing as this, although it didn't put it in the sorted order. Feel free to land this if you remove the other entry. Repository: rG L

[Lldb-commits] [PATCH] D145529: [lldb] Change default value of dwim-print-verbosity setting

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. This doesn't affect any tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145529/new/ https://reviews.llvm.org/D145529 ___

[Lldb-commits] [PATCH] D143695: [lldb] Make repeat commands work for regex commands

jingham added a comment. So the problem is that regex commands don't want to add the resolved command to the history, and so they need to force the creation of the repeat command even though they aren't adding to the history. But `allow_repeat_command` is a misleading name for that. It makes

[Lldb-commits] [PATCH] D145533: [lldb] Fix after __SVCount_t added for AArch64

asbirlea added a comment. Yeah, I noticed right after I sent this patch out :-). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145533/new/ https://reviews.llvm.org/D145533 ___ lldb-commits mailing list l

[Lldb-commits] [lldb] 3f29b23 - [lldb] Fix after __SVCount_t added for AArch64

Author: Alina Sbirlea Date: 2023-03-07T18:29:08-08:00 New Revision: 3f29b23b1a3cd3e45b78fa62f7be5da5c7bb674b URL: https://github.com/llvm/llvm-project/commit/3f29b23b1a3cd3e45b78fa62f7be5da5c7bb674b DIFF: https://github.com/llvm/llvm-project/commit/3f29b23b1a3cd3e45b78fa62f7be5da5c7bb674b.diff

[Lldb-commits] [PATCH] D145533: [lldb] Fix after __SVCount_t added for AArch64

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f29b23b1a3c: [lldb] Fix after __SVCount_t added for AArch64 (authored by asbirlea). Changed prior to commit: https://reviews.llvm.org/D145533?vs=503194&id=503203#toc Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D145547: When setting load addresses on darwin kernel kexts, handle case where in-memory load commands are not updated

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. The Darwin kernel has a number of kernel extensions, kexts, aki

[Lldb-commits] [PATCH] D145462: [LLDB][ObjectFileELF] Support LoongArch64 in ApplyReloctions

SixWeining added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2623 +(is_signed && + ((int64_t)value > INT32_MAX && (int64_t)value < INT32_MIN))) { + Log *log = GetLog(LLDBLog::Modules); DavidSpickett wrote

[Lldb-commits] [PATCH] D145462: [LLDB][ObjectFileELF] Support LoongArch64 in ApplyReloctions

SixWeining updated this revision to Diff 503236. SixWeining added a comment. Address @DavidSpickett's comments. 1. Fix the `&&` issue. 2. Make the test more readable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145462/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D145550: [LLDB][ObjectFileELF] Correct the return type of RelocOffset64 and RelocAddend64

SixWeining created this revision. SixWeining added reviewers: DavidSpickett, labath, davide, xen0n, wangleiat, MaskRay. Herald added a subscriber: emaste. Herald added a project: All. SixWeining requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commit