clayborg added a comment.
Looks good. Only questions is if we can add a C++ unit test for this file and
test the new Symbol::FromJSON() and test all error conditions.
================
Comment at: lldb/source/Symbol/Symbol.cpp:99-100
+llvm::Expected<Symbol> Symbol::FromJSON(const JSONSymbol &symbol,
+ SectionList *section_list) {
+ if (!section_list)
----------------
Can we unittest this function with a ObjectFileJSONTest.cpp? It would be nice
to check for the errors.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145180/new/
https://reviews.llvm.org/D145180
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
