[Lldb-commits] [PATCH] D110893: [lldb] Refactor statistics (NFC)

labath added a comment. Some general thoughts: - instead of throwing patches around in might be good to have a discussion thread to determine all the requirements and figure out the general direction - it would be better to have a series of smaller patches (like this one) instead one big patch

[Lldb-commits] [PATCH] D110878: [lldb] Add a gdb_remote_client test for connecting to pty [WIP]

labath added a comment. In D110878#3034748 , @mgorny wrote: > @labath, this is the part where I ask for help ;-). > > An exception happened when receiving the response from the gdb server. > Closing the client... > Traceback (most recent call last):

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin added a comment. In D110571#3033481 , @labath wrote: > In D110571#3033282 , @jarin wrote: > >> In D110571#3033078 , @labath wrote: >> >>> Here's one more question. A

[Lldb-commits] [PATCH] D110878: [lldb] Add a gdb_remote_client test for connecting to pty [WIP]

mgorny added inline comments. Comment at: lldb/test/API/functionalities/gdb_remote_client/gdbclientutils.py:560-564 +def get_connect_address(self): +libc = ctypes.CDLL(None) +libc.ptsname.argtypes = (ctypes.c_int,) +libc.ptsname.restype = ctypes.c_cha

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

labath added a comment. Just a couple of questions inline. In D110571#3035814 , @jarin wrote: > - thread #1, name = 'a.out', stop reason = breakpoint 1.2 frame #0: > 0x00401151 a.out`main [inlined] f(used=4, unused=) at > a.cc:5:3 > > (lldb) fr

[Lldb-commits] [PATCH] D110721: [lldb] [Host] Refactor TerminalState

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Is anyone passing save_process_group = true now? If not, I'd really like to delete it, as the implementation is quite scary. Comment at: lldb/include/lldb/Host/Terminal.h:51

[Lldb-commits] [PATCH] D110878: [lldb] Add a gdb_remote_client test for connecting to pty [WIP]

mgorny updated this revision to Diff 376456. mgorny added a comment. Replaced the class hacks with an abstraction over socket & connection sockets. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110878/new/ https://reviews.llvm.org/D110878 Files: lldb/test/API/functionalities/gdb_remo

[Lldb-commits] [PATCH] D110878: [lldb] Add a gdb_remote_client test for connecting to pty [WIP]

labath added inline comments. Comment at: lldb/test/API/functionalities/gdb_remote_client/TestPty.py:21 + +@skipIfWindows +def test_process_connect_sync(self): I think this can be applied at class level Comment at: lldb/test/API/functi

[Lldb-commits] [PATCH] D110721: [lldb] [Host] Refactor TerminalState

mgorny marked 2 inline comments as done. mgorny added a comment. In D110721#3035879 , @labath wrote: > Is anyone passing save_process_group = true now? If not, I'd really like to > delete it, as the implementation is quite scary. Yes, `Debugger::SaveInp

[Lldb-commits] [lldb] 58b4501 - [lldb] [Host] Refactor TerminalState

Author: Michał Górny Date: 2021-10-01T12:53:21+02:00 New Revision: 58b4501eeabb2728a5c48e05295f3636db0ecee1 URL: https://github.com/llvm/llvm-project/commit/58b4501eeabb2728a5c48e05295f3636db0ecee1 DIFF: https://github.com/llvm/llvm-project/commit/58b4501eeabb2728a5c48e05295f3636db0ecee1.diff

[Lldb-commits] [PATCH] D110721: [lldb] [Host] Refactor TerminalState

This revision was automatically updated to reflect the committed changes. Closed by commit rG58b4501eeabb: [lldb] [Host] Refactor TerminalState (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D110721?vs=376271&id=376468#toc Repository: rG

[Lldb-commits] [PATCH] D110914: [lldb] Remove "dwarf dynamic register size expressions" from RegisterInfo

jrtc27 added a comment. Is this removing this going to be a problem for RISC-V, where the floating-point registers could be 32-bit or 64-bit (or 128-bit in future), depending on which extensions you have? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D110914: [lldb] Remove "dwarf dynamic register size expressions" from RegisterInfo

labath added a comment. In D110914#3036079 , @jrtc27 wrote: > Is this removing this going to be a problem for RISC-V, where the > floating-point registers could be 32-bit or 64-bit (or 128-bit in future), > depending on which extensions you have? Is th

[Lldb-commits] [PATCH] D110878: [lldb] Add a gdb_remote_client test for connecting to pty [WIP]

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lldb/test/API/functionalities/gdb_remote_client/gdbclientutils.py:409 +self._master = io.FileIO(master, 'r+b') +self._slave = io.FileIO(slave, 'r+b') + labath wrot

[Lldb-commits] [PATCH] D110878: [lldb] Add a gdb_remote_client test for connecting to pty

mgorny updated this revision to Diff 376480. mgorny marked an inline comment as done. mgorny retitled this revision from "[lldb] Add a gdb_remote_client test for connecting to pty [WIP]" to "[lldb] Add a gdb_remote_client test for connecting to pty". mgorny added a comment. Make it easier to ove

[Lldb-commits] [PATCH] D110878: [lldb] Add a gdb_remote_client test for connecting to pty

mgorny updated this revision to Diff 376487. mgorny added a comment. Add `get_connect_url()` to simplify combining address with proper protocol/prefix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110878/new/ https://reviews.llvm.org/D110878 Files: lldb/test/API/functionalities/gdb

[Lldb-commits] [PATCH] D110914: [lldb] Remove "dwarf dynamic register size expressions" from RegisterInfo

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Thanks for doing this. The baseline code LGTM but I haven't verified the register enumerations ;-). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [lldb] 8fa2394 - [lldb] Add a gdb_remote_client test for connecting to pty

Author: Michał Górny Date: 2021-10-01T14:31:40+02:00 New Revision: 8fa2394bad433558f3083cee158043e2fb66d781 URL: https://github.com/llvm/llvm-project/commit/8fa2394bad433558f3083cee158043e2fb66d781 DIFF: https://github.com/llvm/llvm-project/commit/8fa2394bad433558f3083cee158043e2fb66d781.diff

[Lldb-commits] [PATCH] D110878: [lldb] Add a gdb_remote_client test for connecting to pty

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fa2394bad43: [lldb] Add a gdb_remote_client test for connecting to pty (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin updated this revision to Diff 376501. jarin marked 5 inline comments as done. jarin added a comment. Addressed reviewer comments, separated merging of the abstract parameters into a function, prevented interleaving of parameters with locals. CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

mib marked 7 inline comments as done. mib added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:105 +const char *ScriptedThread::GetName() { + if (m_name.empty()) { +CheckInterpreterAndScriptObject(); JDevlieghere wrote:

[Lldb-commits] [lldb] 12ee4c9 - [lldb] [test] Delay pty/tty imports to fix Windows builds

Author: Michał Górny Date: 2021-10-01T15:25:35+02:00 New Revision: 12ee4c9ad87e5c144cde2e8ff8a4787da0ed71df URL: https://github.com/llvm/llvm-project/commit/12ee4c9ad87e5c144cde2e8ff8a4787da0ed71df DIFF: https://github.com/llvm/llvm-project/commit/12ee4c9ad87e5c144cde2e8ff8a4787da0ed71df.diff

[Lldb-commits] [PATCH] D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

mib updated this revision to Diff 376502. mib added a comment. Address @JDevlieghere comments: - Remove "caching" - Refactor `error_with_message` lambda and `StructuredData` objects sanity checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1075

[Lldb-commits] [PATCH] D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

mib updated this revision to Diff 376504. mib added a comment. Reformat code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107585/new/ https://reviews.llvm.org/D107585 Files: lldb/bindings/python/python-wrapper.swig lldb/examples/python/scrip

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin added a comment. Thank you for the great comments, Pavel. I took a stab at merging the parameters without interleaving them with the locals. Let me know what you think; I can certainly put this back to the original state if you think this is a change for the worse. (I am sorry for the ch

[Lldb-commits] [PATCH] D108953: [lldb/Plugins] Add memory region support in ScriptedProcess

mib added a comment. ping @JDevlieghere Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108953/new/ https://reviews.llvm.org/D108953 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [PATCH] D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

mib updated this revision to Diff 376507. mib added a comment. Pass `__PRETTY_FUNCTION__` to `CheckStructuredDataObject` to log the caller function name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107585/new/ https://reviews.llvm.org/D107585 F

[Lldb-commits] [PATCH] D108953: [lldb/Plugins] Add memory region support in ScriptedProcess

mib updated this revision to Diff 376508. mib added a comment. Use `ScriptedInterface::ErrorWithMessage` helper function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108953/new/ https://reviews.llvm.org/D108953 Files: lldb/bindings/interface/S

[Lldb-commits] [PATCH] D108953: [lldb/Plugins] Add memory region support in ScriptedProcess

mib updated this revision to Diff 376509. mib added a comment. Update error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108953/new/ https://reviews.llvm.org/D108953 Files: lldb/bindings/interface/SBMemoryRegionInfo.i lldb/bindings/i

[Lldb-commits] [lldb] 633ac51 - [lldb] Simplify TestCompletion.py

Author: Pavel Labath Date: 2021-10-01T15:49:23+02:00 New Revision: 633ac5170996da6a80a2236bed99913b66ed1d27 URL: https://github.com/llvm/llvm-project/commit/633ac5170996da6a80a2236bed99913b66ed1d27 DIFF: https://github.com/llvm/llvm-project/commit/633ac5170996da6a80a2236bed99913b66ed1d27.diff

[Lldb-commits] [PATCH] D110942: [lldb] Move DynamicRegisterInfo to public Target library

mgorny created this revision. mgorny added reviewers: labath, teemperor, emaste, krytarowski. mgorny requested review of this revision. Move DynamicRegisterInfo from the internal lldbPluginProcessUtility library to the public lldbTarget library. This is a prerequisite towards ABI plugin changes t

[Lldb-commits] [PATCH] D109876: [lldb] [ABI/AArch64] Add pseudo-regs if missing

mgorny updated this revision to Diff 376549. mgorny retitled this revision from "[lldb] [ABI/AArch64] Add pseudo-regs if missing [WIP]" to "[lldb] [ABI/AArch64] Add pseudo-regs if missing". mgorny added a reviewer: teemperor. mgorny added a comment. Update for DynamicRegisterInfo move. CHANGES

[Lldb-commits] [lldb] bd21257 - [lldb] [Host] Fix flipped logic in TerminalState::Save()

Author: Michał Górny Date: 2021-10-01T18:23:54+02:00 New Revision: bd21257bf5af211c4d269ddbec0911c76c3b6120 URL: https://github.com/llvm/llvm-project/commit/bd21257bf5af211c4d269ddbec0911c76c3b6120 DIFF: https://github.com/llvm/llvm-project/commit/bd21257bf5af211c4d269ddbec0911c76c3b6120.diff

[Lldb-commits] [lldb] a7b4ce9 - [NFC][AttributeList] Replace index_begin/end with an iterator

Author: Arthur Eubanks Date: 2021-10-01T10:17:41-07:00 New Revision: a7b4ce9cfd110db56d89fa8d76b39023d038de11 URL: https://github.com/llvm/llvm-project/commit/a7b4ce9cfd110db56d89fa8d76b39023d038de11 DIFF: https://github.com/llvm/llvm-project/commit/a7b4ce9cfd110db56d89fa8d76b39023d038de11.diff

[Lldb-commits] [PATCH] D110885: [NFC][AttributeList] Replace index_begin/end with an iterator

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7b4ce9cfd11: [NFC][AttributeList] Replace index_begin/end with an iterator (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110885/new/

[Lldb-commits] [lldb] f853789 - [lldb] [Host] Sync TerminalState::Data to struct type

Author: Michał Górny Date: 2021-10-01T20:34:11+02:00 New Revision: f8537895b9a63caec31a02b90b82fb367b852ae8 URL: https://github.com/llvm/llvm-project/commit/f8537895b9a63caec31a02b90b82fb367b852ae8 DIFF: https://github.com/llvm/llvm-project/commit/f8537895b9a63caec31a02b90b82fb367b852ae8.diff

[Lldb-commits] [PATCH] D110962: [lldb] Add unit tests for Terminal API

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, teemperor, JDevlieghere. mgorny requested review of this revision. https://reviews.llvm.org/D110962 Files: lldb/unittests/Host/CMakeLists.txt lldb/unittests/Host/TerminalTest.cpp Index: lldb/unittests/Host/Ter

[Lldb-commits] [PATCH] D110962: [lldb] Add unit tests for Terminal API

mgorny updated this revision to Diff 376607. mgorny added a comment. Remove obsolete TODO. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110962/new/ https://reviews.llvm.org/D110962 Files: lldb/unittests/Host/CMakeLists.txt lldb/unittests/Host/TerminalTest.cpp Index: lldb/unittest

[Lldb-commits] [PATCH] D110962: [lldb] Add unit tests for Terminal API

mgorny added inline comments. Comment at: lldb/unittests/Host/CMakeLists.txt:27 +if (LLDB_ENABLE_TERMIOS AND +CMAKE_SYSTEM_NAME MATCHES "Darwin|FreeBSD|Linux|NetBSD|OpenBSD") + list(APPEND FILES FTR, I've tested it on FreeBSD and Linux so far. NetBSD in prog

[Lldb-commits] [PATCH] D110893: [lldb] Refactor statistics (NFC)

aprantl added a comment. In D110893#3035753 , @labath wrote: > Some general thoughts: > > - instead of throwing patches around in might be good to have a discussion > thread to determine all the requirements and figure out the general direction Got to a

[Lldb-commits] [PATCH] D110804: Add a new command "target metrics".

JDevlieghere added a comment. Thanks Greg! Following Pavel's suggestion in D110893 , could you split up this patch into smaller ones? I think that will make it a lot easier to review and discuss. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D110981: [lldb] Improve help for platform put-file

keith created this revision. keith added a reviewer: kastiglione. keith requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Herald added a subscriber: JDevlieghere. Previously it was not clear what arguments this required, or what it would do