mgorny marked 2 inline comments as done.
mgorny added inline comments.

================
Comment at: 
lldb/test/API/functionalities/gdb_remote_client/gdbclientutils.py:409
+        self._master = io.FileIO(master, 'r+b')
+        self._slave = io.FileIO(slave, 'r+b')
+
----------------
labath wrote:
> do you actually need to keep the slave open here?
Yes, it seems this way. If I close it early, the test hangs.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110878/new/

https://reviews.llvm.org/D110878

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to