labath added inline comments.
================ Comment at: lldb/test/API/functionalities/gdb_remote_client/TestPty.py:21 + + @skipIfWindows + def test_process_connect_sync(self): ---------------- I think this can be applied at class level ================ Comment at: lldb/test/API/functionalities/gdb_remote_client/gdbclientutils.py:409 + self._master = io.FileIO(master, 'r+b') + self._slave = io.FileIO(slave, 'r+b') + ---------------- do you actually need to keep the slave open here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110878/new/ https://reviews.llvm.org/D110878 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
