mib marked 7 inline comments as done.
mib added inline comments.
================
Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:105
+const char *ScriptedThread::GetName() {
+ if (m_name.empty()) {
+ CheckInterpreterAndScriptObject();
----------------
JDevlieghere wrote:
> We're caching the name and the queue, is this an optimization (to avoid
> calling into Python over and over) or are there assumptions that will break
> if these are not stable? If so, should that be something we call out on the
> Python side or alternatively, should we allow this to change and not cache
> it?
This meant to be an optimization to avoid calling the Python interface but I
guess we can rid of that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107585/new/
https://reviews.llvm.org/D107585
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
