[Lldb-commits] [PATCH] D109906: [lldb] [test] Add unittest for DynamicRegisterInfo::Finalize()

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/unittests/Process/Utility/DynamicRegisterInfoTest.cpp:23 + ConstString group{"group"}; + static uint32_t regnum = 0; + It would be bet

[Lldb-commits] [PATCH] D110025: [lldb] [gdb-remote] Refactor getting remote regs to use local vector [WIP]

labath added a comment. I like it. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4368-4371 +namespace lldb_private { +namespace process_gdb_remote { + +struct RemoteRegisterInfo { `struct process_gdb_remote::RemoteRegisterInfo {` shou

[Lldb-commits] [PATCH] D109879: [lldb] [DynamicRegisterInfo] Replace value_regs/invalidate_regs in AddRegister()

labath added a comment. As I alluded to in the second comment, I'm not sure this is really that much helpful, since it's also nice to have all invalidate_regs handling happen in a single function. Maybe AddRegister should just set this field to null (to give a more predictable behavior (crash)

[Lldb-commits] [lldb] 9669223 - [lldb] Remove two #ifndef linux from Platform.cpp

Author: Pavel Labath Date: 2021-09-20T08:30:02+02:00 New Revision: 966922320f09b8bf6e4a69a32f344b3acec36434 URL: https://github.com/llvm/llvm-project/commit/966922320f09b8bf6e4a69a32f344b3acec36434 DIFF: https://github.com/llvm/llvm-project/commit/966922320f09b8bf6e4a69a32f344b3acec36434.diff

[Lldb-commits] [PATCH] D109879: [lldb] [DynamicRegisterInfo] Replace value_regs/invalidate_regs in AddRegister()

mgorny added a comment. Sure, I suppose either way works for me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109879/new/ https://reviews.llvm.org/D109879 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [PATCH] D110027: [lldb] [gdb-remote] Use local regnos for value_regs/invalidate_regs

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4684 +std::map remote_to_local_map; for (RemoteRegisterInfo& remote_reg_info : registers) { + // Assign successive remote regnums if missing. drop

[Lldb-commits] [PATCH] D110033: [lldb] [gdb-remote] Always send PID when detaching w/ multiprocess

labath added a comment. A test case? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110033/new/ https://reviews.llvm.org/D110033 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [PATCH] D110023: [lldb] [DynamicRegisterInfo] Add a convenience method to add suppl. registers

labath added inline comments. Comment at: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp:482 +// copy invalidate_regs from the parent register +llvm::append_range(to_add[reg_num], m_invalidate_regs_map[value_reg]); + mgorny wrote: > @labath,

[Lldb-commits] [PATCH] D109899: [lldb] [gdb-remote] Recognize aarch64v type from gdbserver

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I'm guessing this is what's being sent by gdbserver. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109899/new/ https://reviews.llvm.org/D109899 __

[Lldb-commits] [PATCH] D109906: [lldb] [test] Add unittest for DynamicRegisterInfo::Finalize()

mgorny marked an inline comment as done. mgorny added a comment. Made fixture class. Now you made me think of adding a helper method to test register properties too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109906/new/ https://reviews.llvm.org/D109906

[Lldb-commits] [PATCH] D109906: [lldb] [test] Add unittest for DynamicRegisterInfo::Finalize()

mgorny updated this revision to Diff 373506. mgorny added a comment. Create a helper class and move adding regs there. Add a helper function to assert on registers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109906/new/ https://reviews.llvm.org/D109906 Files: lldb/unittests/Proce

[Lldb-commits] [lldb] 92904cc - [lldb] [gdb-remote] Remove unused arg from GDBRemoteRegisterContext::ReadRegisterBytes()

Author: Michał Górny Date: 2021-09-20T10:24:01+02:00 New Revision: 92904cc68fbc1d000387b30accc8b05b3fe95daa URL: https://github.com/llvm/llvm-project/commit/92904cc68fbc1d000387b30accc8b05b3fe95daa DIFF: https://github.com/llvm/llvm-project/commit/92904cc68fbc1d000387b30accc8b05b3fe95daa.diff

[Lldb-commits] [PATCH] D110020: [lldb] [gdb-remote] Remove unused arg from GDBRemoteRegisterContext::ReadRegisterBytes()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92904cc68fbc: [lldb] [gdb-remote] Remove unused arg from GDBRemoteRegisterContext… (authored by mgorny). Herald added a project: LLDB. Repository:

[Lldb-commits] [PATCH] D109906: [lldb] [test] Add unittest for DynamicRegisterInfo::Finalize()

mgorny updated this revision to Diff 373509. mgorny added a comment. Test for register name too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109906/new/ https://reviews.llvm.org/D109906 Files: lldb/unittests/Process/Utility/CMakeLists.txt lldb/unittests/Process/Utility/DynamicReg

[Lldb-commits] [PATCH] D109879: [lldb] [DynamicRegisterInfo] Unset value_regs/invalidate_regs before Finalize()

mgorny updated this revision to Diff 373511. mgorny retitled this revision from "[lldb] [DynamicRegisterInfo] Replace value_regs/invalidate_regs in AddRegister()" to "[lldb] [DynamicRegisterInfo] Unset value_regs/invalidate_regs before Finalize()". mgorny edited the summary of this revision. mgor

[Lldb-commits] [lldb] f6e0edc - [lldb] [gdb-remote] Recognize aarch64v type from gdbserver

Author: Michał Górny Date: 2021-09-20T10:41:38+02:00 New Revision: f6e0edc23e6199bbb5fb4ef3b018b49a5b303183 URL: https://github.com/llvm/llvm-project/commit/f6e0edc23e6199bbb5fb4ef3b018b49a5b303183 DIFF: https://github.com/llvm/llvm-project/commit/f6e0edc23e6199bbb5fb4ef3b018b49a5b303183.diff

[Lldb-commits] [PATCH] D109899: [lldb] [gdb-remote] Recognize aarch64v type from gdbserver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6e0edc23e61: [lldb] [gdb-remote] Recognize aarch64v type from gdbserver (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM G

[Lldb-commits] [PATCH] D109906: [lldb] [test] Add unittest for DynamicRegisterInfo::Finalize()

labath added a comment. In general, I'd prefer to avoid adding new methods to the class under test, and save subclassing for the cases where it's impossible to do things otherwise (abstract class, visibility restrictions (although that often means you're not testing what you should be)). These

[Lldb-commits] [PATCH] D110023: [lldb] [DynamicRegisterInfo] Add a convenience method to add suppl. registers

mgorny updated this revision to Diff 373515. mgorny added a comment. Rebased. Updated the code to assume dedupe and cleanup happens in `Finalize()`, and to use new test assertions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110023/new/ https://reviews.llvm.org/D110023 Files: lldb

[Lldb-commits] [PATCH] D109906: [lldb] [test] Add unittest for DynamicRegisterInfo::Finalize()

mgorny updated this revision to Diff 373524. mgorny added a comment. Implemented all the suggested improvements. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109906/new/ https://reviews.llvm.org/D109906 Files: lldb/unittests/Process/Utility/CMakeLists.txt lldb/unittests/Process/Ut

[Lldb-commits] [PATCH] D110025: [lldb] [gdb-remote] Refactor getting remote regs to use local vector [WIP]

mgorny updated this revision to Diff 373530. mgorny marked an inline comment as done. mgorny added a comment. Put the struct into the header. Put the common conversion and finalization code into a helper method. Use `llvm::enumerate` for local regnums. Convert qRegisterInfo getters. CHANGES SI

[Lldb-commits] [PATCH] D110027: [lldb] [gdb-remote] Use local regnos for value_regs/invalidate_regs

mgorny updated this revision to Diff 373538. mgorny marked 2 inline comments as done. mgorny added a comment. Rebase. Apply suggested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110027/new/ https://reviews.llvm.org/D110027 Files: lldb/source/Plugins/Process/Utility/Dynamic

[Lldb-commits] [PATCH] D110033: [lldb] [gdb-remote] Always send PID when detaching w/ multiprocess

mgorny updated this revision to Diff 373545. mgorny added a comment. Add tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110033/new/ https://reviews.llvm.org/D110033 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp lldb/test/API/functionalities/gd

[Lldb-commits] [PATCH] D110033: [lldb] [gdb-remote] Always send PID when detaching w/ multiprocess

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/functionalities/gdb_remote_client/TestGDBRemoteClient.py:384 +def qSupported(self, client_supported): +assert "mult

[Lldb-commits] [PATCH] D110033: [lldb] [gdb-remote] Always send PID when detaching w/ multiprocess

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/test/API/functionalities/gdb_remote_client/TestGDBRemoteClient.py:384 +def qSupported(self, client_supported): +assert "multiprocess+" in client_supported +

[Lldb-commits] [lldb] b109912 - [lldb] [gdb-remote] Always send PID when detaching w/ multiprocess

Author: Michał Górny Date: 2021-09-20T13:29:07+02:00 New Revision: b1099120ff963d0a0f1de12e3315b1ee4e4ed7e7 URL: https://github.com/llvm/llvm-project/commit/b1099120ff963d0a0f1de12e3315b1ee4e4ed7e7 DIFF: https://github.com/llvm/llvm-project/commit/b1099120ff963d0a0f1de12e3315b1ee4e4ed7e7.diff

[Lldb-commits] [PATCH] D110033: [lldb] [gdb-remote] Always send PID when detaching w/ multiprocess

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mgorny marked an inline comment as done. Closed by commit rGb1099120ff96: [lldb] [gdb-remote] Always send PID when detaching w/ multiprocess (authored by mgorny). Heral

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay updated this revision to Diff 373559. emrekultursay added a comment. Add new dlopen test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/D109797 Files: lldb/source/Plugins/DynamicLoader/POSIX-DYLD

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay updated this revision to Diff 373560. emrekultursay added a comment. Minor touch-ups to the newly added test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/D109797 Files: lldb/source/Plugins/Dyn

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay added a comment. In D109797#3005885 , @labath wrote: > I'm not sure all of this is relevant. I've just tried to debug a very simple > (linux) executable that does a dlopens a library. If I attach to the > executable before the dlopen call,

[Lldb-commits] [lldb] ec50d35 - [lldb] [DynamicRegisterInfo] Unset value_regs/invalidate_regs before Finalize()

Author: Michał Górny Date: 2021-09-20T15:02:20+02:00 New Revision: ec50d351ffdd4559ccce6013d3ab4a3f41c42cee URL: https://github.com/llvm/llvm-project/commit/ec50d351ffdd4559ccce6013d3ab4a3f41c42cee DIFF: https://github.com/llvm/llvm-project/commit/ec50d351ffdd4559ccce6013d3ab4a3f41c42cee.diff

[Lldb-commits] [lldb] 4737dcb - [lldb] [test] Add unittest for DynamicRegisterInfo::Finalize()

Author: Michał Górny Date: 2021-09-20T15:02:20+02:00 New Revision: 4737dcbc83e05ac97c8695cf9a19bddb6446d71f URL: https://github.com/llvm/llvm-project/commit/4737dcbc83e05ac97c8695cf9a19bddb6446d71f DIFF: https://github.com/llvm/llvm-project/commit/4737dcbc83e05ac97c8695cf9a19bddb6446d71f.diff

[Lldb-commits] [PATCH] D109906: [lldb] [test] Add unittest for DynamicRegisterInfo::Finalize()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4737dcbc83e0: [lldb] [test] Add unittest for DynamicRegisterInfo::Finalize() (authored by mgorny). Herald added a project: LLDB. Repository: rG LL

[Lldb-commits] [PATCH] D109879: [lldb] [DynamicRegisterInfo] Unset value_regs/invalidate_regs before Finalize()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGec50d351ffdd: [lldb] [DynamicRegisterInfo] Unset value_regs/invalidate_regs before Finalize() (authored by mgorny). Herald added a project: LLDB. Ch

[Lldb-commits] [PATCH] D110010: [lldb] Extract adding symbols for UUID/File/Frame (NFC)

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4203 + + bool AddSymbolsForFrame(Target *target, CommandReturnObject &result, + bool &flush) { la

[Lldb-commits] [PATCH] D110011: [lldb] Add --stack option to `target symbols add` command

shafik added a comment. Does it make sense to add a test for this? It looks like we have two basic tests for `add-dsym` already. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110011/new/ https://reviews.llvm.org/D110011 ___ lldb-commits mail

[Lldb-commits] [lldb] fe4b846 - [lldb] Fix whitespace in CommandObjectTarget (NFC)

Author: Jonas Devlieghere Date: 2021-09-20T09:08:03-07:00 New Revision: fe4b8467b5dca564b4859256b08ece5fa1eaa574 URL: https://github.com/llvm/llvm-project/commit/fe4b8467b5dca564b4859256b08ece5fa1eaa574 DIFF: https://github.com/llvm/llvm-project/commit/fe4b8467b5dca564b4859256b08ece5fa1eaa574.d

[Lldb-commits] [lldb] a89bfc6 - [lldb] Extract adding symbols for UUID/File/Frame (NFC)

Author: Jonas Devlieghere Date: 2021-09-20T09:08:04-07:00 New Revision: a89bfc61203d5c2071cddaff26345771716463ec URL: https://github.com/llvm/llvm-project/commit/a89bfc61203d5c2071cddaff26345771716463ec DIFF: https://github.com/llvm/llvm-project/commit/a89bfc61203d5c2071cddaff26345771716463ec.d

[Lldb-commits] [PATCH] D110010: [lldb] Extract adding symbols for UUID/File/Frame (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rGa89bfc61203d: [lldb] Extract adding symbols for UUID/File/Frame (NFC) (authored by JDevlieghere). Hera

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

PatriosTheGreat added a comment. Friendly ping =) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104413/new/ https://reviews.llvm.org/D104413 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [PATCH] D110011: [lldb] Add --stack option to `target symbols add` command

JDevlieghere updated this revision to Diff 373642. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. - Rebase - Add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110011/new/ https://reviews.llvm.org/D110011 Files: lldb/source/Commands/CommandObjectTarg

[Lldb-commits] [lldb] e31b2d7 - [lldb][crashlog] Avoid specifying arch for image when a UUID is present

Author: Vedant Kumar Date: 2021-09-20T10:23:35-07:00 New Revision: e31b2d7d7be98cbbaa665b2702cd0ed2975da4cc URL: https://github.com/llvm/llvm-project/commit/e31b2d7d7be98cbbaa665b2702cd0ed2975da4cc DIFF: https://github.com/llvm/llvm-project/commit/e31b2d7d7be98cbbaa665b2702cd0ed2975da4cc.diff

[Lldb-commits] [PATCH] D110013: [lldb][crashlog] Avoid specifying arch for image when a UUID is present

This revision was automatically updated to reflect the committed changes. Closed by commit rGe31b2d7d7be9: [lldb][crashlog] Avoid specifying arch for image when a UUID is present (authored by vsk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110013

[Lldb-commits] [PATCH] D110011: [lldb] Add --stack option to `target symbols add` command

JDevlieghere updated this revision to Diff 373673. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110011/new/ https://reviews.llvm.org/D110011 Files: lldb/source/Commands/CommandObjectTarget.cpp lldb/test/API/macosx/add-dsym/TestAddDsymDownload.py Index: lldb/test/API/macosx/add-dsym

[Lldb-commits] [lldb] c4a406b - [lldb][NFC] Remove outdated FIXME

Author: Alex Langford Date: 2021-09-20T11:44:20-07:00 New Revision: c4a406bbd0fe3afa8366b72c49b1bc494a168624 URL: https://github.com/llvm/llvm-project/commit/c4a406bbd0fe3afa8366b72c49b1bc494a168624 DIFF: https://github.com/llvm/llvm-project/commit/c4a406bbd0fe3afa8366b72c49b1bc494a168624.diff

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/CMakeLists.txt:55-60 + # FIXME: Lua 5.3 is hardcoded but it should support 5.3+! + find_program(Lua_EXECUTABLE lua5.3) + if (

[Lldb-commits] [PATCH] D109834: [lldb/win] Improve check-lldb-shell with LLVM_ENABLE_DIA_SDK=NO

thakis added a comment. Oh, that's a good idea. But even if I force on the native PDB reader if LLVM_ENABLE_DIA_SDK is false [1], I still get 15 failures. That's better than 27, but it's more than 0. Maybe LLDB_USE_NATIVE_PDB_READER doesn't hit all uses of DIA in lldb? Failed Tests (15):

[Lldb-commits] [PATCH] D110115: [lldb] Remove Expression's dependency on CPlusPlusLanguagePlugin

bulbazord created this revision. bulbazord added reviewers: clayborg, jingham, teemperor, JDevlieghere. Herald added a subscriber: mgorny. bulbazord requested review of this revision. Herald added a project: LLDB. This change accomplishes the following: - Moves `IRExecutionUnit::FindBestAlternate

[Lldb-commits] [PATCH] D110115: [lldb] Remove Expression's dependency on CPlusPlusLanguagePlugin

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:524-530 + if (param_and_qual_matches.size()) +return param_and_qual_matches[0]; // It is assumed that there will be only + // one

[Lldb-commits] [PATCH] D110115: [lldb] Remove Expression's dependency on CPlusPlusLanguagePlugin

bulbazord added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:524-530 + if (param_and_qual_matches.size()) +return param_and_qual_matches[0]; // It is assumed that there will be only + // one! +

[Lldb-commits] [PATCH] D110115: [lldb] Remove Expression's dependency on CPlusPlusLanguagePlugin

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:524-530 + if (param_and_qual_matches.size()) +return param_and_qual_matches[0]; // It is assumed that there will be only + // one

[Lldb-commits] [PATCH] D110011: [lldb] Add --stack option to `target symbols add` command

kastiglione accepted this revision. kastiglione added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4300-4301 + current_frame_flush)) +symbols_found = true; +