JDevlieghere added inline comments.
================ Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:524-530 + if (param_and_qual_matches.size()) + return param_and_qual_matches[0]; // It is assumed that there will be only + // one! + else if (param_matches.size()) + return param_matches[0]; // Return one of them as a best match + else + return ConstString(); ---------------- bulbazord wrote: > JDevlieghere wrote: > > I know you just copied this, but `else` after a return? > I think there's a lot of opportunity to refactor this method. Think I should > do it in this change or would a follow-up be more reasonable? If you're planning more changes then a follow-up sounds like the best course of action. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110115/new/ https://reviews.llvm.org/D110115 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
