mgorny marked an inline comment as done.
mgorny added inline comments.

================
Comment at: 
lldb/test/API/functionalities/gdb_remote_client/TestGDBRemoteClient.py:384
+            def qSupported(self, client_supported):
+                assert "multiprocess+" in client_supported
+                return "multiprocess+;" + super().qSupported(client_supported)
----------------
labath wrote:
> Whether this fires depends on how python was run. Better use regular asserts. 
> You could pass in the test case to MyResponder constructor, or stash 
> client_supported in a member variable for later checks, or ...
Sure, makes sense.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110033/new/

https://reviews.llvm.org/D110033

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to