labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lldb/unittests/Process/Utility/DynamicRegisterInfoTest.cpp:23
+ ConstString group{"group"};
+ static uint32_t regnum = 0;
+
----------------
It would be better to create a fixture class, and make this a member variable
of that class. If this ends up used from two tests, it will begin returning
different values depending on the order of tests, whether they are run
standalone, etc.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109906/new/
https://reviews.llvm.org/D109906
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
