[Lldb-commits] [lldb] [lldb] Remove Function null checks in Block.cpp (PR #137611)

https://github.com/labath closed https://github.com/llvm/llvm-project/pull/137611 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 679cc0a - [lldb] Remove Function null checks in Block.cpp (#137611)

Author: Pavel Labath Date: 2025-04-29T08:20:08+02:00 New Revision: 679cc0a1ed60ea529abc04cecbcdd75d65ea0588 URL: https://github.com/llvm/llvm-project/commit/679cc0a1ed60ea529abc04cecbcdd75d65ea0588 DIFF: https://github.com/llvm/llvm-project/commit/679cc0a1ed60ea529abc04cecbcdd75d65ea0588.diff

[Lldb-commits] [lldb] [lldb] Use early returns in TypeSystemClang::IsPossibleDynamicType (PR #137630)

https://github.com/labath closed https://github.com/llvm/llvm-project/pull/137630 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ebaeecc - [lldb] Use early returns in TypeSystemClang::IsPossibleDynamicType (#137630)

Author: Pavel Labath Date: 2025-04-29T08:17:53+02:00 New Revision: ebaeecc429f53c209ea58d6d4c7df3552adcb714 URL: https://github.com/llvm/llvm-project/commit/ebaeecc429f53c209ea58d6d4c7df3552adcb714 DIFF: https://github.com/llvm/llvm-project/commit/ebaeecc429f53c209ea58d6d4c7df3552adcb714.diff

[Lldb-commits] [lldb] Revert "[lldb][Format] Make function name frame-format variables work without debug-info" (PR #137757)

https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/137757 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] da70992 - Revert "[lldb][Format] Make function name frame-format variables work without debug-info" (#137757)

Author: Michael Buch Date: 2025-04-29T07:13:04+01:00 New Revision: da7099290cea7d11b83da01adda8afeb3bcd5362 URL: https://github.com/llvm/llvm-project/commit/da7099290cea7d11b83da01adda8afeb3bcd5362 DIFF: https://github.com/llvm/llvm-project/commit/da7099290cea7d11b83da01adda8afeb3bcd5362.diff

[Lldb-commits] [lldb] Revert "[lldb][Format] Make function name frame-format variables work without debug-info" (PR #137757)

https://github.com/slackito approved this pull request. Thanks for the quick response! https://github.com/llvm/llvm-project/pull/137757 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [lldb] Revert "[lldb][Format] Make function name frame-format variables work without debug-info" (PR #137757)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/137757 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb][Format] Make function name frame-format variables work without debug-info" (PR #137757)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Reverts llvm/llvm-project#137408 --- Full diff: https://github.com/llvm/llvm-project/pull/137757.diff 8 Files Affected: - (modified) lldb/source/Core/FormatEntity.cpp (+4-5) - (modified) lldb/source/Plu

[Lldb-commits] [lldb] Revert "[lldb][Format] Make function name frame-format variables work without debug-info" (PR #137757)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/137757 Reverts llvm/llvm-project#137408 >From f7159a00fdd1950dbac5c24f532a13af76af44a5 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 29 Apr 2025 07:03:26 +0100 Subject: [PATCH] =?UTF-8?q?Revert=20"[lldb][F

[Lldb-commits] [lldb] [lldb][Format] Make function name frame-format variables work without debug-info (PR #137408)

Michael137 wrote: > I think this change broke > lldb/test/Shell/Unwind/split-machine-functions.test. I can reproduce locally > at HEAD with `ninja check-lldb-shell-unwind`. > > The test binary has a symbol named `_Z3foov.cold` and the test expects the > backtrace to print the name of the cold

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

github-actions[bot] wrote: @HemangGadhavi Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

https://github.com/DhruvSrivastavaX closed https://github.com/llvm/llvm-project/pull/134354 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d1bb8d6 - [lldb][AIX] get host info for AIX (#134354)

Author: Hemang Gadhavi Date: 2025-04-29T11:23:03+05:30 New Revision: d1bb8d6a5c4a36490298ca75d144805179cc3b40 URL: https://github.com/llvm/llvm-project/commit/d1bb8d6a5c4a36490298ca75d144805179cc3b40 DIFF: https://github.com/llvm/llvm-project/commit/d1bb8d6a5c4a36490298ca75d144805179cc3b40.diff

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (PR #134354)

https://github.com/DhruvSrivastavaX approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/134354 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support alternatives for scope format entries (PR #137751)

JDevlieghere wrote: @labath this ended up quite different from the bash-like syntax that we discussed at EuroLLVM [1]. Using a single character keeps the parsing code simple and limiting this to scopes eliminates some design complexity like recursion. The current implementation covers all of m

[Lldb-commits] [lldb] [lldb] Support alternatives for scope format entries (PR #137751)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This PR implements support for specifying multiple alternatives for scope format entries. Scopes are used to enclose things that should only be printed when everything in the scope resolves. For ex

[Lldb-commits] [lldb] [lldb] Support alternatives for scope format entries (PR #137751)

https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/137751 This PR implements support for specifying multiple alternatives for scope format entries. Scopes are used to enclose things that should only be printed when everything in the scope resolves. For example,

[Lldb-commits] [lldb] [lldb] print a notice when `source list` paging reaches the end of th… (PR #137515)

hapee wrote: > It seems wrong to have the source manager pretend there are more lines in the > file with the content "there are no more lines in this file". At some point, > someone is going to want to know that there are no more lines and this > artificial content will be confusing. > >

[Lldb-commits] [lldb] [lldb] print a notice when `source list` paging reaches the end of th… (PR #137515)

https://github.com/hapee updated https://github.com/llvm/llvm-project/pull/137515 >From cc39f344a5284c16e2b446cde796681f1daa2888 Mon Sep 17 00:00:00 2001 From: hapee <623151...@qq.com> Date: Sun, 27 Apr 2025 18:27:04 +0800 Subject: [PATCH] [lldb] print a notice when `source list` paging

[Lldb-commits] [lldb] Fix the lldb-dap error when empty source map is specified (PR #137722)

https://github.com/ashgti approved this pull request. Should we also add a test for the `attach` request as well? https://github.com/llvm/llvm-project/pull/137722 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[Lldb-commits] [lldb] Fix the lldb-dap error when empty source map is specified (PR #137722)

https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/137722 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Format] Make function name frame-format variables work without debug-info (PR #137408)

slackito wrote: I think this change broke lldb/test/Shell/Unwind/split-machine-functions.test. I can reproduce locally at HEAD with `ninja check-lldb-shell-unwind`. The test binary has a symbol named `_Z3foov.cold` and the test expects the backtrace to print the name of the cold part of the fu

[Lldb-commits] [lldb] 82ab359 - [lldb-dap] Fix machine-overridable scope (#137723)

Author: Jonas Devlieghere Date: 2025-04-28T17:01:03-07:00 New Revision: 82ab35961f62c8019f3b0129da42c42287a557b0 URL: https://github.com/llvm/llvm-project/commit/82ab35961f62c8019f3b0129da42c42287a557b0 DIFF: https://github.com/llvm/llvm-project/commit/82ab35961f62c8019f3b0129da42c42287a557b0.d

[Lldb-commits] [lldb] [lldb-dap] Fix machine-overridable scope (PR #137723)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/137723 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix machine-overridable scope (PR #137723)

https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/137723 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

@@ -210,6 +210,7 @@ Clang. Then we build the ``ALL`` target with ninja: :: $ cmake -B /path/to/llvm-build -G Ninja \ + -DCMAKE_BUILD_TYPE=[] \ -DLLVM_ENABLE_PROJECTS=clang \ [] /path/to/llvm-project/llvm chelcassanova wrote: F

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

https://github.com/kusmour updated https://github.com/llvm/llvm-project/pull/137278 >From fc5e5e4d10f15608cc7727b5ad6af6237417d36c Mon Sep 17 00:00:00 2001 From: Wanyi Ye Date: Thu, 24 Apr 2025 13:30:26 -0700 Subject: [PATCH 1/3] [lldb-dap] Fix TestDap_attach.py flakiness Looks like these 2 te

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

@@ -380,6 +380,18 @@ def wait_for_event(self, filter=None, timeout=None): ) return None +def wait_for_events(self, events, timeout=None): +"""Wait for a list of events in `events` in any order. +Return the events not hit before the timeo

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/137278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/137278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

@@ -380,6 +380,18 @@ def wait_for_event(self, filter=None, timeout=None): ) return None +def wait_for_events(self, events, timeout=None): +"""Wait for a list of events in `events` in any order. +Return the events not hit before the timeo

[Lldb-commits] [lldb] [lldb] Make duplicate test names a conditional exception (PR #137681)

kastiglione wrote: @JDevlieghere Does lit run all tests, even those that have duplicate names? If so, it seems like a step back to break lit from doing what it's capable of doing. This code contains the below comment that proposes eliminating the test name uniqueness constraint. If that is th

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

@@ -380,6 +380,18 @@ def wait_for_event(self, filter=None, timeout=None): ) return None +def wait_for_events(self, events, timeout=None): +"""Wait for a list of events in `events` in any order. +Return the events not hit before the timeo

[Lldb-commits] [lldb] [lldb] Provide an unconditional @skip annotation for API tests (PR #137712)

https://github.com/felipepiovezan approved this pull request. Nice! https://github.com/llvm/llvm-project/pull/137712 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Provide an unconditional @skip annotation for API tests (PR #137712)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes The correct way of doing this today is to use `@skipIf` with no arguments, which reads like it expects a condition. Fixes #137710 --- Full diff: https://github.com/llvm/llvm-project/pull/137712.dif

[Lldb-commits] [lldb] [lldb] Provide an unconditional @skip annotation for API tests (PR #137712)

https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/137712 The correct way of doing this today is to use `@skipIf` with no arguments, which reads like it expects a condition. Fixes #137710 >From 241a2959e72351d28c653a68aaead3cf34e5 Mon Sep 17 00:00:00 2001 Fr

[Lldb-commits] [lldb] [LLDB] Fix `ValueObject::AddressOf()` return value (PR #137688)

jimingham wrote: What is the reason for making this change? https://github.com/llvm/llvm-project/pull/137688 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

@@ -210,6 +210,7 @@ Clang. Then we build the ``ALL`` target with ninja: :: $ cmake -B /path/to/llvm-build -G Ninja \ + -DCMAKE_BUILD_TYPE=[] \ -DLLVM_ENABLE_PROJECTS=clang \ [] /path/to/llvm-project/llvm chelcassanova wrote: I

[Lldb-commits] [lldb] 7d4e6ff - [lldb-dap] Bump the version to 0.2.13

Author: Jonas Devlieghere Date: 2025-04-28T14:11:01-07:00 New Revision: 7d4e6ff2169998e43f5072e022e34c6e0324e123 URL: https://github.com/llvm/llvm-project/commit/7d4e6ff2169998e43f5072e022e34c6e0324e123 DIFF: https://github.com/llvm/llvm-project/commit/7d4e6ff2169998e43f5072e022e34c6e0324e123.d

[Lldb-commits] [lldb] b73169a - [lldb] Disable TestDAP_attachByPortNum

Author: Felipe de Azevedo Piovezan Date: 2025-04-28T14:08:14-07:00 New Revision: b73169ad3edc56fe2b4f5bd3d5259310168da50c URL: https://github.com/llvm/llvm-project/commit/b73169ad3edc56fe2b4f5bd3d5259310168da50c DIFF: https://github.com/llvm/llvm-project/commit/b73169ad3edc56fe2b4f5bd3d52593101

[Lldb-commits] [lldb] [lldb-dap] Adding an icon to the lldb-dap package. (PR #137695)

https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/137695 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4fa0f1d - [lldb-dap] Adding an icon to the lldb-dap package. (#137695)

Author: John Harrison Date: 2025-04-28T14:02:36-07:00 New Revision: 4fa0f1d166b6b39a80dd0b8eb820122ccc410c43 URL: https://github.com/llvm/llvm-project/commit/4fa0f1d166b6b39a80dd0b8eb820122ccc410c43 DIFF: https://github.com/llvm/llvm-project/commit/4fa0f1d166b6b39a80dd0b8eb820122ccc410c43.diff

[Lldb-commits] [lldb] [lldb] Make duplicate test names a conditional exception (PR #137681)

JDevlieghere wrote: Rather than making this more lenient, could we go the opposite direction and make it so that we catch this issue when lit runs and the test suite falls over? I assume this is going unnoticed until someone uses `dotest` with the `-p` argument. https://github.com/llvm/llvm-

[Lldb-commits] [lldb] [lldb-dap] Adding defaults to VSCode settings for user level defaults. (PR #137694)

https://github.com/JDevlieghere commented: Can you update the README that talks about these settings and explain the precedence between the launch/attach configuration and the settings? It'd be nice to give some guidance so folks know where to configure things based on their needs. Otherwise t

[Lldb-commits] [lldb] [lldb-dap] Adding an icon to the lldb-dap package. (PR #137695)

https://github.com/JDevlieghere approved this pull request. LGTM. I wish we had a logo for LLDB that we could use for this, but this is a good solution until/if that ever changes. https://github.com/llvm/llvm-project/pull/137695 ___ lldb-commits mail

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

@@ -210,6 +210,7 @@ Clang. Then we build the ``ALL`` target with ninja: :: $ cmake -B /path/to/llvm-build -G Ninja \ + -DCMAKE_BUILD_TYPE=[] \ -DLLVM_ENABLE_PROJECTS=clang \ [] /path/to/llvm-project/llvm bulbazord wrote: I thi

[Lldb-commits] [lldb] [lldb-dap] Adding an icon to the lldb-dap package. (PR #137695)

ashgti wrote: Resolves #137294 https://github.com/llvm/llvm-project/pull/137695 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding an icon to the lldb-dap package. (PR #137695)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes This shows up in the extension UI and in the VSCode extension marketplace. I used the llvm/llvm-www/blob/main/img/LLVMWyvernSmall.png for the image. Here is what this looks like locally:

[Lldb-commits] [lldb] [LLDB] Fix `ValueObject::AddressOf()` return value (PR #137688)

kuilpd wrote: If I apply code formatter to the test, it breaks lines and no longer works. Should I rewrite it without using inline tests? https://github.com/llvm/llvm-project/pull/137688 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [lldb] [lldb-dap] Adding defaults to VSCode settings for user level defaults. (PR #137694)

eronnen wrote: Nice!! https://github.com/llvm/llvm-project/pull/137694 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding defaults to VSCode settings for user level defaults. (PR #137694)

ashgti wrote: @eronnen this should resolve #134564 https://github.com/llvm/llvm-project/pull/137694 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding defaults to VSCode settings for user level defaults. (PR #137694)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes This adds support for loading user level defaults in VSCode. The defaults are stored as basic settings that are loaded when the debug configuration is resolved. Not all settings are currently supported, I lim

[Lldb-commits] [lldb] [lldb-dap] Adding defaults to VSCode settings for user level defaults. (PR #137694)

https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/137694 This adds support for loading user level defaults in VSCode. The defaults are stored as basic settings that are loaded when the debug configuration is resolved. Not all settings are currently supported, I limite

[Lldb-commits] [lldb] [debugserver] Remove PThreadMutex (NFC) (PR #137555)

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/15188 Here is the relevant piece of the build log

[Lldb-commits] [lldb] [LLDB] Fix `ValueObject::AddressOf()` return value (PR #137688)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/source/ValueObject/ValueObject.cpp lldb/test/AP

[Lldb-commits] [lldb] [LLDB] Add unary operators Dereference and AddressOf to DIL (PR #134428)

@@ -232,4 +263,105 @@ Interpreter::Visit(const IdentifierNode *node) { return identifier; } -} // namespace lldb_private::dil +llvm::Expected +Interpreter::Visit(const UnaryOpNode *node) { + FlowAnalysis rhs_flow( + /* address_of_is_pending */ node->kind() == UnaryOpKi

[Lldb-commits] [lldb] [LLDB] Fix `ValueObject::AddressOf()` return value (PR #137688)

https://github.com/kuilpd created https://github.com/llvm/llvm-project/pull/137688 `ValueObject::AddressOf()` used to return address as a value which has it's own address, allowing to do `value.AddressOf().AddressOf()`. This patch makes the return address a simple const value. >From 5108154682

[Lldb-commits] [lldb] [lldb] Make duplicate test names a conditional exception (PR #137681)

https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/137681 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove Function null checks in Block.cpp (PR #137611)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/137611 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [debugserver] Remove PThreadMutex (NFC) (PR #137555)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/137555 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9d77a3f - [debugserver] Remove PThreadMutex (NFC) (#137555)

Author: Jonas Devlieghere Date: 2025-04-28T11:28:45-07:00 New Revision: 9d77a3fa1a4a68a53309022863d32e9d5717 URL: https://github.com/llvm/llvm-project/commit/9d77a3fa1a4a68a53309022863d32e9d5717 DIFF: https://github.com/llvm/llvm-project/commit/9d77a3fa1a4a68a53309022863d32e9d5717.d

[Lldb-commits] [lldb] [lldb] Make duplicate test names a conditional exception (PR #137681)

https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/137681 >From bbf439758fd2b98389c6df81dd9bede24c59a029 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Mon, 28 Apr 2025 10:55:55 -0700 Subject: [PATCH] [lldb] Make duplicate test names a conditional exception When tw

[Lldb-commits] [lldb] [lldb] Make duplicate test names a conditional exception (PR #137681)

https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/137681 >From bbf439758fd2b98389c6df81dd9bede24c59a029 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Mon, 28 Apr 2025 10:55:55 -0700 Subject: [PATCH 1/2] [lldb] Make duplicate test names a conditional exception Whe

[Lldb-commits] [lldb] [lldb] Make duplicate test names a conditional exception (PR #137681)

kastiglione wrote: This came up last week, where a duplicated test name (https://github.com/llvm/llvm-project/pull/137262) prevented me from running my own tests with `lldb-dotest -p `. https://github.com/llvm/llvm-project/pull/137681 ___ lldb-commit

[Lldb-commits] [lldb] [lldb] Make duplicate test names a conditional exception (PR #137681)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes When two or more tests have the same name, dotest will raise an exception. However, when using a test name pattern (`-p`) which does not match the duplicate test names, there seems to be no reason to prevent

[Lldb-commits] [lldb] [lldb] Make duplicate test names a conditional exception (PR #137681)

https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/137681 When two or more tests have the same name, dotest will raise an exception. However, when using a test name pattern (`-p`) which does not match the duplicate test names, there seems to be no reason to preven

[Lldb-commits] [lldb] [debugserver] Remove PThreadMutex (NFC) (PR #137555)

https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/137555 >From 1ebef7a5a58c8153e387f299d4831587e5af82c2 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Sun, 27 Apr 2025 14:55:34 -0700 Subject: [PATCH] [debugserver] Remove PThreadMutex (NFC) Now that all u

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

@@ -0,0 +1,13 @@ +// Skipping temporarily due to rdar://14958 chelcassanova wrote: The issue is that the tests need the clang resource dir in order to run properly (since `lldb-rpc-gen` is a `ClangTool`). They were originally skipped so that I could add tha

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

https://github.com/chelcassanova edited https://github.com/llvm/llvm-project/pull/137383 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

@@ -210,6 +210,7 @@ Clang. Then we build the ``ALL`` target with ninja: :: $ cmake -B /path/to/llvm-build -G Ninja \ + -DCMAKE_BUILD_TYPE=[] \ -DLLVM_ENABLE_PROJECTS=clang \ [] /path/to/llvm-project/llvm chelcassanova wrote: I

[Lldb-commits] [lldb] 64737ce - [lldb-dap] Bump the version to 0.2.12

Author: Jonas Devlieghere Date: 2025-04-28T10:33:22-07:00 New Revision: 64737ceb9a2060db940e4562fe04887e73f7a65c URL: https://github.com/llvm/llvm-project/commit/64737ceb9a2060db940e4562fe04887e73f7a65c DIFF: https://github.com/llvm/llvm-project/commit/64737ceb9a2060db940e4562fe04887e73f7a65c.d

[Lldb-commits] [lldb] [debugserver] Migrate PThreadEvent away from PThreadMutex (NFC) (PR #137554)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/137554 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 46fd2b9 - [debugserver] Migrate PThreadEvent away from PThreadMutex (NFC) (#137554)

Author: Jonas Devlieghere Date: 2025-04-28T10:31:59-07:00 New Revision: 46fd2b94affdb4727a2a0757d3de269989428df0 URL: https://github.com/llvm/llvm-project/commit/46fd2b94affdb4727a2a0757d3de269989428df0 DIFF: https://github.com/llvm/llvm-project/commit/46fd2b94affdb4727a2a0757d3de269989428df0.d

[Lldb-commits] [lldb] [lldb] Upstream lldb-rpc-gen and LLDB RPC server-side emitters (PR #136748)

@@ -0,0 +1,13 @@ +// Skipping temporarily due to rdar://14958 medismailben wrote: This is probably just an artifact of the downstream fork, I believe @chelcassanova has a fix for this already https://github.com/llvm/llvm-project/pull/136748

[Lldb-commits] [lldb] [lldb/Format] Make progress count show thousands separators (NFC) (PR #137446)

https://github.com/medismailben closed https://github.com/llvm/llvm-project/pull/137446 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4e4c6d7 - [lldb/Format] Make progress count show thousands separators (NFC) (#137446)

Author: Med Ismail Bennani Date: 2025-04-28T10:26:40-07:00 New Revision: 4e4c6d7e273a91d230389b98c280c9dbde0f6c32 URL: https://github.com/llvm/llvm-project/commit/4e4c6d7e273a91d230389b98c280c9dbde0f6c32 DIFF: https://github.com/llvm/llvm-project/commit/4e4c6d7e273a91d230389b98c280c9dbde0f6c32.

[Lldb-commits] [lldb] [debugserver] Migrate PThreadEvent away from PThreadMutex (NFC) (PR #137554)

https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/137554 >From 17adb27c995a4bcf5218c50a8849d571085005b6 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Sun, 27 Apr 2025 14:51:22 -0700 Subject: [PATCH] [debugserver] Migrate PThreadEvent away from PThreadMut

[Lldb-commits] [lldb] [lldb] Make ValueObject::Dereference less aggressive (PR #137311)

https://github.com/kuilpd approved this pull request. I see, makes sense now, thank you. https://github.com/llvm/llvm-project/pull/137311 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

@@ -210,6 +210,7 @@ Clang. Then we build the ``ALL`` target with ninja: :: $ cmake -B /path/to/llvm-build -G Ninja \ + -DCMAKE_BUILD_TYPE=[] \ -DLLVM_ENABLE_PROJECTS=clang \ [] /path/to/llvm-project/llvm JDevlieghere wrote: Is

[Lldb-commits] [lldb] [debugserver] Migrate PThreadEvent away from PThreadMutex (NFC) (PR #137554)

https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/137554 >From c59e2ed1ab50d07eb669cb8d6051ce579a7d193b Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Sun, 27 Apr 2025 14:51:22 -0700 Subject: [PATCH] [debugserver] Migrate PThreadEvent away from PThreadMut

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

chelcassanova wrote: > I'd have guessed it's required for a standalone build as well, but you're not > changing that, so it must not be? (assuming that "standalone build" here refers to "LLDB standalone build") Not as far as I can see. The LLVM top-level CMakeLists.txt file checks for the bui

[Lldb-commits] [lldb] [debugserver] Migrate PThreadEvent away from PThreadMutex (NFC) (PR #137554)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- lldb/tools/debugserver/source/PThreadEvent.cpp lld

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang][frontend] Require invocation to construct `CompilerInstance` (PR #137668)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- clang-tools-extra/clang-include-fixer/IncludeFixer.

[Lldb-commits] [lldb] [debugserver] Migrate PThreadEvent away from PThreadMutex (NFC) (PR #137554)

https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/137554 >From 735606c56082cef7c885ac653dbab2cc8cb62bf4 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Sun, 27 Apr 2025 14:51:22 -0700 Subject: [PATCH] [debugserver] Migrate PThreadEvent away from PThreadMut

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang][frontend] Require invocation to construct `CompilerInstance` (PR #137668)

llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Jan Svoboda (jansvoboda11) Changes This PR makes it so that `CompilerInvocation` needs to be provided to `CompilerInstance` on construction. There are a couple of benefits in my view: * Making it impossible to mis-use some `Com

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang][frontend] Require invocation to construct `CompilerInstance` (PR #137668)

llvmbot wrote: @llvm/pr-subscribers-clangd Author: Jan Svoboda (jansvoboda11) Changes This PR makes it so that `CompilerInvocation` needs to be provided to `CompilerInstance` on construction. There are a couple of benefits in my view: * Making it impossible to mis-use some `CompilerInstan

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang][frontend] Require invocation to construct `CompilerInstance` (PR #137668)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Jan Svoboda (jansvoboda11) Changes This PR makes it so that `CompilerInvocation` needs to be provided to `CompilerInstance` on construction. There are a couple of benefits in my view: * Making it impossible to mis-use some `CompilerInstanc

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang][frontend] Require invocation to construct `CompilerInstance` (PR #137668)

https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/137668 This PR makes it so that `CompilerInvocation` needs to be provided to `CompilerInstance` on construction. There are a couple of benefits in my view: * Making it impossible to mis-use some `CompilerInstance`

[Lldb-commits] [clang] [lldb] [clang] Add `__ptrauth_restricted_intptr` qualifier (PR #137580)

ojhunt wrote: > Perhaps silly initial question: why do we need a whole different qualifier > for this? Why can you not write `__ptrauth uintptr_t foo`? Not a silly question, back when first implemented we spent time thinking about this. The concern was basically `T* __ptrauth(...)` can repres

[Lldb-commits] [lldb] 9f2bcc7 - [debugserver] Migrate DNBTimer away from PThreadMutex (NFC) (#137540)

Author: Jonas Devlieghere Date: 2025-04-28T09:44:14-07:00 New Revision: 9f2bcc7a663dc36c3cd0b3d6c3616d9661a03c0f URL: https://github.com/llvm/llvm-project/commit/9f2bcc7a663dc36c3cd0b3d6c3616d9661a03c0f DIFF: https://github.com/llvm/llvm-project/commit/9f2bcc7a663dc36c3cd0b3d6c3616d9661a03c0f.d

[Lldb-commits] [lldb] [lldb] add settings to control how synthetic symbol names are generated (PR #137512)

eronnen wrote: The use case is to make it easier to work with static disassemblers: If I see an interesting unnamed function while debugging, it would be immediate to search it in the static disassembler if it was named `lldb_unnamed_symbol_{file-addreds}` as opposed to a random index. Also vic

[Lldb-commits] [lldb] 41ab76b - Revert "[debugserver] Migrate DNBTimer away from PThreadMutex (NFC) (#137540)"

Author: Jonas Devlieghere Date: 2025-04-28T08:44:30-07:00 New Revision: 41ab76bf0aafb35d6d023429560b44637dfb8de6 URL: https://github.com/llvm/llvm-project/commit/41ab76bf0aafb35d6d023429560b44637dfb8de6 DIFF: https://github.com/llvm/llvm-project/commit/41ab76bf0aafb35d6d023429560b44637dfb8de6.d

[Lldb-commits] [lldb] [LLDB] Add unary operators Dereference and AddressOf to DIL (PR #134428)

labath wrote: Yes, I think that would be best, although if you structure the error message like the current command, it may not be even necessary to have a dedicated error message for that. This is what I get with the current implementation, and I think it's quite okay: ``` (lldb) v *x.x->x->x

[Lldb-commits] [lldb] [lldb] Make ValueObject::Dereference less aggressive (PR #137311)

labath wrote: > So the difference is that if `value->Dereference` fails, the user should try > to manually dereference a synthetic value? If that's what they want, yes. > Are there no other users of this function other than the ones you addressed > in this patch? What about some Python code s

[Lldb-commits] [lldb] [lldb] Remove Function null checks in Block.cpp (PR #137611)

https://github.com/DavidSpickett approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/137611 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make ValueObject::Dereference less aggressive (PR #137311)

https://github.com/labath updated https://github.com/llvm/llvm-project/pull/137311 >From a295fdb31c59050f9b6d9fc9ba4e0156a7e35c1b Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Fri, 25 Apr 2025 11:21:52 +0200 Subject: [PATCH 1/2] [lldb] Make ValueObject::Dereference less aggressive The func

[Lldb-commits] [lldb] [lldb] Remove Function null checks in Block.cpp (PR #137611)

labath wrote: > > We can't change the signature of CalculateSymbolContextFunction as it's an > > abstract function (and some of its implementations can return nullptr) > > By which you mean, because there are still use cases for > `CalculateSymbolContextFunction` to return `nullptr`, so it mus

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Hide the `TargetOptions` pointer from `CompilerInvocation` (PR #106271)

https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/106271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 985410f - [clang] Hide the `TargetOptions` pointer from `CompilerInvocation` (#106271)

Author: Jan Svoboda Date: 2025-04-28T07:43:26-07:00 New Revision: 985410f87f2d19910a8d327527fd30062b042b63 URL: https://github.com/llvm/llvm-project/commit/985410f87f2d19910a8d327527fd30062b042b63 DIFF: https://github.com/llvm/llvm-project/commit/985410f87f2d19910a8d327527fd30062b042b63.diff L

  1   2   >