hapeeeeee wrote: > It seems wrong to have the source manager pretend there are more lines in the > file with the content "there are no more lines in this file". At some point, > someone is going to want to know that there are no more lines and this > artificial content will be confusing. > > It would be better to have the source manager return some kind of error and > have the printer cons up the user-facing message.
I believe you are correct. I have updated the code so that the prompt output is now returned by `SourceManager`, and I have differentiated the causes. Could you please review my commit again? @jimingham https://github.com/llvm/llvm-project/pull/137515 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
